Encapsulating simple license backup to a disk
1
I am enapsulating my license backup to disk, using an interface ILicenseProvider and the implementation is DiskLicenseProvider. Also i am throwing an unchecked exception LicenseProviderException which wraps the checked exceptions in order to enable a central point of exception handling. Kindly review my code. What changes should I make?
public class LicenseProviderException extends RuntimeException {
public LicenseProviderException(String message) {
super(message);
}
}
public class DiskLicenseProvider implements ILicenseProvider {
private static final String APP_DIRECTORY = "test";
private static final String LICENSE_FILENAME = "license.txt";
private static final String TAG = DiskLicenseProvider.class.getSimpleName();
private File appDirectory = new File(Environment.getExternalStorageDirectory(), APP_DIRECTORY);
private File licenseFile = new File(appDirectory, LICENSE_FILENAME);
@Override
public boolean licenseExists() {
return (appDirectory.exists() && licenseFile.exists() && licenseFile.length() > 0);
}
@Override
public String getLicense() throws LicenseProviderException {
StringBuilder builder = new StringBuilder();
if (licenseExists()) {
BufferedReader bufferedReader;
try {
bufferedReader = new BufferedReader(new FileReader(licenseFile));
String line;
while ((line = bufferedReader.readLine()) != null) {
builder.append(line);
}
bufferedReader.close();
} catch (FileNotFoundException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to find license file");
} catch (IOException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to read license file");
}
}
return builder.toString();
}
@Override
public void saveLicense(String license) throws LicenseProviderException{
if (!appDirectory.exists()) {
if (!appDirectory.mkdirs()) {
throw new LicenseProviderException("Unable to create application directory");
}
}
try {
FileWriter fileWriter = new FileWriter(licenseFile);
fileWriter.write(license);
fileWriter.close();
} catch (IOException e) {
Log.d(TAG, "saveLicense() called with: license = [" + license + "]");
throw new LicenseProviderException("Unable to save license");
}
}
}
public interface ILicenseProvider {
boolean licenseExists();
String getLicense();
void saveLicense(String license);
}
java object-oriented android file
edited Nov 13 at 7:04
200_success
128k15150412
asked Nov 13 at 5:40
Aqib
61
add a comment |
1
I am enapsulating my license backup to disk, using an interface ILicenseProvider and the implementation is DiskLicenseProvider. Also i am throwing an unchecked exception LicenseProviderException which wraps the checked exceptions in order to enable a central point of exception handling. Kindly review my code. What changes should I make?
public class LicenseProviderException extends RuntimeException {
public LicenseProviderException(String message) {
super(message);
}
}
public class DiskLicenseProvider implements ILicenseProvider {
private static final String APP_DIRECTORY = "test";
private static final String LICENSE_FILENAME = "license.txt";
private static final String TAG = DiskLicenseProvider.class.getSimpleName();
private File appDirectory = new File(Environment.getExternalStorageDirectory(), APP_DIRECTORY);
private File licenseFile = new File(appDirectory, LICENSE_FILENAME);
@Override
public boolean licenseExists() {
return (appDirectory.exists() && licenseFile.exists() && licenseFile.length() > 0);
}
@Override
public String getLicense() throws LicenseProviderException {
StringBuilder builder = new StringBuilder();
if (licenseExists()) {
BufferedReader bufferedReader;
try {
bufferedReader = new BufferedReader(new FileReader(licenseFile));
String line;
while ((line = bufferedReader.readLine()) != null) {
builder.append(line);
}
bufferedReader.close();
} catch (FileNotFoundException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to find license file");
} catch (IOException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to read license file");
}
}
return builder.toString();
}
@Override
public void saveLicense(String license) throws LicenseProviderException{
if (!appDirectory.exists()) {
if (!appDirectory.mkdirs()) {
throw new LicenseProviderException("Unable to create application directory");
}
}
try {
FileWriter fileWriter = new FileWriter(licenseFile);
fileWriter.write(license);
fileWriter.close();
} catch (IOException e) {
Log.d(TAG, "saveLicense() called with: license = [" + license + "]");
throw new LicenseProviderException("Unable to save license");
}
}
}
public interface ILicenseProvider {
boolean licenseExists();
String getLicense();
void saveLicense(String license);
}
java object-oriented android file
edited Nov 13 at 7:04
200_success
128k15150412
asked Nov 13 at 5:40
Aqib
61
add a comment |
1
1
1
I am enapsulating my license backup to disk, using an interface ILicenseProvider and the implementation is DiskLicenseProvider. Also i am throwing an unchecked exception LicenseProviderException which wraps the checked exceptions in order to enable a central point of exception handling. Kindly review my code. What changes should I make?
public class LicenseProviderException extends RuntimeException {
public LicenseProviderException(String message) {
super(message);
}
}
public class DiskLicenseProvider implements ILicenseProvider {
private static final String APP_DIRECTORY = "test";
private static final String LICENSE_FILENAME = "license.txt";
private static final String TAG = DiskLicenseProvider.class.getSimpleName();
private File appDirectory = new File(Environment.getExternalStorageDirectory(), APP_DIRECTORY);
private File licenseFile = new File(appDirectory, LICENSE_FILENAME);
@Override
public boolean licenseExists() {
return (appDirectory.exists() && licenseFile.exists() && licenseFile.length() > 0);
}
@Override
public String getLicense() throws LicenseProviderException {
StringBuilder builder = new StringBuilder();
if (licenseExists()) {
BufferedReader bufferedReader;
try {
bufferedReader = new BufferedReader(new FileReader(licenseFile));
String line;
while ((line = bufferedReader.readLine()) != null) {
builder.append(line);
}
bufferedReader.close();
} catch (FileNotFoundException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to find license file");
} catch (IOException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to read license file");
}
}
return builder.toString();
}
@Override
public void saveLicense(String license) throws LicenseProviderException{
if (!appDirectory.exists()) {
if (!appDirectory.mkdirs()) {
throw new LicenseProviderException("Unable to create application directory");
}
}
try {
FileWriter fileWriter = new FileWriter(licenseFile);
fileWriter.write(license);
fileWriter.close();
} catch (IOException e) {
Log.d(TAG, "saveLicense() called with: license = [" + license + "]");
throw new LicenseProviderException("Unable to save license");
}
}
}
public interface ILicenseProvider {
boolean licenseExists();
String getLicense();
void saveLicense(String license);
}
java object-oriented android file
edited Nov 13 at 7:04
200_success
128k15150412
asked Nov 13 at 5:40
Aqib
61
I am enapsulating my license backup to disk, using an interface ILicenseProvider and the implementation is DiskLicenseProvider. Also i am throwing an unchecked exception LicenseProviderException which wraps the checked exceptions in order to enable a central point of exception handling. Kindly review my code. What changes should I make?
public class LicenseProviderException extends RuntimeException {
public LicenseProviderException(String message) {
super(message);
}
}
public class DiskLicenseProvider implements ILicenseProvider {
private static final String APP_DIRECTORY = "test";
private static final String LICENSE_FILENAME = "license.txt";
private static final String TAG = DiskLicenseProvider.class.getSimpleName();
private File appDirectory = new File(Environment.getExternalStorageDirectory(), APP_DIRECTORY);
private File licenseFile = new File(appDirectory, LICENSE_FILENAME);
@Override
public boolean licenseExists() {
return (appDirectory.exists() && licenseFile.exists() && licenseFile.length() > 0);
}
@Override
public String getLicense() throws LicenseProviderException {
StringBuilder builder = new StringBuilder();
if (licenseExists()) {
BufferedReader bufferedReader;
try {
bufferedReader = new BufferedReader(new FileReader(licenseFile));
String line;
while ((line = bufferedReader.readLine()) != null) {
builder.append(line);
}
bufferedReader.close();
} catch (FileNotFoundException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to find license file");
} catch (IOException e) {
Log.d(TAG, "getLicense() called");
throw new LicenseProviderException("Unable to read license file");
}
}
return builder.toString();
}
@Override
public void saveLicense(String license) throws LicenseProviderException{
if (!appDirectory.exists()) {
if (!appDirectory.mkdirs()) {
throw new LicenseProviderException("Unable to create application directory");
}
}
try {
FileWriter fileWriter = new FileWriter(licenseFile);
fileWriter.write(license);
fileWriter.close();
} catch (IOException e) {
Log.d(TAG, "saveLicense() called with: license = [" + license + "]");
throw new LicenseProviderException("Unable to save license");
}
}
}
public interface ILicenseProvider {
boolean licenseExists();
String getLicense();
void saveLicense(String license);
}
java object-oriented android file
java object-oriented android file
edited Nov 13 at 7:04
200_success
128k15150412
asked Nov 13 at 5:40
Aqib
61
edited Nov 13 at 7:04
200_success
128k15150412
asked Nov 13 at 5:40
Aqib
61
edited Nov 13 at 7:04
200_success
128k15150412
edited Nov 13 at 7:04
200_success
128k15150412
edited Nov 13 at 7:04
200_success
128k15150412
128k15150412
asked Nov 13 at 5:40
Aqib
61
asked Nov 13 at 5:40
Aqib
61
asked Nov 13 at 5:40
Aqib
61
61
add a comment |
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f207529%2fencapsulating-simple-license-backup-to-a-disk%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f207529%2fencapsulating-simple-license-backup-to-a-disk%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
