Linked list in Python












0















Below is my attempt at a doubly-linked list in Python (3):



class LinkedListNode:
def __init__(self, value):
self.value = value
self.left = None
self.right = None


class LinkedList:
def __init__(self):
self.head = self.tail = None
self.size = 0

def get_first(self):
if self.head:
return self.head.value
raise Exception('Reading from an empty list.')

def get_last(self):
if self.tail:
return self.tail.value
raise Exception('Reading from an empty list.')

def add_first(self, value):
node = LinkedListNode(value)
if self.head:
node.right = self.head
self.head.left = node
self.size += 1
else:
self.head = self.tail = LinkedListNode(value)
self.size = 1

def add_last(self, value):
node = LinkedListNode(value)
if self.tail:
node.left = self.tail
self.tail.right = node
self.size += 1
else:
self.head = self.tail = node
self.size = 1

def remove_first(self):
if self.head:
ret = self.head.value
self.head = self.head.right
self.head.left = None
self.size -= 1
return ret
raise Exception('Removing from an empty list.')

def remove_last(self):
if self.tail:
ret = self.tail.value
self.tail = self.tail.left
self.tail.right = None
self.size -= 1
return ret
raise Exception('Removing from an empty list.')

def __repr__(self):
str = '['
if self.size > 0:
str += self.head.value
node = self.head.right
while node:
str += ', ' + node.value
node = node.right
return str + ']'


def main():
list = LinkedList()

while True:
cmd_line = input()
if cmd_line == 'quit':
break
command_tokens = cmd_line.split()
command = command_tokens[0]
try:
if command == "get_first":
print(list.get_first())
elif command == "get_last":
print(list.get_last())
elif command == "add_first":
list.add_first(command_tokens[1])
elif command == "add_last":
list.add_last(command_tokens[1])
elif command == "remove_first":
list.remove_first()
elif command == "remove_last":
list.remove_last()
elif command == "print":
print(list)
except Exception:
print("Unknown command")


main()


How would I rewrite it in a professional manner?









share



























    0















    Below is my attempt at a doubly-linked list in Python (3):



    class LinkedListNode:
    def __init__(self, value):
    self.value = value
    self.left = None
    self.right = None


    class LinkedList:
    def __init__(self):
    self.head = self.tail = None
    self.size = 0

    def get_first(self):
    if self.head:
    return self.head.value
    raise Exception('Reading from an empty list.')

    def get_last(self):
    if self.tail:
    return self.tail.value
    raise Exception('Reading from an empty list.')

    def add_first(self, value):
    node = LinkedListNode(value)
    if self.head:
    node.right = self.head
    self.head.left = node
    self.size += 1
    else:
    self.head = self.tail = LinkedListNode(value)
    self.size = 1

    def add_last(self, value):
    node = LinkedListNode(value)
    if self.tail:
    node.left = self.tail
    self.tail.right = node
    self.size += 1
    else:
    self.head = self.tail = node
    self.size = 1

    def remove_first(self):
    if self.head:
    ret = self.head.value
    self.head = self.head.right
    self.head.left = None
    self.size -= 1
    return ret
    raise Exception('Removing from an empty list.')

    def remove_last(self):
    if self.tail:
    ret = self.tail.value
    self.tail = self.tail.left
    self.tail.right = None
    self.size -= 1
    return ret
    raise Exception('Removing from an empty list.')

    def __repr__(self):
    str = '['
    if self.size > 0:
    str += self.head.value
    node = self.head.right
    while node:
    str += ', ' + node.value
    node = node.right
    return str + ']'


    def main():
    list = LinkedList()

    while True:
    cmd_line = input()
    if cmd_line == 'quit':
    break
    command_tokens = cmd_line.split()
    command = command_tokens[0]
    try:
    if command == "get_first":
    print(list.get_first())
    elif command == "get_last":
    print(list.get_last())
    elif command == "add_first":
    list.add_first(command_tokens[1])
    elif command == "add_last":
    list.add_last(command_tokens[1])
    elif command == "remove_first":
    list.remove_first()
    elif command == "remove_last":
    list.remove_last()
    elif command == "print":
    print(list)
    except Exception:
    print("Unknown command")


    main()


    How would I rewrite it in a professional manner?









    share

























      0












      0








      0








      Below is my attempt at a doubly-linked list in Python (3):



      class LinkedListNode:
      def __init__(self, value):
      self.value = value
      self.left = None
      self.right = None


      class LinkedList:
      def __init__(self):
      self.head = self.tail = None
      self.size = 0

      def get_first(self):
      if self.head:
      return self.head.value
      raise Exception('Reading from an empty list.')

      def get_last(self):
      if self.tail:
      return self.tail.value
      raise Exception('Reading from an empty list.')

      def add_first(self, value):
      node = LinkedListNode(value)
      if self.head:
      node.right = self.head
      self.head.left = node
      self.size += 1
      else:
      self.head = self.tail = LinkedListNode(value)
      self.size = 1

      def add_last(self, value):
      node = LinkedListNode(value)
      if self.tail:
      node.left = self.tail
      self.tail.right = node
      self.size += 1
      else:
      self.head = self.tail = node
      self.size = 1

      def remove_first(self):
      if self.head:
      ret = self.head.value
      self.head = self.head.right
      self.head.left = None
      self.size -= 1
      return ret
      raise Exception('Removing from an empty list.')

      def remove_last(self):
      if self.tail:
      ret = self.tail.value
      self.tail = self.tail.left
      self.tail.right = None
      self.size -= 1
      return ret
      raise Exception('Removing from an empty list.')

      def __repr__(self):
      str = '['
      if self.size > 0:
      str += self.head.value
      node = self.head.right
      while node:
      str += ', ' + node.value
      node = node.right
      return str + ']'


      def main():
      list = LinkedList()

      while True:
      cmd_line = input()
      if cmd_line == 'quit':
      break
      command_tokens = cmd_line.split()
      command = command_tokens[0]
      try:
      if command == "get_first":
      print(list.get_first())
      elif command == "get_last":
      print(list.get_last())
      elif command == "add_first":
      list.add_first(command_tokens[1])
      elif command == "add_last":
      list.add_last(command_tokens[1])
      elif command == "remove_first":
      list.remove_first()
      elif command == "remove_last":
      list.remove_last()
      elif command == "print":
      print(list)
      except Exception:
      print("Unknown command")


      main()


      How would I rewrite it in a professional manner?









      share














      Below is my attempt at a doubly-linked list in Python (3):



      class LinkedListNode:
      def __init__(self, value):
      self.value = value
      self.left = None
      self.right = None


      class LinkedList:
      def __init__(self):
      self.head = self.tail = None
      self.size = 0

      def get_first(self):
      if self.head:
      return self.head.value
      raise Exception('Reading from an empty list.')

      def get_last(self):
      if self.tail:
      return self.tail.value
      raise Exception('Reading from an empty list.')

      def add_first(self, value):
      node = LinkedListNode(value)
      if self.head:
      node.right = self.head
      self.head.left = node
      self.size += 1
      else:
      self.head = self.tail = LinkedListNode(value)
      self.size = 1

      def add_last(self, value):
      node = LinkedListNode(value)
      if self.tail:
      node.left = self.tail
      self.tail.right = node
      self.size += 1
      else:
      self.head = self.tail = node
      self.size = 1

      def remove_first(self):
      if self.head:
      ret = self.head.value
      self.head = self.head.right
      self.head.left = None
      self.size -= 1
      return ret
      raise Exception('Removing from an empty list.')

      def remove_last(self):
      if self.tail:
      ret = self.tail.value
      self.tail = self.tail.left
      self.tail.right = None
      self.size -= 1
      return ret
      raise Exception('Removing from an empty list.')

      def __repr__(self):
      str = '['
      if self.size > 0:
      str += self.head.value
      node = self.head.right
      while node:
      str += ', ' + node.value
      node = node.right
      return str + ']'


      def main():
      list = LinkedList()

      while True:
      cmd_line = input()
      if cmd_line == 'quit':
      break
      command_tokens = cmd_line.split()
      command = command_tokens[0]
      try:
      if command == "get_first":
      print(list.get_first())
      elif command == "get_last":
      print(list.get_last())
      elif command == "add_first":
      list.add_first(command_tokens[1])
      elif command == "add_last":
      list.add_last(command_tokens[1])
      elif command == "remove_first":
      list.remove_first()
      elif command == "remove_last":
      list.remove_last()
      elif command == "print":
      print(list)
      except Exception:
      print("Unknown command")


      main()


      How would I rewrite it in a professional manner?







      python linked-list





      share












      share










      share



      share










      asked 4 mins ago









      coderoddecoderodde

      15.7k538127




      15.7k538127






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211455%2flinked-list-in-python%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f211455%2flinked-list-in-python%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀