Ytdyklly

I have to do a project on a game of rock, paper, and scissors, and the code I have so far is a complete code for the game, but my professor does not like it since it is too redundant. Is there anyway to shorten it or make it more simple?

import random



while True:

   bot = random.choice(["Rock", "Paper", "Scissors"]).lower()



   user_choice = input("Choose between Rock, Paper, and Scissors or -1 to exit: n ").lower()

   if user_choice == bot:

      print("We tied! I chose", bot," and you chose", user_choice)

   elif user_choice == "rock":

      if bot == "paper":

         print("You lose! I chose", bot," and you chose", user_choice , ", Paper beats rock!")

      elif bot == "scissors":

       print("You win! I chose", bot," and you chose", user_choice , ", Rock beat scissors!")

   elif user_choice == "paper":

      if bot == "rock":

         print("You win! I chose",bot," and you chose", user_choice , ", Paper beats rock!")

      elif bot == "scissors:":

         print("You lose! I chose", bot," and you chose", user_choice , ", Scissors beats paper")

   elif user_choice == "scissors":

      if bot == "paper":

         print("You win! I chose", bot," and you chose",user_choice, ", Scissors beats paper")

      elif bot == "rock":

         print("You Lose! I chose", bot," and you chose", user_choice , ", Rock beats scissors")

   else:

      print("Invalid Entry, you typed:", user_choice, ", Please try again: ")



   if user_choice == '-1':

      print("You selected -1 to exit, Goodbye!")

exit()

Please run this a few times and let me know what you think. There is almost certainly a way to make this even simpler than I made it (for example, ties are being treated as a special case, but that is not necessary). However, as it is, it at least avoids some of the repetition in the original code.

# note: I'm using 4 spaces for indentations in Python, which is common.

import random





def main():

    while True:

        user_choice = input("Choose between Rock, Paper, and Scissors or -1 to exit: n ").lower()

        # if the user enters -1 this immediately ends everything (note that in your original code that was not the case)

        if user_choice == '-1':

            print("You selected -1 to exit, Goodbye!")

            break

        play_game(user_choice)





def play_game(user_choice):



    # In this situation there is no need for .lower(), just don't capitalize your words in the first place

    # I changed bot to bot_choice so a reader (or your future self) will more immediately know what's in the variable

    bot_choice = random.choice(["rock", "paper", "scissors"])



    if user_choice == bot_choice:

        print("We tied! I chose {} and you chose {}".format(bot_choice, user_choice))

        return



    win_or_lose, winning_object, loosing_object = check_for_win(bot_choice, user_choice)

    if win_or_lose is not None:

        print("You {}! I chose {}, and you chose {}, {} beats {}!".format(win_or_lose, bot_choice, user_choice, winning_object, loosing_object))

        return



    print("Invalid Entry, you typed: {}, Please try again: ".format(user_choice))





def check_for_win(bot_choice, user_choice):

    # dictionary keys are tuples that have possible game-outcomes, dictionary values show winning object give the key

    rules_dictionary = {('paper', 'rock'): 'paper', ('rock', 'scissors'): 'rock', ('paper', 'scissors'): 'scissors'}

    # iterate through the keys of the dictionary

    for two_choices_in_won_game in rules_dictionary:

        if sorted((bot_choice, user_choice)) == sorted(two_choices_in_won_game):

            if bot_choice == rules_dictionary[two_choices_in_won_game]:

                return 'lose', bot_choice, user_choice

            return 'win', user_choice, bot_choice

    return None, None, None





# The below if statement will evaluate to True of your program is run from the command line

if __name__ == '__main__':

    main()