c# mvc login service
$begingroup$
I want to make a service which will authorize users. I want to separate it from controller. The problem is, I can't figure out what should my methods return.
Here is my method:
public async Task<BaseResponse> Login(string email, string pwd)
{
BaseResponse response = new BaseResponse();
var user = userManager.Users.Where(u => u.Email == email).FirstOrDefault();
if (user == null)
{
response.Errors.Add(Errors.WrongEmail);
}
else
{
var result = await signInManager.PasswordSignInAsync(user, pwd, false, false);
if (result.Succeeded)
{
response.Success = true;
}
else
{
response.Errors.Add(Errors.WrongPassword);
}
}
return response;
}
BaseResponse class:
public class BaseResponse
{
public bool Success { get; set; }
public List<string> Errors { get; set; }
public BaseResponse()
{
Errors = new List<string>();
}
}
Errors is a class with strings that contain user-friendly error descriptions. The problem is, I think service shouldn't care about what user will see, it should just return the result of an action, and controller should decide what to show to user. But there are two places where authentication can fail - user not found and login/password don't match, and they are different types of errors. So, I don't know what should be return type of my method. Is this approach right? If so, how should I change signature of my method?
c# mvc asp.net-core asp.net-identity
asked 9 mins ago
JamilJamil
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I want to make a service which will authorize users. I want to separate it from controller. The problem is, I can't figure out what should my methods return.
Here is my method:
public async Task<BaseResponse> Login(string email, string pwd)
{
BaseResponse response = new BaseResponse();
var user = userManager.Users.Where(u => u.Email == email).FirstOrDefault();
if (user == null)
{
response.Errors.Add(Errors.WrongEmail);
}
else
{
var result = await signInManager.PasswordSignInAsync(user, pwd, false, false);
if (result.Succeeded)
{
response.Success = true;
}
else
{
response.Errors.Add(Errors.WrongPassword);
}
}
return response;
}
BaseResponse class:
public class BaseResponse
{
public bool Success { get; set; }
public List<string> Errors { get; set; }
public BaseResponse()
{
Errors = new List<string>();
}
}
Errors is a class with strings that contain user-friendly error descriptions. The problem is, I think service shouldn't care about what user will see, it should just return the result of an action, and controller should decide what to show to user. But there are two places where authentication can fail - user not found and login/password don't match, and they are different types of errors. So, I don't know what should be return type of my method. Is this approach right? If so, how should I change signature of my method?
c# mvc asp.net-core asp.net-identity
asked 9 mins ago
JamilJamil
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I want to make a service which will authorize users. I want to separate it from controller. The problem is, I can't figure out what should my methods return.
Here is my method:
public async Task<BaseResponse> Login(string email, string pwd)
{
BaseResponse response = new BaseResponse();
var user = userManager.Users.Where(u => u.Email == email).FirstOrDefault();
if (user == null)
{
response.Errors.Add(Errors.WrongEmail);
}
else
{
var result = await signInManager.PasswordSignInAsync(user, pwd, false, false);
if (result.Succeeded)
{
response.Success = true;
}
else
{
response.Errors.Add(Errors.WrongPassword);
}
}
return response;
}
BaseResponse class:
public class BaseResponse
{
public bool Success { get; set; }
public List<string> Errors { get; set; }
public BaseResponse()
{
Errors = new List<string>();
}
}
Errors is a class with strings that contain user-friendly error descriptions. The problem is, I think service shouldn't care about what user will see, it should just return the result of an action, and controller should decide what to show to user. But there are two places where authentication can fail - user not found and login/password don't match, and they are different types of errors. So, I don't know what should be return type of my method. Is this approach right? If so, how should I change signature of my method?
c# mvc asp.net-core asp.net-identity
asked 9 mins ago
JamilJamil
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I want to make a service which will authorize users. I want to separate it from controller. The problem is, I can't figure out what should my methods return.
Here is my method:
public async Task<BaseResponse> Login(string email, string pwd)
{
BaseResponse response = new BaseResponse();
var user = userManager.Users.Where(u => u.Email == email).FirstOrDefault();
if (user == null)
{
response.Errors.Add(Errors.WrongEmail);
}
else
{
var result = await signInManager.PasswordSignInAsync(user, pwd, false, false);
if (result.Succeeded)
{
response.Success = true;
}
else
{
response.Errors.Add(Errors.WrongPassword);
}
}
return response;
}
BaseResponse class:
public class BaseResponse
{
public bool Success { get; set; }
public List<string> Errors { get; set; }
public BaseResponse()
{
Errors = new List<string>();
}
}
Errors is a class with strings that contain user-friendly error descriptions. The problem is, I think service shouldn't care about what user will see, it should just return the result of an action, and controller should decide what to show to user. But there are two places where authentication can fail - user not found and login/password don't match, and they are different types of errors. So, I don't know what should be return type of my method. Is this approach right? If so, how should I change signature of my method?
c# mvc asp.net-core asp.net-identity
c# mvc asp.net-core asp.net-identity
asked 9 mins ago
JamilJamil
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 9 mins ago
JamilJamil
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 9 mins ago
JamilJamil
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 9 mins ago
JamilJamil
1
asked 9 mins ago
JamilJamil
1
1
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Jamil is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Jamil is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212366%2fc-mvc-login-service%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Jamil is a new contributor. Be nice, and check out our Code of Conduct.
Jamil is a new contributor. Be nice, and check out our Code of Conduct.
Jamil is a new contributor. Be nice, and check out our Code of Conduct.
Jamil is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212366%2fc-mvc-login-service%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
