Ytdyklly

iextrading has two APIs (v1, v2) which provide financial market data. Following script records a JSON file with their equity information (using a CRON job).

Would you be kind and review it for any possible improvement or anything that may be incorrect?

<?php





date_default_timezone_set("UTC");

ini_set('max_execution_time' , 0);

ini_set('memory_limit','-1');

set_time_limit(0);



$i = new I();

I::scrapeAllStocks($i);



Class I

{





    /**

    *

    * @var an integer for version of iextrading api

    */



    private $version; 



    /**

    *

    * @var a string of iextrading symbols

    */



    private $symbolsPath; 



    /**

    *

    * @var a string of our symbols json directory

    */



    private $symbolsDir; 



    /**

    *

    * @var a string of target path and query

    */



    private $targetQuery; 



    /**

    *

    * @var a string of iextrading base URL

    */



    private $baseUrl; 



    /**

    *

    * @var a string of iextrading end point

    */



    private $endPoint; 



    // For version 1, tokens are not required. 

    // SECRET TOKEN: *********************************

    // PUBLISHABLE TOKEN: *********************************



    ## https://cloud.iexapis.com/beta/iex/tops?symbols=AAPL&token=*********************************



    function __construct()

    {

        $this->version = 2;



        $this->symbolsPath = __DIR__ . "/../../config/symobls.md";

        $this->symbolsDir = __DIR__ . "/../../a/path/to/your/dir/symbols";

        $this->targetQuery = "stock/market/batch?symbols=";



        // baseUrl for version 1



        $this->baseUrl = "https://api.iextrading.com/1.0/";

        // baseUrl for version 2

        // $this->baseUrl = "https://cloud.iexapis.com/beta/";



        // endPoint for version 1

        $this->endPoint = "&types=quote,chart&range=1m&last=10";

        // endPoint for version 2 

        // $this->endPoint = "&token=*********************************&types=quote,chart&range=1m&last=10";



        echo "YAAAY! Class I is running 💚n";

        return true;

    }







    public static function symbs($i){

        $fnm= $i->symbolsPath;

        $cnt= file_get_contents($fnm);

        $sym=preg_split('/rn|r|n/', $cnt);

        $child=array();

        $mother=array();

        $c=100;

        foreach ($sym as $k=>$v){

            $c=$c-1;

            $sym=preg_split('/[t]/', $v);

            array_push($child,$sym);



            if($c<=0){

                $c=100;

                array_push($mother, $child);

                $child=array();

            }



        }

      return $mother;

    }



    public static function scrapeAllStocks($i){

        $vStocks=I::symbs($i);

        $baseUrl=$i->baseUrl.$i->targetQuery;



        $currentTime=date("Y-m-d-H-i-s");

        $allStocks=array();

        foreach ($vStocks as $k=>$v) {

            $s=array_column($v, 0);

            $stockUrl=$baseUrl . implode(",", $s) . $i->endPoint;

            $rawStockJson=file_get_contents($stockUrl);

            $rawStockArray=json_decode($rawStockJson, true);

            $allStocks=array_merge($allStocks, $rawStockArray);

        }



        $allStocksJson=json_encode($allStocks);



        // Write the raw file

        $symbolsDir= $i->symbolsDir;



        if (!is_dir($symbolsDir)) {mkdir($symbolsDir, 0755,true);}



        $rawStockFile=$symbolsDir . "/" . $currentTime . ".json";

        $fp=fopen($rawStockFile, "x+");

        fwrite($fp, $allStocksJson);

        fclose($fp);

        echo "YAAAY! stock large json file updated successfully! 💚 n";

    }





}



?>

Example of symobls.md:

A   2019-01-04  AGILENT TECHNOLOGIES INC

AA  2019-01-04  ALCOA CORP

AAAU    2019-01-04  PERTH MINT PHYSICAL GOLD ETF

AABA    2019-01-04  ALTABA INC

AAC 2019-01-04  AAC HOLDINGS INC

AADR    2019-01-04  ADVISORSHARES DORSEY WRIGHT

AAL 2019-01-04  AMERICAN AIRLINES GROUP INC

AAMC    2019-01-04  ALTISOURCE ASSET MANAGEMENT

AAME    2019-01-04  ATLANTIC AMERICAN CORP

AAN 2019-01-04  AARON'S INC

AAOI    2019-01-04  APPLIED OPTOELECTRONICS INC

AAON    2019-01-04  AAON INC

AAP 2019-01-04  ADVANCE AUTO PARTS INC

AAPL    2019-01-04  APPLE INC

AAT 2019-01-04  AMERICAN ASSETS TRUST INC

AAU 2019-01-04  ALMADEN MINERALS LTD - B

AAWW    2019-01-04  ATLAS AIR WORLDWIDE HOLDINGS

AAXJ    2019-01-04  ISHARES MSCI ALL COUNTRY ASI

AAXN    2019-01-04  AXON ENTERPRISE INC

AB  2019-01-04  ALLIANCEBERNSTEIN HOLDING LP

ABAC    2019-01-04  RENMIN TIANLI GROUP INC

ABB 2019-01-04  ABB LTD-SPON ADR

ABBV    2019-01-04  ABBVIE INC

ABC 2019-01-04  AMERISOURCEBERGEN CORP

ABCB    2019-01-04  AMERIS BANCORP

ABDC    2019-01-04  ALCENTRA CAPITAL CORP

ABEO    2019-01-04  ABEONA THERAPEUTICS INC

ABEOW   2019-01-04  

ABEV    2019-01-04  AMBEV SA-ADR

ABG 2019-01-04  ASBURY AUTOMOTIVE GROUP

ABIL    2019-01-04  ABILITY INC

ABIO    2019-01-04  ARCA BIOPHARMA INC

ABM 2019-01-04  ABM INDUSTRIES INC

ABMD    2019-01-04  ABIOMED INC

ABR 2019-01-04  ARBOR REALTY TRUST INC

ABR-A   2019-01-04  

ABR-B   2019-01-04  

ABR-C   2019-01-04  

ABT 2019-01-04  ABBOTT LABORATORIES

ABTX    2019-01-04  ALLEGIANCE BANCSHARES INC

ABUS    2019-01-04  ARBUTUS BIOPHARMA CORP

AC  2019-01-04  ASSOCIATED CAPITAL GROUP - A

ACA 2019-01-04  ARCOSA INC

ACAD    2019-01-04  ACADIA PHARMACEUTICALS INC

ACB 2019-01-04  AURORA CANNABIS INC

ACBI    2019-01-04  ATLANTIC CAPITAL BANCSHARES

ACC 2019-01-04  AMERICAN CAMPUS COMMUNITIES