Disallow `rm` to remove `*`












1












$begingroup$


Note: If you googled this by the title of this question, don't use this script unless you know what it is supposed to do.



This is a script in bash 3+ that I have used for long for preventing rm * and rm -rf * from accidentally invoked and removing important files by mistake. I put it in my ~/.bash_aliases.



alias rm='set -f;rm'
rm(){
if [[ "$-" == *i* ]]
then
if [ "$1" = "*" ] || [ "$2" = "*" ] || [ "$1" = "./*" ] || [ "$2" = "./*" ]
then
echo "Abort: refusing to remove *, please go to the parent folder and do rm <folder_name>/*" 1>&2
set +f
return 1
fi
fi
set +f
/bin/rm -i $@
}

set +f


I would like to know whether there are any vulnerabilities and whether it can be improved.










share|improve this question











$endgroup$

















    1












    $begingroup$


    Note: If you googled this by the title of this question, don't use this script unless you know what it is supposed to do.



    This is a script in bash 3+ that I have used for long for preventing rm * and rm -rf * from accidentally invoked and removing important files by mistake. I put it in my ~/.bash_aliases.



    alias rm='set -f;rm'
    rm(){
    if [[ "$-" == *i* ]]
    then
    if [ "$1" = "*" ] || [ "$2" = "*" ] || [ "$1" = "./*" ] || [ "$2" = "./*" ]
    then
    echo "Abort: refusing to remove *, please go to the parent folder and do rm <folder_name>/*" 1>&2
    set +f
    return 1
    fi
    fi
    set +f
    /bin/rm -i $@
    }

    set +f


    I would like to know whether there are any vulnerabilities and whether it can be improved.










    share|improve this question











    $endgroup$















      1












      1








      1





      $begingroup$


      Note: If you googled this by the title of this question, don't use this script unless you know what it is supposed to do.



      This is a script in bash 3+ that I have used for long for preventing rm * and rm -rf * from accidentally invoked and removing important files by mistake. I put it in my ~/.bash_aliases.



      alias rm='set -f;rm'
      rm(){
      if [[ "$-" == *i* ]]
      then
      if [ "$1" = "*" ] || [ "$2" = "*" ] || [ "$1" = "./*" ] || [ "$2" = "./*" ]
      then
      echo "Abort: refusing to remove *, please go to the parent folder and do rm <folder_name>/*" 1>&2
      set +f
      return 1
      fi
      fi
      set +f
      /bin/rm -i $@
      }

      set +f


      I would like to know whether there are any vulnerabilities and whether it can be improved.










      share|improve this question











      $endgroup$




      Note: If you googled this by the title of this question, don't use this script unless you know what it is supposed to do.



      This is a script in bash 3+ that I have used for long for preventing rm * and rm -rf * from accidentally invoked and removing important files by mistake. I put it in my ~/.bash_aliases.



      alias rm='set -f;rm'
      rm(){
      if [[ "$-" == *i* ]]
      then
      if [ "$1" = "*" ] || [ "$2" = "*" ] || [ "$1" = "./*" ] || [ "$2" = "./*" ]
      then
      echo "Abort: refusing to remove *, please go to the parent folder and do rm <folder_name>/*" 1>&2
      set +f
      return 1
      fi
      fi
      set +f
      /bin/rm -i $@
      }

      set +f


      I would like to know whether there are any vulnerabilities and whether it can be improved.







      bash






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 2 mins ago







      Weijun Zhou

















      asked 25 mins ago









      Weijun ZhouWeijun Zhou

      1335




      1335






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215069%2fdisallow-rm-to-remove%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215069%2fdisallow-rm-to-remove%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀