Leetcode Longest Common Prefix












0












$begingroup$


I just recently finished the following problem on Leetcode problem. I know it's not the cleanest or fastest solution. I would appreciate if I can get some feedback on how to optimize the code.



The idea is too add all possible prefixes into an array and return the longest possible prefix. I believe this is probably why the algorithm doesn't run as fast as it should.



Also, I would appreciate if someone can assist in determining what the space and time complexity would be for the algorithm below?



var longestCommonPrefix = function(strs) {

const firstWord = strs[0];

const arrResults = ;

let index = 1;

let arrWithoutFirstElement = strs.slice(1, strs.length);

if(strs.length===0)return '';

if(strs.length===1)return strs[0];



while(index <= firstWord.length) {

   if(arrWithoutFirstElement.every(element =>

       element.substring(0,index)===firstWord.substring(0,index))){

       arrResults.push(firstWord.substring(0,index));

   }

   index++;

}



return arrResults.length > 0  ? arrResults[arrResults.length-1] : '';

}



console.log(longestCommonPrefix(["flower","flow","flight"]));





javascript algorithm







share|improve this question









$endgroup$

















    0












    $begingroup$


    I just recently finished the following problem on Leetcode problem. I know it's not the cleanest or fastest solution. I would appreciate if I can get some feedback on how to optimize the code.



    The idea is too add all possible prefixes into an array and return the longest possible prefix. I believe this is probably why the algorithm doesn't run as fast as it should.



    Also, I would appreciate if someone can assist in determining what the space and time complexity would be for the algorithm below?



    var longestCommonPrefix = function(strs) {
    
const firstWord = strs[0];
    
const arrResults = ;
    
let index = 1;
    
let arrWithoutFirstElement = strs.slice(1, strs.length);
    
if(strs.length===0)return '';
    
if(strs.length===1)return strs[0];
    

    
while(index <= firstWord.length) {
    
   if(arrWithoutFirstElement.every(element =>
    
       element.substring(0,index)===firstWord.substring(0,index))){
    
       arrResults.push(firstWord.substring(0,index));
    
   }
    
   index++;
    
}
    

    
return arrResults.length > 0  ? arrResults[arrResults.length-1] : '';
    
}
    

    
console.log(longestCommonPrefix(["flower","flow","flight"]));





    javascript algorithm







    share|improve this question









    $endgroup$















      0












      0








      0





      $begingroup$


      I just recently finished the following problem on Leetcode problem. I know it's not the cleanest or fastest solution. I would appreciate if I can get some feedback on how to optimize the code.



      The idea is too add all possible prefixes into an array and return the longest possible prefix. I believe this is probably why the algorithm doesn't run as fast as it should.



      Also, I would appreciate if someone can assist in determining what the space and time complexity would be for the algorithm below?



      var longestCommonPrefix = function(strs) {
      
const firstWord = strs[0];
      
const arrResults = ;
      
let index = 1;
      
let arrWithoutFirstElement = strs.slice(1, strs.length);
      
if(strs.length===0)return '';
      
if(strs.length===1)return strs[0];
      

      
while(index <= firstWord.length) {
      
   if(arrWithoutFirstElement.every(element =>
      
       element.substring(0,index)===firstWord.substring(0,index))){
      
       arrResults.push(firstWord.substring(0,index));
      
   }
      
   index++;
      
}
      

      
return arrResults.length > 0  ? arrResults[arrResults.length-1] : '';
      
}
      

      
console.log(longestCommonPrefix(["flower","flow","flight"]));





      javascript algorithm







      share|improve this question









      $endgroup$




      I just recently finished the following problem on Leetcode problem. I know it's not the cleanest or fastest solution. I would appreciate if I can get some feedback on how to optimize the code.



      The idea is too add all possible prefixes into an array and return the longest possible prefix. I believe this is probably why the algorithm doesn't run as fast as it should.



      Also, I would appreciate if someone can assist in determining what the space and time complexity would be for the algorithm below?



      var longestCommonPrefix = function(strs) {
      
const firstWord = strs[0];
      
const arrResults = ;
      
let index = 1;
      
let arrWithoutFirstElement = strs.slice(1, strs.length);
      
if(strs.length===0)return '';
      
if(strs.length===1)return strs[0];
      

      
while(index <= firstWord.length) {
      
   if(arrWithoutFirstElement.every(element =>
      
       element.substring(0,index)===firstWord.substring(0,index))){
      
       arrResults.push(firstWord.substring(0,index));
      
   }
      
   index++;
      
}
      

      
return arrResults.length > 0  ? arrResults[arrResults.length-1] : '';
      
}
      

      
console.log(longestCommonPrefix(["flower","flow","flight"]));





      javascript algorithm




      javascript algorithm






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 7 hours ago









      Rez88Rez88

      413




      413






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212029%2fleetcode-longest-common-prefix%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid …



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212029%2fleetcode-longest-common-prefix%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          -

          Popular posts from this blog

          How to reconfigure Docker Trusted Registry 2.x.x to use CEPH FS mount instead of NFS and other traditional...

          Image
          0 I am having trouble trying to reconfigure my DTR container to try and use a CEPH FS mount we created to act as a storage backend for our image repository. The Docs are very vague on this and nothing exactly explains on how to do it. Has anyone yet connected the dots? linux filesystems mount storage docker share | improve this question asked Feb 1 at 6:40 jRapp3r jRapp3r 1 1 add a comment  | 
          Read more

          is 'sed' thread safe

          Image
          2 If I have a shell/python script that uses sed to modify a file in place based on user inputs, and then two users run the same script at the same time or approx. same time, is 'sed' thread safe ? Or perhaps it is not an issue because the file_descripor that was opened by the first thread will be used to lock the file anyway ? thx linux sed python share | improve this question edited 7 hours ago Jeff Schaller 42.9k 11 59 137 asked 7 hours ago terreys terreys
          Read more

          How to make a Squid Proxy server?

          Image
          1 I want to set up squid proxy server for monitoring user activity in a network and Internet Web URL filtering for user. I also want to configure the user login, user log, user access group, and block unwanted web sites in my network. Please help me and guide me the full process to do this. server proxy squid share | improve this question edited Jul 31 '12 at 14:45 Jorge Castro 37.1k 107 422 617 asked Jul 31 '12 at 5:16 Goivind Tiwari Goivind Tiwari
          Read more