Very slow. How to move the threads creation to main_?












0












$begingroup$


Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.



double funcPar()
{
double sum = { 0, 0, 0, 0 };
#pragma omp parallel
{
#pragma omp for
for (int i = 0; i < 4; i++) //loop body should be parallel (multy-threaded)
{
auto a = (double)i;
sum[i] += sin(a)*cos(a); // real code is more complicated and works much longer
}
}//omp parallel
return sum[0] + sum[1] + sum[2] + sum[3];
}
double funcSerial() //function should remain serial (single-threaded)
{
int K = 5000;
double sum = 0.0;
for (int k = 0; k < K; k++)
{
sum += funcPar();
}
return sum;
}
void main_() // //function body should remain serial (single-threaded)
{
int J = 1000;
double sum = 0.0;
for (int j = 0; j < J; j++)
{
sum += funcSerial();
}
printf("nn sum = %f n", sum);
}


Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.










share|improve this question







New contributor




Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.



    double funcPar()
    {
    double sum = { 0, 0, 0, 0 };
    #pragma omp parallel
    {
    #pragma omp for
    for (int i = 0; i < 4; i++) //loop body should be parallel (multy-threaded)
    {
    auto a = (double)i;
    sum[i] += sin(a)*cos(a); // real code is more complicated and works much longer
    }
    }//omp parallel
    return sum[0] + sum[1] + sum[2] + sum[3];
    }
    double funcSerial() //function should remain serial (single-threaded)
    {
    int K = 5000;
    double sum = 0.0;
    for (int k = 0; k < K; k++)
    {
    sum += funcPar();
    }
    return sum;
    }
    void main_() // //function body should remain serial (single-threaded)
    {
    int J = 1000;
    double sum = 0.0;
    for (int j = 0; j < J; j++)
    {
    sum += funcSerial();
    }
    printf("nn sum = %f n", sum);
    }


    Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.










    share|improve this question







    New contributor




    Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.



      double funcPar()
      {
      double sum = { 0, 0, 0, 0 };
      #pragma omp parallel
      {
      #pragma omp for
      for (int i = 0; i < 4; i++) //loop body should be parallel (multy-threaded)
      {
      auto a = (double)i;
      sum[i] += sin(a)*cos(a); // real code is more complicated and works much longer
      }
      }//omp parallel
      return sum[0] + sum[1] + sum[2] + sum[3];
      }
      double funcSerial() //function should remain serial (single-threaded)
      {
      int K = 5000;
      double sum = 0.0;
      for (int k = 0; k < K; k++)
      {
      sum += funcPar();
      }
      return sum;
      }
      void main_() // //function body should remain serial (single-threaded)
      {
      int J = 1000;
      double sum = 0.0;
      for (int j = 0; j < J; j++)
      {
      sum += funcSerial();
      }
      printf("nn sum = %f n", sum);
      }


      Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.










      share|improve this question







      New contributor




      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.



      double funcPar()
      {
      double sum = { 0, 0, 0, 0 };
      #pragma omp parallel
      {
      #pragma omp for
      for (int i = 0; i < 4; i++) //loop body should be parallel (multy-threaded)
      {
      auto a = (double)i;
      sum[i] += sin(a)*cos(a); // real code is more complicated and works much longer
      }
      }//omp parallel
      return sum[0] + sum[1] + sum[2] + sum[3];
      }
      double funcSerial() //function should remain serial (single-threaded)
      {
      int K = 5000;
      double sum = 0.0;
      for (int k = 0; k < K; k++)
      {
      sum += funcPar();
      }
      return sum;
      }
      void main_() // //function body should remain serial (single-threaded)
      {
      int J = 1000;
      double sum = 0.0;
      for (int j = 0; j < J; j++)
      {
      sum += funcSerial();
      }
      printf("nn sum = %f n", sum);
      }


      Fully workable code. Very slow. How to move the threads creation to main_ ? Do not break the structure of the code.







      c++ openmp






      share|improve this question







      New contributor




      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 36 mins ago









      Джон ДоуДжон Доу

      1




      1




      New contributor




      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Джон Доу is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Джон Доу is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212245%2fvery-slow-how-to-move-the-threads-creation-to-main%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Джон Доу is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Джон Доу is a new contributor. Be nice, and check out our Code of Conduct.













          Джон Доу is a new contributor. Be nice, and check out our Code of Conduct.












          Джон Доу is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212245%2fvery-slow-how-to-move-the-threads-creation-to-main%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to reconfigure Docker Trusted Registry 2.x.x to use CEPH FS mount instead of NFS and other traditional...

          is 'sed' thread safe

          How to make a Squid Proxy server?