C++: Local map variable doesn't work but global one works












0












$begingroup$


#include <unordered_map>

class Solution {
public:
// std::unordered_map<int, int> m; <<---- this one works
int size;

/**
* @param s: a string, encoded message
* @return: an integer, the number of ways decoding
*/
int numDecodings(string &s) {
// write your code here
size = s.length();
if(!size) return 0;

std::unordered_map<int, int> m; <<---- this doesn't work
decode(s, 0, m);
}

/**
* Time : O(n), Space: O(1)
*/
int decode(string &s, int i, std::unordered_map<int, int>& m) {
if (m.count(i)) { return m[i]; }
if (s[i] == '0') return 0;
if (size == 1) return 1;
if (i >= size - 1) return 1;

int ways = decode(s, i + 1, m);
int prefix = (s[i] - '0') * 10 + (s[i + 1] - '0');
if (prefix <= 26) {
ways += decode(s, i + 2, m);
}

m[i] = ways;
return ways;
}
};


I am trying to do an exercise in LintCode but my code doesn't work if I use a local map variable but works fine by a global map.



Can anyone help to see what is going wrong here? thanks !










share|improve this question









$endgroup$

















    0












    $begingroup$


    #include <unordered_map>

    class Solution {
    public:
    // std::unordered_map<int, int> m; <<---- this one works
    int size;

    /**
    * @param s: a string, encoded message
    * @return: an integer, the number of ways decoding
    */
    int numDecodings(string &s) {
    // write your code here
    size = s.length();
    if(!size) return 0;

    std::unordered_map<int, int> m; <<---- this doesn't work
    decode(s, 0, m);
    }

    /**
    * Time : O(n), Space: O(1)
    */
    int decode(string &s, int i, std::unordered_map<int, int>& m) {
    if (m.count(i)) { return m[i]; }
    if (s[i] == '0') return 0;
    if (size == 1) return 1;
    if (i >= size - 1) return 1;

    int ways = decode(s, i + 1, m);
    int prefix = (s[i] - '0') * 10 + (s[i + 1] - '0');
    if (prefix <= 26) {
    ways += decode(s, i + 2, m);
    }

    m[i] = ways;
    return ways;
    }
    };


    I am trying to do an exercise in LintCode but my code doesn't work if I use a local map variable but works fine by a global map.



    Can anyone help to see what is going wrong here? thanks !










    share|improve this question









    $endgroup$















      0












      0








      0





      $begingroup$


      #include <unordered_map>

      class Solution {
      public:
      // std::unordered_map<int, int> m; <<---- this one works
      int size;

      /**
      * @param s: a string, encoded message
      * @return: an integer, the number of ways decoding
      */
      int numDecodings(string &s) {
      // write your code here
      size = s.length();
      if(!size) return 0;

      std::unordered_map<int, int> m; <<---- this doesn't work
      decode(s, 0, m);
      }

      /**
      * Time : O(n), Space: O(1)
      */
      int decode(string &s, int i, std::unordered_map<int, int>& m) {
      if (m.count(i)) { return m[i]; }
      if (s[i] == '0') return 0;
      if (size == 1) return 1;
      if (i >= size - 1) return 1;

      int ways = decode(s, i + 1, m);
      int prefix = (s[i] - '0') * 10 + (s[i + 1] - '0');
      if (prefix <= 26) {
      ways += decode(s, i + 2, m);
      }

      m[i] = ways;
      return ways;
      }
      };


      I am trying to do an exercise in LintCode but my code doesn't work if I use a local map variable but works fine by a global map.



      Can anyone help to see what is going wrong here? thanks !










      share|improve this question









      $endgroup$




      #include <unordered_map>

      class Solution {
      public:
      // std::unordered_map<int, int> m; <<---- this one works
      int size;

      /**
      * @param s: a string, encoded message
      * @return: an integer, the number of ways decoding
      */
      int numDecodings(string &s) {
      // write your code here
      size = s.length();
      if(!size) return 0;

      std::unordered_map<int, int> m; <<---- this doesn't work
      decode(s, 0, m);
      }

      /**
      * Time : O(n), Space: O(1)
      */
      int decode(string &s, int i, std::unordered_map<int, int>& m) {
      if (m.count(i)) { return m[i]; }
      if (s[i] == '0') return 0;
      if (size == 1) return 1;
      if (i >= size - 1) return 1;

      int ways = decode(s, i + 1, m);
      int prefix = (s[i] - '0') * 10 + (s[i + 1] - '0');
      if (prefix <= 26) {
      ways += decode(s, i + 2, m);
      }

      m[i] = ways;
      return ways;
      }
      };


      I am trying to do an exercise in LintCode but my code doesn't work if I use a local map variable but works fine by a global map.



      Can anyone help to see what is going wrong here? thanks !







      c++






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 14 mins ago









      MrROYMrROY

      136114




      136114






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214150%2fc-local-map-variable-doesnt-work-but-global-one-works%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214150%2fc-local-map-variable-doesnt-work-but-global-one-works%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to reconfigure Docker Trusted Registry 2.x.x to use CEPH FS mount instead of NFS and other traditional...

          is 'sed' thread safe

          How to make a Squid Proxy server?