made a protocol network layer, don't know how to make decoding generic enough
$begingroup$
So I'm a junior developer, the only IOS developer at my work, and we have this upcoming project, witch from the few things we already know about it is that it going have to talk to many Api's.
So I started building a generic network layer myself witch need to work with all of them, protocol based and no dependencies.
It works, it's a mess ( made it from different sources and ideas ) but one part is missing.
I added the project to GitHub here
Currently the project have 2 screens embedded in a tab bar, each making a request call in viewDidLoad and parse the response, its need more touch with error handling but the structure in general is done.
As you can see I have a protocol EndPointType
protocol EndPointType {
var baseURL: URL { get }
var path: String { get }
var httpMethod: HTTPMethod { get }
var task: HTTPTask { get }
var headers: HTTPHeaders? { get }
var sessionOptions: sessionOptions { get }
}
witch every api enum confirms to it and with switch statement it holds all of the variations that can happen. the only thing that missing is the same thing that says witch model to use. I thought about making an enum that will point to all the models but it will need to hold all the models for all the api's witch I think will be wrong. Any suggestions ?
will also be happy to get any criticism on the project itself, as I mentioned, I have no way to know if I did something wrong ( and I feel like I did )
Thanks for your time !
swift ios
asked 10 hours ago
alexalex
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
So I'm a junior developer, the only IOS developer at my work, and we have this upcoming project, witch from the few things we already know about it is that it going have to talk to many Api's.
So I started building a generic network layer myself witch need to work with all of them, protocol based and no dependencies.
It works, it's a mess ( made it from different sources and ideas ) but one part is missing.
I added the project to GitHub here
Currently the project have 2 screens embedded in a tab bar, each making a request call in viewDidLoad and parse the response, its need more touch with error handling but the structure in general is done.
As you can see I have a protocol EndPointType
protocol EndPointType {
var baseURL: URL { get }
var path: String { get }
var httpMethod: HTTPMethod { get }
var task: HTTPTask { get }
var headers: HTTPHeaders? { get }
var sessionOptions: sessionOptions { get }
}
witch every api enum confirms to it and with switch statement it holds all of the variations that can happen. the only thing that missing is the same thing that says witch model to use. I thought about making an enum that will point to all the models but it will need to hold all the models for all the api's witch I think will be wrong. Any suggestions ?
will also be happy to get any criticism on the project itself, as I mentioned, I have no way to know if I did something wrong ( and I feel like I did )
Thanks for your time !
swift ios
asked 10 hours ago
alexalex
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
So I'm a junior developer, the only IOS developer at my work, and we have this upcoming project, witch from the few things we already know about it is that it going have to talk to many Api's.
So I started building a generic network layer myself witch need to work with all of them, protocol based and no dependencies.
It works, it's a mess ( made it from different sources and ideas ) but one part is missing.
I added the project to GitHub here
Currently the project have 2 screens embedded in a tab bar, each making a request call in viewDidLoad and parse the response, its need more touch with error handling but the structure in general is done.
As you can see I have a protocol EndPointType
protocol EndPointType {
var baseURL: URL { get }
var path: String { get }
var httpMethod: HTTPMethod { get }
var task: HTTPTask { get }
var headers: HTTPHeaders? { get }
var sessionOptions: sessionOptions { get }
}
witch every api enum confirms to it and with switch statement it holds all of the variations that can happen. the only thing that missing is the same thing that says witch model to use. I thought about making an enum that will point to all the models but it will need to hold all the models for all the api's witch I think will be wrong. Any suggestions ?
will also be happy to get any criticism on the project itself, as I mentioned, I have no way to know if I did something wrong ( and I feel like I did )
Thanks for your time !
swift ios
asked 10 hours ago
alexalex
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
So I'm a junior developer, the only IOS developer at my work, and we have this upcoming project, witch from the few things we already know about it is that it going have to talk to many Api's.
So I started building a generic network layer myself witch need to work with all of them, protocol based and no dependencies.
It works, it's a mess ( made it from different sources and ideas ) but one part is missing.
I added the project to GitHub here
Currently the project have 2 screens embedded in a tab bar, each making a request call in viewDidLoad and parse the response, its need more touch with error handling but the structure in general is done.
As you can see I have a protocol EndPointType
protocol EndPointType {
var baseURL: URL { get }
var path: String { get }
var httpMethod: HTTPMethod { get }
var task: HTTPTask { get }
var headers: HTTPHeaders? { get }
var sessionOptions: sessionOptions { get }
}
witch every api enum confirms to it and with switch statement it holds all of the variations that can happen. the only thing that missing is the same thing that says witch model to use. I thought about making an enum that will point to all the models but it will need to hold all the models for all the api's witch I think will be wrong. Any suggestions ?
will also be happy to get any criticism on the project itself, as I mentioned, I have no way to know if I did something wrong ( and I feel like I did )
Thanks for your time !
swift ios
swift ios
asked 10 hours ago
alexalex
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 hours ago
alexalex
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 hours ago
alexalex
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 10 hours ago
alexalex
1
asked 10 hours ago
alexalex
1
1
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
alex is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
alex is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216291%2fmade-a-protocol-network-layer-dont-know-how-to-make-decoding-generic-enough%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
alex is a new contributor. Be nice, and check out our Code of Conduct.
alex is a new contributor. Be nice, and check out our Code of Conduct.
alex is a new contributor. Be nice, and check out our Code of Conduct.
alex is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216291%2fmade-a-protocol-network-layer-dont-know-how-to-make-decoding-generic-enough%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
