Is this any good? Complete noob
0
$begingroup$
Hello I apologize for not really knowing how to use this site, however, I was wondering if anyone had anything to recommend for how to clean up the code I made below... essentially I am asking if my code is messy or not and if there are any recommendations for my improvement.
# Most basic fantasy combat simulator
import random
p_health = 5
g_health = 5
goblin_alive = True
def status():
if g_health == 5:
return "nA menacing goblin stands before you..."
elif g_health >= 3:
return "nThe goblin is looking a little tired, and is bleeding..."
elif g_health >= 1:
return "nThe goblin is bleeding horribly and looks enraged..."
while goblin_alive:
if g_health <= 0:
goblin_alive = False
print("nCongrats you slayed the goblin!")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
if p_health <= 0:
print("Oh dear you have died horribly and the goblin cuts your head off for a trophy...")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
p_health = 5
g_heath = 5
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
desc = status()
print(desc)
print("You have " + str(p_health) + ' hit points.')
attack = input("Press enter to attack: ")
if attack == '':
print("nYou swing your sword fiercely at the goblin!")
hit_type = random.randint(1, 2)
if hit_type == 1:
damage = random.randint(1, 3)
print("You deal a fierce blow for " + str(damage) + " damage to the goblin.")
g_health = g_health - damage
elif hit_type == 2:
damage = random.randint(1, 3)
print("The goblin slashes you for " + str(damage) + " damage, uh oh...")
p_health = p_health - damage
else:
print("nYou better do something...")
python game
asked 8 mins ago
wildslothinwildslothin
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
Hello I apologize for not really knowing how to use this site, however, I was wondering if anyone had anything to recommend for how to clean up the code I made below... essentially I am asking if my code is messy or not and if there are any recommendations for my improvement.
# Most basic fantasy combat simulator
import random
p_health = 5
g_health = 5
goblin_alive = True
def status():
if g_health == 5:
return "nA menacing goblin stands before you..."
elif g_health >= 3:
return "nThe goblin is looking a little tired, and is bleeding..."
elif g_health >= 1:
return "nThe goblin is bleeding horribly and looks enraged..."
while goblin_alive:
if g_health <= 0:
goblin_alive = False
print("nCongrats you slayed the goblin!")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
if p_health <= 0:
print("Oh dear you have died horribly and the goblin cuts your head off for a trophy...")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
p_health = 5
g_heath = 5
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
desc = status()
print(desc)
print("You have " + str(p_health) + ' hit points.')
attack = input("Press enter to attack: ")
if attack == '':
print("nYou swing your sword fiercely at the goblin!")
hit_type = random.randint(1, 2)
if hit_type == 1:
damage = random.randint(1, 3)
print("You deal a fierce blow for " + str(damage) + " damage to the goblin.")
g_health = g_health - damage
elif hit_type == 2:
damage = random.randint(1, 3)
print("The goblin slashes you for " + str(damage) + " damage, uh oh...")
p_health = p_health - damage
else:
print("nYou better do something...")
python game
asked 8 mins ago
wildslothinwildslothin
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
Hello I apologize for not really knowing how to use this site, however, I was wondering if anyone had anything to recommend for how to clean up the code I made below... essentially I am asking if my code is messy or not and if there are any recommendations for my improvement.
# Most basic fantasy combat simulator
import random
p_health = 5
g_health = 5
goblin_alive = True
def status():
if g_health == 5:
return "nA menacing goblin stands before you..."
elif g_health >= 3:
return "nThe goblin is looking a little tired, and is bleeding..."
elif g_health >= 1:
return "nThe goblin is bleeding horribly and looks enraged..."
while goblin_alive:
if g_health <= 0:
goblin_alive = False
print("nCongrats you slayed the goblin!")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
if p_health <= 0:
print("Oh dear you have died horribly and the goblin cuts your head off for a trophy...")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
p_health = 5
g_heath = 5
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
desc = status()
print(desc)
print("You have " + str(p_health) + ' hit points.')
attack = input("Press enter to attack: ")
if attack == '':
print("nYou swing your sword fiercely at the goblin!")
hit_type = random.randint(1, 2)
if hit_type == 1:
damage = random.randint(1, 3)
print("You deal a fierce blow for " + str(damage) + " damage to the goblin.")
g_health = g_health - damage
elif hit_type == 2:
damage = random.randint(1, 3)
print("The goblin slashes you for " + str(damage) + " damage, uh oh...")
p_health = p_health - damage
else:
print("nYou better do something...")
python game
asked 8 mins ago
wildslothinwildslothin
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Hello I apologize for not really knowing how to use this site, however, I was wondering if anyone had anything to recommend for how to clean up the code I made below... essentially I am asking if my code is messy or not and if there are any recommendations for my improvement.
# Most basic fantasy combat simulator
import random
p_health = 5
g_health = 5
goblin_alive = True
def status():
if g_health == 5:
return "nA menacing goblin stands before you..."
elif g_health >= 3:
return "nThe goblin is looking a little tired, and is bleeding..."
elif g_health >= 1:
return "nThe goblin is bleeding horribly and looks enraged..."
while goblin_alive:
if g_health <= 0:
goblin_alive = False
print("nCongrats you slayed the goblin!")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
if p_health <= 0:
print("Oh dear you have died horribly and the goblin cuts your head off for a trophy...")
again = input("Play again? Y/N: ")
if again == 'y' or again == 'Y':
p_health = 5
g_heath = 5
goblin_alive = True
elif again == 'N' or again == 'n':
print("nGoodbye")
exit()
desc = status()
print(desc)
print("You have " + str(p_health) + ' hit points.')
attack = input("Press enter to attack: ")
if attack == '':
print("nYou swing your sword fiercely at the goblin!")
hit_type = random.randint(1, 2)
if hit_type == 1:
damage = random.randint(1, 3)
print("You deal a fierce blow for " + str(damage) + " damage to the goblin.")
g_health = g_health - damage
elif hit_type == 2:
damage = random.randint(1, 3)
print("The goblin slashes you for " + str(damage) + " damage, uh oh...")
p_health = p_health - damage
else:
print("nYou better do something...")
python game
python game
asked 8 mins ago
wildslothinwildslothin
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 8 mins ago
wildslothinwildslothin
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 8 mins ago
wildslothinwildslothin
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 8 mins ago
wildslothinwildslothin
1
asked 8 mins ago
wildslothinwildslothin
1
1
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
wildslothin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
wildslothin is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213168%2fis-this-any-good-complete-noob%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
wildslothin is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
wildslothin is a new contributor. Be nice, and check out our Code of Conduct.
wildslothin is a new contributor. Be nice, and check out our Code of Conduct.
wildslothin is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213168%2fis-this-any-good-complete-noob%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
