C++ Vignere Cipher
0
$begingroup$
I'd appreciate any constructive criticism. On a side note, I can't get the ascii characters to not mix up with symbols from 91-96.
#include <iostream>
#include <string>
using namespace std;
int keygen(char a)
{
if (a > 'Z')
a = a - 32;
int key = a - 65;
return key;
}
int main()
{
int n;
n = 0;
int cn = 0;
string cipher;
string s;
int cipher2[100];
int y = cn;
cout << "Type a string and a cipher: " << endl;
getline(cin, s);
getline(cin, cipher);
n = s.size();
cn = cipher.size();
for (int i = 0; i < cn; i++)
{
cipher[i] = keygen(cipher[i]);
}
for (int i = 0; i < n; i++)
{
if (s[i] == 32)
{
cipher2[i] = 0;
}
else
{
cipher2[i] = cipher[y%cn];
y++;
if (y%cn>cn)
y = cn;
}
}
for (int i = 0; i < n; i++)
{
if ((int)s[i] >= 'A' && (int)s[i] <= 'z'&& s[i] != 32)
s[i] = s[i] + cipher2[i];
if (s[i] > 'z' || s[i] < 'A'&& s[i] != 32)
{
s[i] = s[i] - cipher2[i];
s[i] = s[i] - (26 - cipher2[i]);
}
}
cout << s;
return 0;
}
c++ beginner
asked 1 hour ago
inVektus7inVektus7
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
$begingroup$
I'd appreciate any constructive criticism. On a side note, I can't get the ascii characters to not mix up with symbols from 91-96.
#include <iostream>
#include <string>
using namespace std;
int keygen(char a)
{
if (a > 'Z')
a = a - 32;
int key = a - 65;
return key;
}
int main()
{
int n;
n = 0;
int cn = 0;
string cipher;
string s;
int cipher2[100];
int y = cn;
cout << "Type a string and a cipher: " << endl;
getline(cin, s);
getline(cin, cipher);
n = s.size();
cn = cipher.size();
for (int i = 0; i < cn; i++)
{
cipher[i] = keygen(cipher[i]);
}
for (int i = 0; i < n; i++)
{
if (s[i] == 32)
{
cipher2[i] = 0;
}
else
{
cipher2[i] = cipher[y%cn];
y++;
if (y%cn>cn)
y = cn;
}
}
for (int i = 0; i < n; i++)
{
if ((int)s[i] >= 'A' && (int)s[i] <= 'z'&& s[i] != 32)
s[i] = s[i] + cipher2[i];
if (s[i] > 'z' || s[i] < 'A'&& s[i] != 32)
{
s[i] = s[i] - cipher2[i];
s[i] = s[i] - (26 - cipher2[i]);
}
}
cout << s;
return 0;
}
c++ beginner
asked 1 hour ago
inVektus7inVektus7
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
0
0
0
$begingroup$
I'd appreciate any constructive criticism. On a side note, I can't get the ascii characters to not mix up with symbols from 91-96.
#include <iostream>
#include <string>
using namespace std;
int keygen(char a)
{
if (a > 'Z')
a = a - 32;
int key = a - 65;
return key;
}
int main()
{
int n;
n = 0;
int cn = 0;
string cipher;
string s;
int cipher2[100];
int y = cn;
cout << "Type a string and a cipher: " << endl;
getline(cin, s);
getline(cin, cipher);
n = s.size();
cn = cipher.size();
for (int i = 0; i < cn; i++)
{
cipher[i] = keygen(cipher[i]);
}
for (int i = 0; i < n; i++)
{
if (s[i] == 32)
{
cipher2[i] = 0;
}
else
{
cipher2[i] = cipher[y%cn];
y++;
if (y%cn>cn)
y = cn;
}
}
for (int i = 0; i < n; i++)
{
if ((int)s[i] >= 'A' && (int)s[i] <= 'z'&& s[i] != 32)
s[i] = s[i] + cipher2[i];
if (s[i] > 'z' || s[i] < 'A'&& s[i] != 32)
{
s[i] = s[i] - cipher2[i];
s[i] = s[i] - (26 - cipher2[i]);
}
}
cout << s;
return 0;
}
c++ beginner
asked 1 hour ago
inVektus7inVektus7
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I'd appreciate any constructive criticism. On a side note, I can't get the ascii characters to not mix up with symbols from 91-96.
#include <iostream>
#include <string>
using namespace std;
int keygen(char a)
{
if (a > 'Z')
a = a - 32;
int key = a - 65;
return key;
}
int main()
{
int n;
n = 0;
int cn = 0;
string cipher;
string s;
int cipher2[100];
int y = cn;
cout << "Type a string and a cipher: " << endl;
getline(cin, s);
getline(cin, cipher);
n = s.size();
cn = cipher.size();
for (int i = 0; i < cn; i++)
{
cipher[i] = keygen(cipher[i]);
}
for (int i = 0; i < n; i++)
{
if (s[i] == 32)
{
cipher2[i] = 0;
}
else
{
cipher2[i] = cipher[y%cn];
y++;
if (y%cn>cn)
y = cn;
}
}
for (int i = 0; i < n; i++)
{
if ((int)s[i] >= 'A' && (int)s[i] <= 'z'&& s[i] != 32)
s[i] = s[i] + cipher2[i];
if (s[i] > 'z' || s[i] < 'A'&& s[i] != 32)
{
s[i] = s[i] - cipher2[i];
s[i] = s[i] - (26 - cipher2[i]);
}
}
cout << s;
return 0;
}
c++ beginner
c++ beginner
asked 1 hour ago
inVektus7inVektus7
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
inVektus7inVektus7
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
inVektus7inVektus7
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
inVektus7inVektus7
1
asked 1 hour ago
inVektus7inVektus7
1
1
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
inVektus7 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
inVektus7 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213778%2fc-vignere-cipher%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
inVektus7 is a new contributor. Be nice, and check out our Code of Conduct.
draft saved
draft discarded
inVektus7 is a new contributor. Be nice, and check out our Code of Conduct.
inVektus7 is a new contributor. Be nice, and check out our Code of Conduct.
inVektus7 is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213778%2fc-vignere-cipher%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
