Ytdyklly

I'm a beginner in programming and I would like to have feedback and tips to improve. He's a simple command line program. It's a Rock, Paper, Scissors game.

I guess I could use an enum for the "Attack", but I don't know how to use it with cout after that...

Thanks!

#include <iostream>

#include <string>

#include <cstdlib>

#include <ctime>



using namespace std;



enum class Result

{

    win = 1,

    loss = -1,

    tie = 0

};



string ResultToString(Result result)

{

    switch (result)

    {

    case Result::win:

        return "WIN!";

    case Result::loss:

        return "LOSS!";

    default:

        return "TIE!";

    }

}



string DeterminePlay(char playAbbreviation)

{

    if (playAbbreviation == 'r')

    {

        return "Rock";

    }

    else if (playAbbreviation == 'p')

    {

        return "Paper";

    }

    else

    {

        return "Scissors";

    }

}



Result DetermineResult(char playerPlay, char computerPlay)

{

    if (playerPlay == 'r' && computerPlay == 's')

    {

        return Result::win;

    }

    else if (playerPlay == 'p' && computerPlay == 'r')

    {

        return Result::win;

    }

    else if (playerPlay == 's' && computerPlay == 'p')

    {

        return Result::win;

    }

    else if (playerPlay == 's' && computerPlay == 'r')

    {

        return Result::loss;

    }

    else if (playerPlay == 'r' && computerPlay == 'p')

    {

        return Result::loss;

    }

    else if (playerPlay == 'p' && computerPlay == 's')

    {

        return Result::loss;

    }

    else

    {

        return Result::tie;

    }

}



int GenerateRandomNumber(int min, int max)

{

    srand((int)time(0));

    int number{(rand() % max) + min};

    return number;

}



char GenerateComputerPlay()

{

    char computerPlay{};

    int number{GenerateRandomNumber(1, 3)};

    switch (number)

    {

    case 1:

        computerPlay = 'r';

        break;

    case 2:

        computerPlay = 'p';

        break;

    default:

        computerPlay = 's';

    }

    return computerPlay;

}



int main()

{

    setlocale(LC_ALL, "");

    char play{'y'};

    while (play == 'y')

    {

        char computerPlay{};

        char playerPlay{};



        cout << "--- Rock, Paper, Scissors ---" << endl << endl;



        while (playerPlay != 'r' && playerPlay != 'p' && playerPlay != 's')

        {

            cout << "Enter a choice : (R)ock, (P)aper, (S)cissors : ";

            cin >> playerPlay;

            playerPlay = tolower(playerPlay);

        }



        cout << endl << "You played " << DeterminePlay(playerPlay) << endl;



        computerPlay = GenerateComputerPlay();

        cout << "The computer played " << DeterminePlay(computerPlay) << endl;



        Result result{DetermineResult(playerPlay, computerPlay)};

        cout << "It's a " << ResultToString(result) << endl << endl;



        cout << "Play again?" << endl << "(Y)es" << endl << "(N)o" << endl;

        cin >> play;

        play = tolower(play);

    }

    return 0;

}