Input string, output vowels and consonants to log, separately but in order
$begingroup$
I completed a short coding challenge and just want to know if I should use shorter methods of which I am unaware, or make it more readable.
/*
*
* Complete the vowelsAndConsonants function.
* Print your output using 'console.log()'.
*/
function vowelsAndConsonants(s) {
var strConsonants = "";
var strVowels = "";
var i;
for (i in s) {
if (s.charAt(i) == "a" || s.charAt(i) == "e" || s.charAt(i) == "i" ||
s.charAt(i) == "o" || s.charAt(i) == "u") {
strVowels += s.charAt(i);
}
else if (s.charAt(i) != "a" || s.charAt(i) != "e" || s.charAt(i) != "i"
|| s.charAt(i) != "o" || s.charAt(i) != "u") {
strConsonants += s.charAt(i);
}
}
// console.log(strVowels);
i = 0;
for (i in strVowels) {
console.log(strVowels.charAt(i));
}
// console.log(strConsonants);
i = 0;
for (i in strConsonants) {
console.log(strConsonants.charAt(i));
}
}
javascript beginner programming-challenge
New contributor
$endgroup$
add a comment |
$begingroup$
I completed a short coding challenge and just want to know if I should use shorter methods of which I am unaware, or make it more readable.
/*
*
* Complete the vowelsAndConsonants function.
* Print your output using 'console.log()'.
*/
function vowelsAndConsonants(s) {
var strConsonants = "";
var strVowels = "";
var i;
for (i in s) {
if (s.charAt(i) == "a" || s.charAt(i) == "e" || s.charAt(i) == "i" ||
s.charAt(i) == "o" || s.charAt(i) == "u") {
strVowels += s.charAt(i);
}
else if (s.charAt(i) != "a" || s.charAt(i) != "e" || s.charAt(i) != "i"
|| s.charAt(i) != "o" || s.charAt(i) != "u") {
strConsonants += s.charAt(i);
}
}
// console.log(strVowels);
i = 0;
for (i in strVowels) {
console.log(strVowels.charAt(i));
}
// console.log(strConsonants);
i = 0;
for (i in strConsonants) {
console.log(strConsonants.charAt(i));
}
}
javascript beginner programming-challenge
New contributor
$endgroup$
add a comment |
$begingroup$
I completed a short coding challenge and just want to know if I should use shorter methods of which I am unaware, or make it more readable.
/*
*
* Complete the vowelsAndConsonants function.
* Print your output using 'console.log()'.
*/
function vowelsAndConsonants(s) {
var strConsonants = "";
var strVowels = "";
var i;
for (i in s) {
if (s.charAt(i) == "a" || s.charAt(i) == "e" || s.charAt(i) == "i" ||
s.charAt(i) == "o" || s.charAt(i) == "u") {
strVowels += s.charAt(i);
}
else if (s.charAt(i) != "a" || s.charAt(i) != "e" || s.charAt(i) != "i"
|| s.charAt(i) != "o" || s.charAt(i) != "u") {
strConsonants += s.charAt(i);
}
}
// console.log(strVowels);
i = 0;
for (i in strVowels) {
console.log(strVowels.charAt(i));
}
// console.log(strConsonants);
i = 0;
for (i in strConsonants) {
console.log(strConsonants.charAt(i));
}
}
javascript beginner programming-challenge
New contributor
$endgroup$
I completed a short coding challenge and just want to know if I should use shorter methods of which I am unaware, or make it more readable.
/*
*
* Complete the vowelsAndConsonants function.
* Print your output using 'console.log()'.
*/
function vowelsAndConsonants(s) {
var strConsonants = "";
var strVowels = "";
var i;
for (i in s) {
if (s.charAt(i) == "a" || s.charAt(i) == "e" || s.charAt(i) == "i" ||
s.charAt(i) == "o" || s.charAt(i) == "u") {
strVowels += s.charAt(i);
}
else if (s.charAt(i) != "a" || s.charAt(i) != "e" || s.charAt(i) != "i"
|| s.charAt(i) != "o" || s.charAt(i) != "u") {
strConsonants += s.charAt(i);
}
}
// console.log(strVowels);
i = 0;
for (i in strVowels) {
console.log(strVowels.charAt(i));
}
// console.log(strConsonants);
i = 0;
for (i in strConsonants) {
console.log(strConsonants.charAt(i));
}
}
javascript beginner programming-challenge
javascript beginner programming-challenge
New contributor
New contributor
edited 8 hours ago
Jacob Franklin
New contributor
asked yesterday
Jacob FranklinJacob Franklin
61
61
New contributor
New contributor
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216086%2finput-string-output-vowels-and-consonants-to-log-separately-but-in-order%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.
Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.
Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.
Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216086%2finput-string-output-vowels-and-consonants-to-log-separately-but-in-order%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown