Simple Rock, Paper, Scissors Python Game












1












$begingroup$


I tried to learn Python during the weekend and after getting some knowledge decided to make a small rock-paper-scissors game. I would be grateful for your input on how I could improve my code. All feedback is highly appreciated.



import random


def round_winner(choice):
ai_chosen = str(random.randint(1, 3))
print(f'AI chose {ai_chosen}')

if choice == '1' and ai_chosen == '2':
return 'ai'
elif choice == '2' and ai_chosen == '3':
return 'ai'
elif choice == '3' and ai_chosen == '1':
return 'ai'
elif choice == ai_chosen:
return 'tie'
else:
return 'player'


def display_round_winner(winner):
if winner == 'tie':
print('This round is tied!')
else:
print(f'The winner this round is the {winner.upper()}')

print(f'''
Current points as follows:
Player: {counter['player']}
AI: {counter['ai']}
Rounds Tied: {counter['tie']}
''')


def score_checker():
global game_ongoing
for key, value in counter.items():
if value == 2:
print(f'{key.upper()} wins the game!')
game_ongoing = False


def initializer():
global counter
message = '''
Please choose one of the following:
1: Rock
2: Paper
3: Scissors
'''

print(message)

choice_of_obj = input('What will it be: ')
if choice_of_obj in ['1', '2', '3']:
winner = round_winner(choice_of_obj)
counter[winner] += 1
display_round_winner(winner)
score_checker()
else:
print('Out of bounds')


counter = {
'player': 0,
'ai': 0,
'tie': 0
}

game_ongoing = True

while game_ongoing:
initializer()









share|improve this question









New contributor




aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    1












    $begingroup$


    I tried to learn Python during the weekend and after getting some knowledge decided to make a small rock-paper-scissors game. I would be grateful for your input on how I could improve my code. All feedback is highly appreciated.



    import random


    def round_winner(choice):
    ai_chosen = str(random.randint(1, 3))
    print(f'AI chose {ai_chosen}')

    if choice == '1' and ai_chosen == '2':
    return 'ai'
    elif choice == '2' and ai_chosen == '3':
    return 'ai'
    elif choice == '3' and ai_chosen == '1':
    return 'ai'
    elif choice == ai_chosen:
    return 'tie'
    else:
    return 'player'


    def display_round_winner(winner):
    if winner == 'tie':
    print('This round is tied!')
    else:
    print(f'The winner this round is the {winner.upper()}')

    print(f'''
    Current points as follows:
    Player: {counter['player']}
    AI: {counter['ai']}
    Rounds Tied: {counter['tie']}
    ''')


    def score_checker():
    global game_ongoing
    for key, value in counter.items():
    if value == 2:
    print(f'{key.upper()} wins the game!')
    game_ongoing = False


    def initializer():
    global counter
    message = '''
    Please choose one of the following:
    1: Rock
    2: Paper
    3: Scissors
    '''

    print(message)

    choice_of_obj = input('What will it be: ')
    if choice_of_obj in ['1', '2', '3']:
    winner = round_winner(choice_of_obj)
    counter[winner] += 1
    display_round_winner(winner)
    score_checker()
    else:
    print('Out of bounds')


    counter = {
    'player': 0,
    'ai': 0,
    'tie': 0
    }

    game_ongoing = True

    while game_ongoing:
    initializer()









    share|improve this question









    New contributor




    aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      I tried to learn Python during the weekend and after getting some knowledge decided to make a small rock-paper-scissors game. I would be grateful for your input on how I could improve my code. All feedback is highly appreciated.



      import random


      def round_winner(choice):
      ai_chosen = str(random.randint(1, 3))
      print(f'AI chose {ai_chosen}')

      if choice == '1' and ai_chosen == '2':
      return 'ai'
      elif choice == '2' and ai_chosen == '3':
      return 'ai'
      elif choice == '3' and ai_chosen == '1':
      return 'ai'
      elif choice == ai_chosen:
      return 'tie'
      else:
      return 'player'


      def display_round_winner(winner):
      if winner == 'tie':
      print('This round is tied!')
      else:
      print(f'The winner this round is the {winner.upper()}')

      print(f'''
      Current points as follows:
      Player: {counter['player']}
      AI: {counter['ai']}
      Rounds Tied: {counter['tie']}
      ''')


      def score_checker():
      global game_ongoing
      for key, value in counter.items():
      if value == 2:
      print(f'{key.upper()} wins the game!')
      game_ongoing = False


      def initializer():
      global counter
      message = '''
      Please choose one of the following:
      1: Rock
      2: Paper
      3: Scissors
      '''

      print(message)

      choice_of_obj = input('What will it be: ')
      if choice_of_obj in ['1', '2', '3']:
      winner = round_winner(choice_of_obj)
      counter[winner] += 1
      display_round_winner(winner)
      score_checker()
      else:
      print('Out of bounds')


      counter = {
      'player': 0,
      'ai': 0,
      'tie': 0
      }

      game_ongoing = True

      while game_ongoing:
      initializer()









      share|improve this question









      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I tried to learn Python during the weekend and after getting some knowledge decided to make a small rock-paper-scissors game. I would be grateful for your input on how I could improve my code. All feedback is highly appreciated.



      import random


      def round_winner(choice):
      ai_chosen = str(random.randint(1, 3))
      print(f'AI chose {ai_chosen}')

      if choice == '1' and ai_chosen == '2':
      return 'ai'
      elif choice == '2' and ai_chosen == '3':
      return 'ai'
      elif choice == '3' and ai_chosen == '1':
      return 'ai'
      elif choice == ai_chosen:
      return 'tie'
      else:
      return 'player'


      def display_round_winner(winner):
      if winner == 'tie':
      print('This round is tied!')
      else:
      print(f'The winner this round is the {winner.upper()}')

      print(f'''
      Current points as follows:
      Player: {counter['player']}
      AI: {counter['ai']}
      Rounds Tied: {counter['tie']}
      ''')


      def score_checker():
      global game_ongoing
      for key, value in counter.items():
      if value == 2:
      print(f'{key.upper()} wins the game!')
      game_ongoing = False


      def initializer():
      global counter
      message = '''
      Please choose one of the following:
      1: Rock
      2: Paper
      3: Scissors
      '''

      print(message)

      choice_of_obj = input('What will it be: ')
      if choice_of_obj in ['1', '2', '3']:
      winner = round_winner(choice_of_obj)
      counter[winner] += 1
      display_round_winner(winner)
      score_checker()
      else:
      print('Out of bounds')


      counter = {
      'player': 0,
      'ai': 0,
      'tie': 0
      }

      game_ongoing = True

      while game_ongoing:
      initializer()






      python beginner rock-paper-scissors






      share|improve this question









      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 3 hours ago









      esote

      2,7861938




      2,7861938






      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 4 hours ago









      aleisleyaleisley

      61




      61




      New contributor




      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      aleisley is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          1 Answer
          1






          active

          oldest

          votes


















          0












          $begingroup$

          You ask the player to enter 1, 2 or 3 for Rock, Paper or Scissors. When you tell the player what the AI choose, you say it was a 1, 2 or a 3. It would be friendlier if you said what they choose. You could do this with a dictionary that translates the abbreviated choice into the actual item.



          choices = { '1': 'Rock', '2': 'Paper', '3': 'Scissors' }

          def round_winner(choice):
          ai_chosen = ...
          print(f'AI chose {choice[ai_chosen]}')
          ...


          Also, you could use that dictionary to print out the menu for the player, instead of hard-coding it:



              print('Please choose one of the following:')
          for choice, item in choices:
          print(f'{choice}: {item}')




          You are using “ai”, “player”, and “tie” as keys for your counter dictionary, and always printing out winner.upper() when you print out a winner. You could just use “AI”, “PLAYER” and “TIE” as the dictionary keys, avoiding the need for the .upper() calls.





          score_checker is an odd name. Perhaps one of the hardest things about programming is coming up with good names. check_for_game_winner might be better.



          Using global is almost always bad. You just need to pass a true/false value back to the caller to indicate if the game is over. Use a return statement. Ie, inside if value == 2:, add a return True statement.





          initializer is another terrible name. play_round would be better.



          Checking for the overall winner inside play_round is confusing responsibilities. The play_round function doesn’t know it is being called in a loop, if at all. It should be removed from here.



          global counter is again a bad idea. You could simply pass the counter in as an argument.





          Instead of having the game code run directly, you should add a play_games function, and move the counter initialization code and loop inside that. With other changes, above, it might look like:



          def play_games():
          counter = { 'PLAYER': 0, 'AI':0, 'TIE': 0}
          while True:
          play_round(counter)
          if check_for_game_winner(counter):
          break




          The file should only execute code if the file is the main program. If the file is imported into another file, you wouldn’t want the code to automatically run. The following guard is usually used for this:



          if __name__ == '__main__':
          play_game()




          Your model of storing the player’s & AI’s moves as strings is perhaps not the best. If you used integers, you could perform the rock beats scissors beats paper beats rock test with modulo arithmetic:



          if ai_choice % 3  == (choice + 1) % 3:
          # the AI won





          share|improve this answer











          $endgroup$













          • $begingroup$
            Thanks for the input! c:
            $endgroup$
            – aleisley
            8 mins ago











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          aleisley is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215714%2fsimple-rock-paper-scissors-python-game%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          0












          $begingroup$

          You ask the player to enter 1, 2 or 3 for Rock, Paper or Scissors. When you tell the player what the AI choose, you say it was a 1, 2 or a 3. It would be friendlier if you said what they choose. You could do this with a dictionary that translates the abbreviated choice into the actual item.



          choices = { '1': 'Rock', '2': 'Paper', '3': 'Scissors' }

          def round_winner(choice):
          ai_chosen = ...
          print(f'AI chose {choice[ai_chosen]}')
          ...


          Also, you could use that dictionary to print out the menu for the player, instead of hard-coding it:



              print('Please choose one of the following:')
          for choice, item in choices:
          print(f'{choice}: {item}')




          You are using “ai”, “player”, and “tie” as keys for your counter dictionary, and always printing out winner.upper() when you print out a winner. You could just use “AI”, “PLAYER” and “TIE” as the dictionary keys, avoiding the need for the .upper() calls.





          score_checker is an odd name. Perhaps one of the hardest things about programming is coming up with good names. check_for_game_winner might be better.



          Using global is almost always bad. You just need to pass a true/false value back to the caller to indicate if the game is over. Use a return statement. Ie, inside if value == 2:, add a return True statement.





          initializer is another terrible name. play_round would be better.



          Checking for the overall winner inside play_round is confusing responsibilities. The play_round function doesn’t know it is being called in a loop, if at all. It should be removed from here.



          global counter is again a bad idea. You could simply pass the counter in as an argument.





          Instead of having the game code run directly, you should add a play_games function, and move the counter initialization code and loop inside that. With other changes, above, it might look like:



          def play_games():
          counter = { 'PLAYER': 0, 'AI':0, 'TIE': 0}
          while True:
          play_round(counter)
          if check_for_game_winner(counter):
          break




          The file should only execute code if the file is the main program. If the file is imported into another file, you wouldn’t want the code to automatically run. The following guard is usually used for this:



          if __name__ == '__main__':
          play_game()




          Your model of storing the player’s & AI’s moves as strings is perhaps not the best. If you used integers, you could perform the rock beats scissors beats paper beats rock test with modulo arithmetic:



          if ai_choice % 3  == (choice + 1) % 3:
          # the AI won





          share|improve this answer











          $endgroup$













          • $begingroup$
            Thanks for the input! c:
            $endgroup$
            – aleisley
            8 mins ago
















          0












          $begingroup$

          You ask the player to enter 1, 2 or 3 for Rock, Paper or Scissors. When you tell the player what the AI choose, you say it was a 1, 2 or a 3. It would be friendlier if you said what they choose. You could do this with a dictionary that translates the abbreviated choice into the actual item.



          choices = { '1': 'Rock', '2': 'Paper', '3': 'Scissors' }

          def round_winner(choice):
          ai_chosen = ...
          print(f'AI chose {choice[ai_chosen]}')
          ...


          Also, you could use that dictionary to print out the menu for the player, instead of hard-coding it:



              print('Please choose one of the following:')
          for choice, item in choices:
          print(f'{choice}: {item}')




          You are using “ai”, “player”, and “tie” as keys for your counter dictionary, and always printing out winner.upper() when you print out a winner. You could just use “AI”, “PLAYER” and “TIE” as the dictionary keys, avoiding the need for the .upper() calls.





          score_checker is an odd name. Perhaps one of the hardest things about programming is coming up with good names. check_for_game_winner might be better.



          Using global is almost always bad. You just need to pass a true/false value back to the caller to indicate if the game is over. Use a return statement. Ie, inside if value == 2:, add a return True statement.





          initializer is another terrible name. play_round would be better.



          Checking for the overall winner inside play_round is confusing responsibilities. The play_round function doesn’t know it is being called in a loop, if at all. It should be removed from here.



          global counter is again a bad idea. You could simply pass the counter in as an argument.





          Instead of having the game code run directly, you should add a play_games function, and move the counter initialization code and loop inside that. With other changes, above, it might look like:



          def play_games():
          counter = { 'PLAYER': 0, 'AI':0, 'TIE': 0}
          while True:
          play_round(counter)
          if check_for_game_winner(counter):
          break




          The file should only execute code if the file is the main program. If the file is imported into another file, you wouldn’t want the code to automatically run. The following guard is usually used for this:



          if __name__ == '__main__':
          play_game()




          Your model of storing the player’s & AI’s moves as strings is perhaps not the best. If you used integers, you could perform the rock beats scissors beats paper beats rock test with modulo arithmetic:



          if ai_choice % 3  == (choice + 1) % 3:
          # the AI won





          share|improve this answer











          $endgroup$













          • $begingroup$
            Thanks for the input! c:
            $endgroup$
            – aleisley
            8 mins ago














          0












          0








          0





          $begingroup$

          You ask the player to enter 1, 2 or 3 for Rock, Paper or Scissors. When you tell the player what the AI choose, you say it was a 1, 2 or a 3. It would be friendlier if you said what they choose. You could do this with a dictionary that translates the abbreviated choice into the actual item.



          choices = { '1': 'Rock', '2': 'Paper', '3': 'Scissors' }

          def round_winner(choice):
          ai_chosen = ...
          print(f'AI chose {choice[ai_chosen]}')
          ...


          Also, you could use that dictionary to print out the menu for the player, instead of hard-coding it:



              print('Please choose one of the following:')
          for choice, item in choices:
          print(f'{choice}: {item}')




          You are using “ai”, “player”, and “tie” as keys for your counter dictionary, and always printing out winner.upper() when you print out a winner. You could just use “AI”, “PLAYER” and “TIE” as the dictionary keys, avoiding the need for the .upper() calls.





          score_checker is an odd name. Perhaps one of the hardest things about programming is coming up with good names. check_for_game_winner might be better.



          Using global is almost always bad. You just need to pass a true/false value back to the caller to indicate if the game is over. Use a return statement. Ie, inside if value == 2:, add a return True statement.





          initializer is another terrible name. play_round would be better.



          Checking for the overall winner inside play_round is confusing responsibilities. The play_round function doesn’t know it is being called in a loop, if at all. It should be removed from here.



          global counter is again a bad idea. You could simply pass the counter in as an argument.





          Instead of having the game code run directly, you should add a play_games function, and move the counter initialization code and loop inside that. With other changes, above, it might look like:



          def play_games():
          counter = { 'PLAYER': 0, 'AI':0, 'TIE': 0}
          while True:
          play_round(counter)
          if check_for_game_winner(counter):
          break




          The file should only execute code if the file is the main program. If the file is imported into another file, you wouldn’t want the code to automatically run. The following guard is usually used for this:



          if __name__ == '__main__':
          play_game()




          Your model of storing the player’s & AI’s moves as strings is perhaps not the best. If you used integers, you could perform the rock beats scissors beats paper beats rock test with modulo arithmetic:



          if ai_choice % 3  == (choice + 1) % 3:
          # the AI won





          share|improve this answer











          $endgroup$



          You ask the player to enter 1, 2 or 3 for Rock, Paper or Scissors. When you tell the player what the AI choose, you say it was a 1, 2 or a 3. It would be friendlier if you said what they choose. You could do this with a dictionary that translates the abbreviated choice into the actual item.



          choices = { '1': 'Rock', '2': 'Paper', '3': 'Scissors' }

          def round_winner(choice):
          ai_chosen = ...
          print(f'AI chose {choice[ai_chosen]}')
          ...


          Also, you could use that dictionary to print out the menu for the player, instead of hard-coding it:



              print('Please choose one of the following:')
          for choice, item in choices:
          print(f'{choice}: {item}')




          You are using “ai”, “player”, and “tie” as keys for your counter dictionary, and always printing out winner.upper() when you print out a winner. You could just use “AI”, “PLAYER” and “TIE” as the dictionary keys, avoiding the need for the .upper() calls.





          score_checker is an odd name. Perhaps one of the hardest things about programming is coming up with good names. check_for_game_winner might be better.



          Using global is almost always bad. You just need to pass a true/false value back to the caller to indicate if the game is over. Use a return statement. Ie, inside if value == 2:, add a return True statement.





          initializer is another terrible name. play_round would be better.



          Checking for the overall winner inside play_round is confusing responsibilities. The play_round function doesn’t know it is being called in a loop, if at all. It should be removed from here.



          global counter is again a bad idea. You could simply pass the counter in as an argument.





          Instead of having the game code run directly, you should add a play_games function, and move the counter initialization code and loop inside that. With other changes, above, it might look like:



          def play_games():
          counter = { 'PLAYER': 0, 'AI':0, 'TIE': 0}
          while True:
          play_round(counter)
          if check_for_game_winner(counter):
          break




          The file should only execute code if the file is the main program. If the file is imported into another file, you wouldn’t want the code to automatically run. The following guard is usually used for this:



          if __name__ == '__main__':
          play_game()




          Your model of storing the player’s & AI’s moves as strings is perhaps not the best. If you used integers, you could perform the rock beats scissors beats paper beats rock test with modulo arithmetic:



          if ai_choice % 3  == (choice + 1) % 3:
          # the AI won






          share|improve this answer














          share|improve this answer



          share|improve this answer








          edited 41 mins ago

























          answered 49 mins ago









          AJNeufeldAJNeufeld

          6,2201621




          6,2201621












          • $begingroup$
            Thanks for the input! c:
            $endgroup$
            – aleisley
            8 mins ago


















          • $begingroup$
            Thanks for the input! c:
            $endgroup$
            – aleisley
            8 mins ago
















          $begingroup$
          Thanks for the input! c:
          $endgroup$
          – aleisley
          8 mins ago




          $begingroup$
          Thanks for the input! c:
          $endgroup$
          – aleisley
          8 mins ago










          aleisley is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          aleisley is a new contributor. Be nice, and check out our Code of Conduct.













          aleisley is a new contributor. Be nice, and check out our Code of Conduct.












          aleisley is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215714%2fsimple-rock-paper-scissors-python-game%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀