Simple unit test in C of input using freopen
$begingroup$
Here is an initial attempt at unit test of user input in C. The thing that feels unusual is the use of freopen to send the test data to stdin. Are there better ways to implement this kind of test?
#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
static size_t get_num(size_t tmpnum) {
if (scanf("%zu", &tmpnum) != 1) {
fprintf(stderr, "ERROR: system error: failed to read input, exiting.n");
exit(1);
}
return tmpnum;
}
int main(void)
{
int return_status = 0;
/* Test 1 */
if (freopen("test-data.txt", "r", stdin) != NULL) {
size_t tmpnum = 0;
tmpnum = get_num(tmpnum);
assert(tmpnum >= 1 && tmpnum <= 20);
printf("ok: tmpnum == %ldn", tmpnum);
freopen("/dev/stdin", "r", stdin);
} else {
printf("ERROR: failed to open test-data.txtn");
return_status = EXIT_FAILURE;
}
return return_status;
}
c unit-testing io
edited 13 mins ago
200_success
129k15153415
asked 7 hours ago
Runway BluesRunway Blues
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Here is an initial attempt at unit test of user input in C. The thing that feels unusual is the use of freopen to send the test data to stdin. Are there better ways to implement this kind of test?
#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
static size_t get_num(size_t tmpnum) {
if (scanf("%zu", &tmpnum) != 1) {
fprintf(stderr, "ERROR: system error: failed to read input, exiting.n");
exit(1);
}
return tmpnum;
}
int main(void)
{
int return_status = 0;
/* Test 1 */
if (freopen("test-data.txt", "r", stdin) != NULL) {
size_t tmpnum = 0;
tmpnum = get_num(tmpnum);
assert(tmpnum >= 1 && tmpnum <= 20);
printf("ok: tmpnum == %ldn", tmpnum);
freopen("/dev/stdin", "r", stdin);
} else {
printf("ERROR: failed to open test-data.txtn");
return_status = EXIT_FAILURE;
}
return return_status;
}
c unit-testing io
edited 13 mins ago
200_success
129k15153415
asked 7 hours ago
Runway BluesRunway Blues
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
Here is an initial attempt at unit test of user input in C. The thing that feels unusual is the use of freopen to send the test data to stdin. Are there better ways to implement this kind of test?
#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
static size_t get_num(size_t tmpnum) {
if (scanf("%zu", &tmpnum) != 1) {
fprintf(stderr, "ERROR: system error: failed to read input, exiting.n");
exit(1);
}
return tmpnum;
}
int main(void)
{
int return_status = 0;
/* Test 1 */
if (freopen("test-data.txt", "r", stdin) != NULL) {
size_t tmpnum = 0;
tmpnum = get_num(tmpnum);
assert(tmpnum >= 1 && tmpnum <= 20);
printf("ok: tmpnum == %ldn", tmpnum);
freopen("/dev/stdin", "r", stdin);
} else {
printf("ERROR: failed to open test-data.txtn");
return_status = EXIT_FAILURE;
}
return return_status;
}
c unit-testing io
edited 13 mins ago
200_success
129k15153415
asked 7 hours ago
Runway BluesRunway Blues
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
Here is an initial attempt at unit test of user input in C. The thing that feels unusual is the use of freopen to send the test data to stdin. Are there better ways to implement this kind of test?
#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
static size_t get_num(size_t tmpnum) {
if (scanf("%zu", &tmpnum) != 1) {
fprintf(stderr, "ERROR: system error: failed to read input, exiting.n");
exit(1);
}
return tmpnum;
}
int main(void)
{
int return_status = 0;
/* Test 1 */
if (freopen("test-data.txt", "r", stdin) != NULL) {
size_t tmpnum = 0;
tmpnum = get_num(tmpnum);
assert(tmpnum >= 1 && tmpnum <= 20);
printf("ok: tmpnum == %ldn", tmpnum);
freopen("/dev/stdin", "r", stdin);
} else {
printf("ERROR: failed to open test-data.txtn");
return_status = EXIT_FAILURE;
}
return return_status;
}
c unit-testing io
c unit-testing io
edited 13 mins ago
200_success
129k15153415
asked 7 hours ago
Runway BluesRunway Blues
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 13 mins ago
200_success
129k15153415
asked 7 hours ago
Runway BluesRunway Blues
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 13 mins ago
200_success
129k15153415
edited 13 mins ago
200_success
129k15153415
edited 13 mins ago
200_success
129k15153415
129k15153415
asked 7 hours ago
Runway BluesRunway Blues
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 hours ago
Runway BluesRunway Blues
33
asked 7 hours ago
Runway BluesRunway Blues
33
33
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Runway Blues is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
$begingroup$
The thing that feels unusual is the use of freopen to send the test data to stdin.
Are there better ways to implement this kind of test?
C has a freopen() footnote
The primary use of the
freopenfunction is to change the file associated with a standard text stream (stderr,stdin, orstdout), as those identifiers need not be modifiable lvalues to which the value returned by thefopenfunction may be assigned.
This looks like a good direct way to test code, although I'd expect stdout, strderr being re-opened to capture output.
Are there better ways
Enable all compiler warnings - save time.
The mismatch of specifier and type implies code is not efficiently using the 1st round of code improvement: Compiler warnings.
// printf("ok: tmpnum == %ldn", tmpnum);
printf("ok: tmpnum == %zun", tmpnum);
Code is strange in that it passes in tmpnum for no good reason.
//static size_t get_num(size_t tmpnum) {
// if (scanf("%zu", &tmpnum) != 1) {
static size_t get_num(void) {
size_t tmpnum;
if (scanf("%zu", &tmpnum) != 1) {
answered 26 mins ago
chuxchux
13.1k21344
$endgroup$
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Runway Blues is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212155%2fsimple-unit-test-in-c-of-input-using-freopen%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
The thing that feels unusual is the use of freopen to send the test data to stdin.
Are there better ways to implement this kind of test?
C has a freopen() footnote
The primary use of the
freopenfunction is to change the file associated with a standard text stream (stderr,stdin, orstdout), as those identifiers need not be modifiable lvalues to which the value returned by thefopenfunction may be assigned.
This looks like a good direct way to test code, although I'd expect stdout, strderr being re-opened to capture output.
Are there better ways
Enable all compiler warnings - save time.
The mismatch of specifier and type implies code is not efficiently using the 1st round of code improvement: Compiler warnings.
// printf("ok: tmpnum == %ldn", tmpnum);
printf("ok: tmpnum == %zun", tmpnum);
Code is strange in that it passes in tmpnum for no good reason.
//static size_t get_num(size_t tmpnum) {
// if (scanf("%zu", &tmpnum) != 1) {
static size_t get_num(void) {
size_t tmpnum;
if (scanf("%zu", &tmpnum) != 1) {
answered 26 mins ago
chuxchux
13.1k21344
$endgroup$
add a comment |
$begingroup$
The thing that feels unusual is the use of freopen to send the test data to stdin.
Are there better ways to implement this kind of test?
C has a freopen() footnote
The primary use of the
freopenfunction is to change the file associated with a standard text stream (stderr,stdin, orstdout), as those identifiers need not be modifiable lvalues to which the value returned by thefopenfunction may be assigned.
This looks like a good direct way to test code, although I'd expect stdout, strderr being re-opened to capture output.
Are there better ways
Enable all compiler warnings - save time.
The mismatch of specifier and type implies code is not efficiently using the 1st round of code improvement: Compiler warnings.
// printf("ok: tmpnum == %ldn", tmpnum);
printf("ok: tmpnum == %zun", tmpnum);
Code is strange in that it passes in tmpnum for no good reason.
//static size_t get_num(size_t tmpnum) {
// if (scanf("%zu", &tmpnum) != 1) {
static size_t get_num(void) {
size_t tmpnum;
if (scanf("%zu", &tmpnum) != 1) {
answered 26 mins ago
chuxchux
13.1k21344
$endgroup$
add a comment |
$begingroup$
The thing that feels unusual is the use of freopen to send the test data to stdin.
Are there better ways to implement this kind of test?
C has a freopen() footnote
The primary use of the
freopenfunction is to change the file associated with a standard text stream (stderr,stdin, orstdout), as those identifiers need not be modifiable lvalues to which the value returned by thefopenfunction may be assigned.
This looks like a good direct way to test code, although I'd expect stdout, strderr being re-opened to capture output.
Are there better ways
Enable all compiler warnings - save time.
The mismatch of specifier and type implies code is not efficiently using the 1st round of code improvement: Compiler warnings.
// printf("ok: tmpnum == %ldn", tmpnum);
printf("ok: tmpnum == %zun", tmpnum);
Code is strange in that it passes in tmpnum for no good reason.
//static size_t get_num(size_t tmpnum) {
// if (scanf("%zu", &tmpnum) != 1) {
static size_t get_num(void) {
size_t tmpnum;
if (scanf("%zu", &tmpnum) != 1) {
answered 26 mins ago
chuxchux
13.1k21344
$endgroup$
The thing that feels unusual is the use of freopen to send the test data to stdin.
Are there better ways to implement this kind of test?
C has a freopen() footnote
The primary use of the
freopenfunction is to change the file associated with a standard text stream (stderr,stdin, orstdout), as those identifiers need not be modifiable lvalues to which the value returned by thefopenfunction may be assigned.
This looks like a good direct way to test code, although I'd expect stdout, strderr being re-opened to capture output.
Are there better ways
Enable all compiler warnings - save time.
The mismatch of specifier and type implies code is not efficiently using the 1st round of code improvement: Compiler warnings.
// printf("ok: tmpnum == %ldn", tmpnum);
printf("ok: tmpnum == %zun", tmpnum);
Code is strange in that it passes in tmpnum for no good reason.
//static size_t get_num(size_t tmpnum) {
// if (scanf("%zu", &tmpnum) != 1) {
static size_t get_num(void) {
size_t tmpnum;
if (scanf("%zu", &tmpnum) != 1) {
answered 26 mins ago
chuxchux
13.1k21344
edited 8 mins ago
answered 26 mins ago
chuxchux
13.1k21344
answered 26 mins ago
chuxchux
13.1k21344
answered 26 mins ago
chuxchux
13.1k21344
13.1k21344
add a comment |
add a comment |
Runway Blues is a new contributor. Be nice, and check out our Code of Conduct.
Runway Blues is a new contributor. Be nice, and check out our Code of Conduct.
Runway Blues is a new contributor. Be nice, and check out our Code of Conduct.
Runway Blues is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212155%2fsimple-unit-test-in-c-of-input-using-freopen%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
