React hook “select all” checkbox implementation












1












$begingroup$


This is a select-all checkbox (and checkboxes that it controls), that's usually found in tables/lists.



Two things I'm concerned about:




  1. I'm returning elements from a React Hook - is that OK to do? As opposed to create a Component (probably a render prop)


  2. I'm calculating master.indeterminate in a useEffect, as opposed to doing it when the checkboxes are clicked.



I'm planning on using it in a table that will have 1000s of entries, filtered/paginated upto 100.



I realize #2 could be a performance issue since I'm essentially checking all checkboxes to determine whether to set master.indeterminate, but since the table will be filtered I want this to be "reactive" as well.



Any other issues I might be overlooking?



Fiddle



const h = (...args) => React.createElement(...args)

function useSelectAll(existingStateOrSize = ) {
const [state, update] = React.useState(existingStateOrSize)
const master = React.useRef(null)
const children = React.useRef(state.map(() => null))

function setIndeterminate () {
/* Calculate master.indeterminate */
let allChecked
for (const child of children.current) {
if (!child) continue
const checked = Boolean(child.checked)
if (allChecked === undefined) {
allChecked = checked
} else if (allChecked !== checked) {
allChecked = null
break
}
}
if (typeof allChecked === 'boolean') {
master.current.checked = allChecked
master.current.indeterminate = false
} else {
master.current.indeterminate = true
}
}

function onChangeMaster() {
children.current.forEach(child => child.checked = master.current.checked)
}

function onChangeChild(e) {
const i = children.current.indexOf(e.target)
const newState = Array.from(state)
newState[i] = e.target.checked
update(newState)
}

React.useEffect(setIndeterminate)

return [
state,
h('input', { type: 'checkbox', ref: master, onChange: onChangeMaster }),
state.map((x, i) => h('input', { type: 'checkbox', ref: r => children.current[i] = r, checked: existingStateOrSize[i], onChange: onChangeChild }))
]
}

function Table() {
const [state, master, children] = useSelectAll([null,null,null])
return h('table', {}, [
h('tr', {}, h('th', {}, master), h('th', {}, 'Select all')),
h('tr', {}, h('td', {}, children[0]), h('td', {}, 'First')),
h('tr', {}, h('td', {}, children[1]), h('td', {}, 'Second')),
h('tr', {}, h('td', {}, children[2]), h('td', {}, 'Third')),
])
}

ReactDOM.render(h(Table), document.getElementById('container'))








share











$endgroup$

















    1












    $begingroup$


    This is a select-all checkbox (and checkboxes that it controls), that's usually found in tables/lists.



    Two things I'm concerned about:




    1. I'm returning elements from a React Hook - is that OK to do? As opposed to create a Component (probably a render prop)


    2. I'm calculating master.indeterminate in a useEffect, as opposed to doing it when the checkboxes are clicked.



    I'm planning on using it in a table that will have 1000s of entries, filtered/paginated upto 100.



    I realize #2 could be a performance issue since I'm essentially checking all checkboxes to determine whether to set master.indeterminate, but since the table will be filtered I want this to be "reactive" as well.



    Any other issues I might be overlooking?



    Fiddle



    const h = (...args) => React.createElement(...args)

    function useSelectAll(existingStateOrSize = ) {
    const [state, update] = React.useState(existingStateOrSize)
    const master = React.useRef(null)
    const children = React.useRef(state.map(() => null))

    function setIndeterminate () {
    /* Calculate master.indeterminate */
    let allChecked
    for (const child of children.current) {
    if (!child) continue
    const checked = Boolean(child.checked)
    if (allChecked === undefined) {
    allChecked = checked
    } else if (allChecked !== checked) {
    allChecked = null
    break
    }
    }
    if (typeof allChecked === 'boolean') {
    master.current.checked = allChecked
    master.current.indeterminate = false
    } else {
    master.current.indeterminate = true
    }
    }

    function onChangeMaster() {
    children.current.forEach(child => child.checked = master.current.checked)
    }

    function onChangeChild(e) {
    const i = children.current.indexOf(e.target)
    const newState = Array.from(state)
    newState[i] = e.target.checked
    update(newState)
    }

    React.useEffect(setIndeterminate)

    return [
    state,
    h('input', { type: 'checkbox', ref: master, onChange: onChangeMaster }),
    state.map((x, i) => h('input', { type: 'checkbox', ref: r => children.current[i] = r, checked: existingStateOrSize[i], onChange: onChangeChild }))
    ]
    }

    function Table() {
    const [state, master, children] = useSelectAll([null,null,null])
    return h('table', {}, [
    h('tr', {}, h('th', {}, master), h('th', {}, 'Select all')),
    h('tr', {}, h('td', {}, children[0]), h('td', {}, 'First')),
    h('tr', {}, h('td', {}, children[1]), h('td', {}, 'Second')),
    h('tr', {}, h('td', {}, children[2]), h('td', {}, 'Third')),
    ])
    }

    ReactDOM.render(h(Table), document.getElementById('container'))








    share











    $endgroup$















      1












      1








      1





      $begingroup$


      This is a select-all checkbox (and checkboxes that it controls), that's usually found in tables/lists.



      Two things I'm concerned about:




      1. I'm returning elements from a React Hook - is that OK to do? As opposed to create a Component (probably a render prop)


      2. I'm calculating master.indeterminate in a useEffect, as opposed to doing it when the checkboxes are clicked.



      I'm planning on using it in a table that will have 1000s of entries, filtered/paginated upto 100.



      I realize #2 could be a performance issue since I'm essentially checking all checkboxes to determine whether to set master.indeterminate, but since the table will be filtered I want this to be "reactive" as well.



      Any other issues I might be overlooking?



      Fiddle



      const h = (...args) => React.createElement(...args)

      function useSelectAll(existingStateOrSize = ) {
      const [state, update] = React.useState(existingStateOrSize)
      const master = React.useRef(null)
      const children = React.useRef(state.map(() => null))

      function setIndeterminate () {
      /* Calculate master.indeterminate */
      let allChecked
      for (const child of children.current) {
      if (!child) continue
      const checked = Boolean(child.checked)
      if (allChecked === undefined) {
      allChecked = checked
      } else if (allChecked !== checked) {
      allChecked = null
      break
      }
      }
      if (typeof allChecked === 'boolean') {
      master.current.checked = allChecked
      master.current.indeterminate = false
      } else {
      master.current.indeterminate = true
      }
      }

      function onChangeMaster() {
      children.current.forEach(child => child.checked = master.current.checked)
      }

      function onChangeChild(e) {
      const i = children.current.indexOf(e.target)
      const newState = Array.from(state)
      newState[i] = e.target.checked
      update(newState)
      }

      React.useEffect(setIndeterminate)

      return [
      state,
      h('input', { type: 'checkbox', ref: master, onChange: onChangeMaster }),
      state.map((x, i) => h('input', { type: 'checkbox', ref: r => children.current[i] = r, checked: existingStateOrSize[i], onChange: onChangeChild }))
      ]
      }

      function Table() {
      const [state, master, children] = useSelectAll([null,null,null])
      return h('table', {}, [
      h('tr', {}, h('th', {}, master), h('th', {}, 'Select all')),
      h('tr', {}, h('td', {}, children[0]), h('td', {}, 'First')),
      h('tr', {}, h('td', {}, children[1]), h('td', {}, 'Second')),
      h('tr', {}, h('td', {}, children[2]), h('td', {}, 'Third')),
      ])
      }

      ReactDOM.render(h(Table), document.getElementById('container'))








      share











      $endgroup$




      This is a select-all checkbox (and checkboxes that it controls), that's usually found in tables/lists.



      Two things I'm concerned about:




      1. I'm returning elements from a React Hook - is that OK to do? As opposed to create a Component (probably a render prop)


      2. I'm calculating master.indeterminate in a useEffect, as opposed to doing it when the checkboxes are clicked.



      I'm planning on using it in a table that will have 1000s of entries, filtered/paginated upto 100.



      I realize #2 could be a performance issue since I'm essentially checking all checkboxes to determine whether to set master.indeterminate, but since the table will be filtered I want this to be "reactive" as well.



      Any other issues I might be overlooking?



      Fiddle



      const h = (...args) => React.createElement(...args)

      function useSelectAll(existingStateOrSize = ) {
      const [state, update] = React.useState(existingStateOrSize)
      const master = React.useRef(null)
      const children = React.useRef(state.map(() => null))

      function setIndeterminate () {
      /* Calculate master.indeterminate */
      let allChecked
      for (const child of children.current) {
      if (!child) continue
      const checked = Boolean(child.checked)
      if (allChecked === undefined) {
      allChecked = checked
      } else if (allChecked !== checked) {
      allChecked = null
      break
      }
      }
      if (typeof allChecked === 'boolean') {
      master.current.checked = allChecked
      master.current.indeterminate = false
      } else {
      master.current.indeterminate = true
      }
      }

      function onChangeMaster() {
      children.current.forEach(child => child.checked = master.current.checked)
      }

      function onChangeChild(e) {
      const i = children.current.indexOf(e.target)
      const newState = Array.from(state)
      newState[i] = e.target.checked
      update(newState)
      }

      React.useEffect(setIndeterminate)

      return [
      state,
      h('input', { type: 'checkbox', ref: master, onChange: onChangeMaster }),
      state.map((x, i) => h('input', { type: 'checkbox', ref: r => children.current[i] = r, checked: existingStateOrSize[i], onChange: onChangeChild }))
      ]
      }

      function Table() {
      const [state, master, children] = useSelectAll([null,null,null])
      return h('table', {}, [
      h('tr', {}, h('th', {}, master), h('th', {}, 'Select all')),
      h('tr', {}, h('td', {}, children[0]), h('td', {}, 'First')),
      h('tr', {}, h('td', {}, children[1]), h('td', {}, 'Second')),
      h('tr', {}, h('td', {}, children[2]), h('td', {}, 'Third')),
      ])
      }

      ReactDOM.render(h(Table), document.getElementById('container'))






      javascript form react.js





      share














      share












      share



      share








      edited 3 mins ago









      200_success

      129k15153415




      129k15153415










      asked 4 mins ago









      laggingreflexlaggingreflex

      1436




      1436






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213353%2freact-hook-select-all-checkbox-implementation%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213353%2freact-hook-select-all-checkbox-implementation%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀