Using foldl to add numbers, while validating that they are nonnegative
I have a function that will calculate the sum of a list of integer, however if any of the number is negative, it will should an error instead (not throwing exception).
The following is a working Haskell code (Glasgow Haskell Compiler, Version 7.10.3):
addAll :: [Int] -> Either String Int
addAll xs = foldl safeAdd (Right 0) xs
where
safeAdd :: Either String Int -> Int -> Either String Int
safeAdd = (acc next -> case acc of
Left s -> Left s
Right n -> if next < 0
then Left (show next ++ " is not positive")
else Right (n + next))
Examples output of the function:
addAll [1,2,3] -- Right 6
addAll [-1,2,3] -- Left "-1 is not positive"
Although the code works, but I'm not entirely satisfied with it, because the recursion keeps going until the last element even though errors are encountered early. Not only that, it feels a little more complicated than it should be.
After reading some SO posts such as this one, I think that the code above can be further simplified using functions like foldM or even applicative <$>.
But, I'm just not sure how to use those functions, so please do show me a way to simplify the code above.
haskell error-handling monads
edited 2 days ago
200_success
128k15152413
asked 2 days ago
Wong Jia Hau
1114
add a comment |
I have a function that will calculate the sum of a list of integer, however if any of the number is negative, it will should an error instead (not throwing exception).
The following is a working Haskell code (Glasgow Haskell Compiler, Version 7.10.3):
addAll :: [Int] -> Either String Int
addAll xs = foldl safeAdd (Right 0) xs
where
safeAdd :: Either String Int -> Int -> Either String Int
safeAdd = (acc next -> case acc of
Left s -> Left s
Right n -> if next < 0
then Left (show next ++ " is not positive")
else Right (n + next))
Examples output of the function:
addAll [1,2,3] -- Right 6
addAll [-1,2,3] -- Left "-1 is not positive"
Although the code works, but I'm not entirely satisfied with it, because the recursion keeps going until the last element even though errors are encountered early. Not only that, it feels a little more complicated than it should be.
After reading some SO posts such as this one, I think that the code above can be further simplified using functions like foldM or even applicative <$>.
But, I'm just not sure how to use those functions, so please do show me a way to simplify the code above.
haskell error-handling monads
edited 2 days ago
200_success
128k15152413
asked 2 days ago
Wong Jia Hau
1114
add a comment |
I have a function that will calculate the sum of a list of integer, however if any of the number is negative, it will should an error instead (not throwing exception).
The following is a working Haskell code (Glasgow Haskell Compiler, Version 7.10.3):
addAll :: [Int] -> Either String Int
addAll xs = foldl safeAdd (Right 0) xs
where
safeAdd :: Either String Int -> Int -> Either String Int
safeAdd = (acc next -> case acc of
Left s -> Left s
Right n -> if next < 0
then Left (show next ++ " is not positive")
else Right (n + next))
Examples output of the function:
addAll [1,2,3] -- Right 6
addAll [-1,2,3] -- Left "-1 is not positive"
Although the code works, but I'm not entirely satisfied with it, because the recursion keeps going until the last element even though errors are encountered early. Not only that, it feels a little more complicated than it should be.
After reading some SO posts such as this one, I think that the code above can be further simplified using functions like foldM or even applicative <$>.
But, I'm just not sure how to use those functions, so please do show me a way to simplify the code above.
haskell error-handling monads
edited 2 days ago
200_success
128k15152413
asked 2 days ago
Wong Jia Hau
1114
I have a function that will calculate the sum of a list of integer, however if any of the number is negative, it will should an error instead (not throwing exception).
The following is a working Haskell code (Glasgow Haskell Compiler, Version 7.10.3):
addAll :: [Int] -> Either String Int
addAll xs = foldl safeAdd (Right 0) xs
where
safeAdd :: Either String Int -> Int -> Either String Int
safeAdd = (acc next -> case acc of
Left s -> Left s
Right n -> if next < 0
then Left (show next ++ " is not positive")
else Right (n + next))
Examples output of the function:
addAll [1,2,3] -- Right 6
addAll [-1,2,3] -- Left "-1 is not positive"
Although the code works, but I'm not entirely satisfied with it, because the recursion keeps going until the last element even though errors are encountered early. Not only that, it feels a little more complicated than it should be.
After reading some SO posts such as this one, I think that the code above can be further simplified using functions like foldM or even applicative <$>.
But, I'm just not sure how to use those functions, so please do show me a way to simplify the code above.
haskell error-handling monads
haskell error-handling monads
edited 2 days ago
200_success
128k15152413
asked 2 days ago
Wong Jia Hau
1114
edited 2 days ago
200_success
128k15152413
asked 2 days ago
Wong Jia Hau
1114
edited 2 days ago
200_success
128k15152413
edited 2 days ago
200_success
128k15152413
edited 2 days ago
200_success
128k15152413
128k15152413
asked 2 days ago
Wong Jia Hau
1114
asked 2 days ago
Wong Jia Hau
1114
asked 2 days ago
Wong Jia Hau
1114
1114
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
import Data.Foldable
addAll :: [Int] -> Either String Int
addAll = foldlM safeAdd 0 where
safeAdd :: Int -> Int -> Either String Int
safeAdd n next = if next < 0
then Left (show next ++ " is not positive")
else Right (n + next)
Refer http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Foldable.html#v:foldlM
edited 2 hours ago
Wong Jia Hau
1114
answered 15 hours ago
Gurkenglas
2,763511
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210785%2fusing-foldl-to-add-numbers-while-validating-that-they-are-nonnegative%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
import Data.Foldable
addAll :: [Int] -> Either String Int
addAll = foldlM safeAdd 0 where
safeAdd :: Int -> Int -> Either String Int
safeAdd n next = if next < 0
then Left (show next ++ " is not positive")
else Right (n + next)
Refer http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Foldable.html#v:foldlM
edited 2 hours ago
Wong Jia Hau
1114
answered 15 hours ago
Gurkenglas
2,763511
add a comment |
import Data.Foldable
addAll :: [Int] -> Either String Int
addAll = foldlM safeAdd 0 where
safeAdd :: Int -> Int -> Either String Int
safeAdd n next = if next < 0
then Left (show next ++ " is not positive")
else Right (n + next)
Refer http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Foldable.html#v:foldlM
edited 2 hours ago
Wong Jia Hau
1114
answered 15 hours ago
Gurkenglas
2,763511
add a comment |
import Data.Foldable
addAll :: [Int] -> Either String Int
addAll = foldlM safeAdd 0 where
safeAdd :: Int -> Int -> Either String Int
safeAdd n next = if next < 0
then Left (show next ++ " is not positive")
else Right (n + next)
Refer http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Foldable.html#v:foldlM
edited 2 hours ago
Wong Jia Hau
1114
answered 15 hours ago
Gurkenglas
2,763511
import Data.Foldable
addAll :: [Int] -> Either String Int
addAll = foldlM safeAdd 0 where
safeAdd :: Int -> Int -> Either String Int
safeAdd n next = if next < 0
then Left (show next ++ " is not positive")
else Right (n + next)
Refer http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Foldable.html#v:foldlM
edited 2 hours ago
Wong Jia Hau
1114
answered 15 hours ago
Gurkenglas
2,763511
edited 2 hours ago
Wong Jia Hau
1114
edited 2 hours ago
Wong Jia Hau
1114
edited 2 hours ago
Wong Jia Hau
1114
1114
answered 15 hours ago
Gurkenglas
2,763511
answered 15 hours ago
Gurkenglas
2,763511
answered 15 hours ago
Gurkenglas
2,763511
2,763511
add a comment |
add a comment |
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210785%2fusing-foldl-to-add-numbers-while-validating-that-they-are-nonnegative%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
