Java exporting filtered objects to CSV












0












$begingroup$


I am exporting a List of virtual servers to a CSV file. The users submits filters and the applications generates FilterDTOs containing a map of the attribute and the corresponding value. The idea was to 'undock' the filter and the simple DTOs that contained all the variables from the export, so the export does not need to know the concrete filter (actually he knows but only to let the FilterDTOs be generated). All values in the map are Optional<String>.
Here is the exporter, the getFileEnding and getMediaType are given by the interface to dynamically handle the return of a byte in a REST-controller (I need the file ending to parse the file and the media type for setting the HTTP headers).
I would appreciate any critic and tips



public class FilteredCsvExporter implements Exporter {
private ExportFilter filter;

public FilteredCsvLbExporter(ExportFilter filter) {
this.filter = filter;
}

@Override
public void exportData() throws IOException, DocumentException {
List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
PrintWriter pw = new PrintWriter(new File(getBaseTempDir() + "/filteredExport.csv"));
writeDataToFile(pw, new StringBuilder(), servers);
}

private void writeDataToFile(PrintWriter printWriter, StringBuilder builder, List<VirtualServerFilterDTO> servers) {
generateHeadline(builder, servers);
servers = servers.stream().filter(i -> i.getAttributes().get("Pool").isPresent() != false).collect(Collectors.toList());
servers.forEach(server -> {
addMapToCsv(builder, server.getAttributes());
if (server.getAssignedPool().get().getAttributes().size() <= 0) {
return;
}
addMapToCsv(builder, server.getAssignedPool().get().getAttributes());
server.getAssignedPool().get().getMembers().forEach(member -> {
addMapToCsv(builder, member.getAttributes());
});
builder.append("n");
});
builder.append("n");
builder.append("n");
builder.append("Pools that are not assigned to any virtual server");
builder.append("n");
appendPoolsWithoutServerHeader(builder, servers);
builder.append("n");
getPoolsWithoutServer().forEach(pool -> {
addMapToCsv(builder, pool.getAttributes());
builder.append("n");
});
printWriter.write(builder.toString());
printWriter.close();
System.out.println("Done");
getPoolsWithoutServer();
}

private void appendPoolsWithoutServerHeader(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
builder.append(k);
builder.append(",");
});
}

private void addMapToCsv(StringBuilder builder, Map<String, Optional<String>> map) {
for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
if (entry.getValue().orElse("-").contains(",")) {
builder.append(escapeStringForCSV(entry.getValue()));
builder.append(",");
} else {
builder.append(entry.getValue().orElse("-"));
builder.append(",");
}
}
}

private List<PoolFilterDto> getPoolsWithoutServer() {
List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
List<PoolFilterDto> pools = new ArrayList<>();
List<PoolDTO> poolDTOS = PoolRepository.getInstance().getPools().getPools();
List<PoolDTO> temp = new ArrayList<>();

for (int i = 0; i < servers.size(); i++) {
for (int j = 0; j < poolDTOS.size(); j++) {
VirtualServerFilterDTO server = servers.get(i);
PoolDTO pool = poolDTOS.get(j);
if (server.getAssignedPool().isPresent()) {
if (server.getAssignedPool().get().getAttributes().size() > 0) {
if (server.getAssignedPool().get().getAttributes().get("Full path").get().equalsIgnoreCase(pool.getFullPath())) {
temp.add(pool);
}
}
}
}
}
poolDTOS.removeAll(temp);
poolDTOS.forEach(p -> {
pools.add(new PoolFilterDto(p, filter));
});
return pools;
}

private String escapeStringForCSV(Optional<String> value) {
if (!value.isPresent()) {
return "-";
}
return """ + value.get() + """;
}

private void generateHeadline(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
servers.get(0).getAttributes().forEach((k, v) -> {
builder.append(k);
builder.append(",");
});
servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
builder.append(k);
builder.append(",");
});

int size = servers.stream().mapToInt(m -> m.getAssignedPool().get().getMembers().size()).max().getAsInt();

Map<String, Optional<String>> map = servers.get(0).getAssignedPool().get().getMembers().get(0).getAttributes();
for (int i = 0; i < size; i++) {
for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
builder.append(entry.getKey());
builder.append(",");
}
}
builder.append("n");
}

@Override
public File getBaseTempDir() {
return new File(System.getProperty("java.io.tmpdir"));
}

@Override
public String getFileEnding() {
return ".csv";
}

@Override
public String getMediaType() {
return "text/csv";
}
}









share|improve this question









$endgroup$

















    0












    $begingroup$


    I am exporting a List of virtual servers to a CSV file. The users submits filters and the applications generates FilterDTOs containing a map of the attribute and the corresponding value. The idea was to 'undock' the filter and the simple DTOs that contained all the variables from the export, so the export does not need to know the concrete filter (actually he knows but only to let the FilterDTOs be generated). All values in the map are Optional<String>.
    Here is the exporter, the getFileEnding and getMediaType are given by the interface to dynamically handle the return of a byte in a REST-controller (I need the file ending to parse the file and the media type for setting the HTTP headers).
    I would appreciate any critic and tips



    public class FilteredCsvExporter implements Exporter {
    private ExportFilter filter;

    public FilteredCsvLbExporter(ExportFilter filter) {
    this.filter = filter;
    }

    @Override
    public void exportData() throws IOException, DocumentException {
    List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
    PrintWriter pw = new PrintWriter(new File(getBaseTempDir() + "/filteredExport.csv"));
    writeDataToFile(pw, new StringBuilder(), servers);
    }

    private void writeDataToFile(PrintWriter printWriter, StringBuilder builder, List<VirtualServerFilterDTO> servers) {
    generateHeadline(builder, servers);
    servers = servers.stream().filter(i -> i.getAttributes().get("Pool").isPresent() != false).collect(Collectors.toList());
    servers.forEach(server -> {
    addMapToCsv(builder, server.getAttributes());
    if (server.getAssignedPool().get().getAttributes().size() <= 0) {
    return;
    }
    addMapToCsv(builder, server.getAssignedPool().get().getAttributes());
    server.getAssignedPool().get().getMembers().forEach(member -> {
    addMapToCsv(builder, member.getAttributes());
    });
    builder.append("n");
    });
    builder.append("n");
    builder.append("n");
    builder.append("Pools that are not assigned to any virtual server");
    builder.append("n");
    appendPoolsWithoutServerHeader(builder, servers);
    builder.append("n");
    getPoolsWithoutServer().forEach(pool -> {
    addMapToCsv(builder, pool.getAttributes());
    builder.append("n");
    });
    printWriter.write(builder.toString());
    printWriter.close();
    System.out.println("Done");
    getPoolsWithoutServer();
    }

    private void appendPoolsWithoutServerHeader(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
    servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
    builder.append(k);
    builder.append(",");
    });
    }

    private void addMapToCsv(StringBuilder builder, Map<String, Optional<String>> map) {
    for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
    if (entry.getValue().orElse("-").contains(",")) {
    builder.append(escapeStringForCSV(entry.getValue()));
    builder.append(",");
    } else {
    builder.append(entry.getValue().orElse("-"));
    builder.append(",");
    }
    }
    }

    private List<PoolFilterDto> getPoolsWithoutServer() {
    List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
    List<PoolFilterDto> pools = new ArrayList<>();
    List<PoolDTO> poolDTOS = PoolRepository.getInstance().getPools().getPools();
    List<PoolDTO> temp = new ArrayList<>();

    for (int i = 0; i < servers.size(); i++) {
    for (int j = 0; j < poolDTOS.size(); j++) {
    VirtualServerFilterDTO server = servers.get(i);
    PoolDTO pool = poolDTOS.get(j);
    if (server.getAssignedPool().isPresent()) {
    if (server.getAssignedPool().get().getAttributes().size() > 0) {
    if (server.getAssignedPool().get().getAttributes().get("Full path").get().equalsIgnoreCase(pool.getFullPath())) {
    temp.add(pool);
    }
    }
    }
    }
    }
    poolDTOS.removeAll(temp);
    poolDTOS.forEach(p -> {
    pools.add(new PoolFilterDto(p, filter));
    });
    return pools;
    }

    private String escapeStringForCSV(Optional<String> value) {
    if (!value.isPresent()) {
    return "-";
    }
    return """ + value.get() + """;
    }

    private void generateHeadline(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
    servers.get(0).getAttributes().forEach((k, v) -> {
    builder.append(k);
    builder.append(",");
    });
    servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
    builder.append(k);
    builder.append(",");
    });

    int size = servers.stream().mapToInt(m -> m.getAssignedPool().get().getMembers().size()).max().getAsInt();

    Map<String, Optional<String>> map = servers.get(0).getAssignedPool().get().getMembers().get(0).getAttributes();
    for (int i = 0; i < size; i++) {
    for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
    builder.append(entry.getKey());
    builder.append(",");
    }
    }
    builder.append("n");
    }

    @Override
    public File getBaseTempDir() {
    return new File(System.getProperty("java.io.tmpdir"));
    }

    @Override
    public String getFileEnding() {
    return ".csv";
    }

    @Override
    public String getMediaType() {
    return "text/csv";
    }
    }









    share|improve this question









    $endgroup$















      0












      0








      0





      $begingroup$


      I am exporting a List of virtual servers to a CSV file. The users submits filters and the applications generates FilterDTOs containing a map of the attribute and the corresponding value. The idea was to 'undock' the filter and the simple DTOs that contained all the variables from the export, so the export does not need to know the concrete filter (actually he knows but only to let the FilterDTOs be generated). All values in the map are Optional<String>.
      Here is the exporter, the getFileEnding and getMediaType are given by the interface to dynamically handle the return of a byte in a REST-controller (I need the file ending to parse the file and the media type for setting the HTTP headers).
      I would appreciate any critic and tips



      public class FilteredCsvExporter implements Exporter {
      private ExportFilter filter;

      public FilteredCsvLbExporter(ExportFilter filter) {
      this.filter = filter;
      }

      @Override
      public void exportData() throws IOException, DocumentException {
      List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
      PrintWriter pw = new PrintWriter(new File(getBaseTempDir() + "/filteredExport.csv"));
      writeDataToFile(pw, new StringBuilder(), servers);
      }

      private void writeDataToFile(PrintWriter printWriter, StringBuilder builder, List<VirtualServerFilterDTO> servers) {
      generateHeadline(builder, servers);
      servers = servers.stream().filter(i -> i.getAttributes().get("Pool").isPresent() != false).collect(Collectors.toList());
      servers.forEach(server -> {
      addMapToCsv(builder, server.getAttributes());
      if (server.getAssignedPool().get().getAttributes().size() <= 0) {
      return;
      }
      addMapToCsv(builder, server.getAssignedPool().get().getAttributes());
      server.getAssignedPool().get().getMembers().forEach(member -> {
      addMapToCsv(builder, member.getAttributes());
      });
      builder.append("n");
      });
      builder.append("n");
      builder.append("n");
      builder.append("Pools that are not assigned to any virtual server");
      builder.append("n");
      appendPoolsWithoutServerHeader(builder, servers);
      builder.append("n");
      getPoolsWithoutServer().forEach(pool -> {
      addMapToCsv(builder, pool.getAttributes());
      builder.append("n");
      });
      printWriter.write(builder.toString());
      printWriter.close();
      System.out.println("Done");
      getPoolsWithoutServer();
      }

      private void appendPoolsWithoutServerHeader(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
      servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
      builder.append(k);
      builder.append(",");
      });
      }

      private void addMapToCsv(StringBuilder builder, Map<String, Optional<String>> map) {
      for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
      if (entry.getValue().orElse("-").contains(",")) {
      builder.append(escapeStringForCSV(entry.getValue()));
      builder.append(",");
      } else {
      builder.append(entry.getValue().orElse("-"));
      builder.append(",");
      }
      }
      }

      private List<PoolFilterDto> getPoolsWithoutServer() {
      List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
      List<PoolFilterDto> pools = new ArrayList<>();
      List<PoolDTO> poolDTOS = PoolRepository.getInstance().getPools().getPools();
      List<PoolDTO> temp = new ArrayList<>();

      for (int i = 0; i < servers.size(); i++) {
      for (int j = 0; j < poolDTOS.size(); j++) {
      VirtualServerFilterDTO server = servers.get(i);
      PoolDTO pool = poolDTOS.get(j);
      if (server.getAssignedPool().isPresent()) {
      if (server.getAssignedPool().get().getAttributes().size() > 0) {
      if (server.getAssignedPool().get().getAttributes().get("Full path").get().equalsIgnoreCase(pool.getFullPath())) {
      temp.add(pool);
      }
      }
      }
      }
      }
      poolDTOS.removeAll(temp);
      poolDTOS.forEach(p -> {
      pools.add(new PoolFilterDto(p, filter));
      });
      return pools;
      }

      private String escapeStringForCSV(Optional<String> value) {
      if (!value.isPresent()) {
      return "-";
      }
      return """ + value.get() + """;
      }

      private void generateHeadline(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
      servers.get(0).getAttributes().forEach((k, v) -> {
      builder.append(k);
      builder.append(",");
      });
      servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
      builder.append(k);
      builder.append(",");
      });

      int size = servers.stream().mapToInt(m -> m.getAssignedPool().get().getMembers().size()).max().getAsInt();

      Map<String, Optional<String>> map = servers.get(0).getAssignedPool().get().getMembers().get(0).getAttributes();
      for (int i = 0; i < size; i++) {
      for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
      builder.append(entry.getKey());
      builder.append(",");
      }
      }
      builder.append("n");
      }

      @Override
      public File getBaseTempDir() {
      return new File(System.getProperty("java.io.tmpdir"));
      }

      @Override
      public String getFileEnding() {
      return ".csv";
      }

      @Override
      public String getMediaType() {
      return "text/csv";
      }
      }









      share|improve this question









      $endgroup$




      I am exporting a List of virtual servers to a CSV file. The users submits filters and the applications generates FilterDTOs containing a map of the attribute and the corresponding value. The idea was to 'undock' the filter and the simple DTOs that contained all the variables from the export, so the export does not need to know the concrete filter (actually he knows but only to let the FilterDTOs be generated). All values in the map are Optional<String>.
      Here is the exporter, the getFileEnding and getMediaType are given by the interface to dynamically handle the return of a byte in a REST-controller (I need the file ending to parse the file and the media type for setting the HTTP headers).
      I would appreciate any critic and tips



      public class FilteredCsvExporter implements Exporter {
      private ExportFilter filter;

      public FilteredCsvLbExporter(ExportFilter filter) {
      this.filter = filter;
      }

      @Override
      public void exportData() throws IOException, DocumentException {
      List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
      PrintWriter pw = new PrintWriter(new File(getBaseTempDir() + "/filteredExport.csv"));
      writeDataToFile(pw, new StringBuilder(), servers);
      }

      private void writeDataToFile(PrintWriter printWriter, StringBuilder builder, List<VirtualServerFilterDTO> servers) {
      generateHeadline(builder, servers);
      servers = servers.stream().filter(i -> i.getAttributes().get("Pool").isPresent() != false).collect(Collectors.toList());
      servers.forEach(server -> {
      addMapToCsv(builder, server.getAttributes());
      if (server.getAssignedPool().get().getAttributes().size() <= 0) {
      return;
      }
      addMapToCsv(builder, server.getAssignedPool().get().getAttributes());
      server.getAssignedPool().get().getMembers().forEach(member -> {
      addMapToCsv(builder, member.getAttributes());
      });
      builder.append("n");
      });
      builder.append("n");
      builder.append("n");
      builder.append("Pools that are not assigned to any virtual server");
      builder.append("n");
      appendPoolsWithoutServerHeader(builder, servers);
      builder.append("n");
      getPoolsWithoutServer().forEach(pool -> {
      addMapToCsv(builder, pool.getAttributes());
      builder.append("n");
      });
      printWriter.write(builder.toString());
      printWriter.close();
      System.out.println("Done");
      getPoolsWithoutServer();
      }

      private void appendPoolsWithoutServerHeader(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
      servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
      builder.append(k);
      builder.append(",");
      });
      }

      private void addMapToCsv(StringBuilder builder, Map<String, Optional<String>> map) {
      for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
      if (entry.getValue().orElse("-").contains(",")) {
      builder.append(escapeStringForCSV(entry.getValue()));
      builder.append(",");
      } else {
      builder.append(entry.getValue().orElse("-"));
      builder.append(",");
      }
      }
      }

      private List<PoolFilterDto> getPoolsWithoutServer() {
      List<VirtualServerFilterDTO> servers = PoolRepository.getInstance().getVirtualServerFilterDTOs(filter);
      List<PoolFilterDto> pools = new ArrayList<>();
      List<PoolDTO> poolDTOS = PoolRepository.getInstance().getPools().getPools();
      List<PoolDTO> temp = new ArrayList<>();

      for (int i = 0; i < servers.size(); i++) {
      for (int j = 0; j < poolDTOS.size(); j++) {
      VirtualServerFilterDTO server = servers.get(i);
      PoolDTO pool = poolDTOS.get(j);
      if (server.getAssignedPool().isPresent()) {
      if (server.getAssignedPool().get().getAttributes().size() > 0) {
      if (server.getAssignedPool().get().getAttributes().get("Full path").get().equalsIgnoreCase(pool.getFullPath())) {
      temp.add(pool);
      }
      }
      }
      }
      }
      poolDTOS.removeAll(temp);
      poolDTOS.forEach(p -> {
      pools.add(new PoolFilterDto(p, filter));
      });
      return pools;
      }

      private String escapeStringForCSV(Optional<String> value) {
      if (!value.isPresent()) {
      return "-";
      }
      return """ + value.get() + """;
      }

      private void generateHeadline(StringBuilder builder, List<VirtualServerFilterDTO> servers) {
      servers.get(0).getAttributes().forEach((k, v) -> {
      builder.append(k);
      builder.append(",");
      });
      servers.get(0).getAssignedPool().get().getAttributes().forEach((k, v) -> {
      builder.append(k);
      builder.append(",");
      });

      int size = servers.stream().mapToInt(m -> m.getAssignedPool().get().getMembers().size()).max().getAsInt();

      Map<String, Optional<String>> map = servers.get(0).getAssignedPool().get().getMembers().get(0).getAttributes();
      for (int i = 0; i < size; i++) {
      for (Map.Entry<String, Optional<String>> entry : map.entrySet()) {
      builder.append(entry.getKey());
      builder.append(",");
      }
      }
      builder.append("n");
      }

      @Override
      public File getBaseTempDir() {
      return new File(System.getProperty("java.io.tmpdir"));
      }

      @Override
      public String getFileEnding() {
      return ".csv";
      }

      @Override
      public String getMediaType() {
      return "text/csv";
      }
      }






      java






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 18 mins ago









      ItFreakItFreak

      1283




      1283






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212516%2fjava-exporting-filtered-objects-to-csv%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212516%2fjava-exporting-filtered-objects-to-csv%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀