Manage show state of Modal component from inside of component
$begingroup$
I work on React apps on my spare time. I try to leverage the concept of HOCs and component reusing.
I have some components where I have a form, and I created a component for showing a modal, for instance to ask for user confirmation or show a message after an operation has been done. I reuse this modal on several forms. The modal component looks like this.
import React, { Component } from "react";
export default class ModalWindow extends Component {
state = { show: this.props.show };
hideModal = () => {
this.setState({ show: false });
};
render() {
const { id, title, children } = this.props;
return [
<div
key="modalDialog"
className={`modal ${!this.state.show ? "fade" : "show-modal"}`}
id={id}
tabIndex="-1"
role="dialog"
aria-hidden="true"
>
<div className="modal-dialog" role="document">
<div className="modal-content">
<div className="modal-header">
<h5 className="modal-title" id="exampleModalLiveLabel">
{title}
</h5>
<button
type="button"
className="close"
data-dismiss="modal"
aria-label="Close"
onClick={this.hideModal}
>
<span aria-hidden="true">×</span>
</button>
</div>
<div className="modal-body">
<p>{children}</p>
</div>
</div>
</div>
</div>
];
}
}
As you can see, I receive the show property from parent component. However, I would like to be able to close the modal window, but there's the dilemma. If I rely on the prop to show or hide the modal, I would need to pass a function from parent component to be triggered by the close button of the modal, and manage state of the modal on my parent component.
I can do that but I think it is too much effort and code in my parent component just to manage a simple modal component. On the other hand, I can try to manage show status of my modal inside of it (as it looks in my code sample) and just initializing with prop from parent when component is constructed, and in that way I can have the function to close it inside of it, but if that's the case, if I want to show the modal again from my parent component, prop is not being read again.
Another one would be just to rely on props, without managing state inside Modal component (a functional component) and having a function on close that alters the DOM by toggling the show CSS class, but i know that it is highly discouraged to alter DOM manually.
At the end, a lot of effort just for toggling a couple of CSS classes.
What would be the best way to achieve this? Am I making it too complex?
javascript react.js
edited 55 mins ago
Jamal♦
30.3k11117227
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I work on React apps on my spare time. I try to leverage the concept of HOCs and component reusing.
I have some components where I have a form, and I created a component for showing a modal, for instance to ask for user confirmation or show a message after an operation has been done. I reuse this modal on several forms. The modal component looks like this.
import React, { Component } from "react";
export default class ModalWindow extends Component {
state = { show: this.props.show };
hideModal = () => {
this.setState({ show: false });
};
render() {
const { id, title, children } = this.props;
return [
<div
key="modalDialog"
className={`modal ${!this.state.show ? "fade" : "show-modal"}`}
id={id}
tabIndex="-1"
role="dialog"
aria-hidden="true"
>
<div className="modal-dialog" role="document">
<div className="modal-content">
<div className="modal-header">
<h5 className="modal-title" id="exampleModalLiveLabel">
{title}
</h5>
<button
type="button"
className="close"
data-dismiss="modal"
aria-label="Close"
onClick={this.hideModal}
>
<span aria-hidden="true">×</span>
</button>
</div>
<div className="modal-body">
<p>{children}</p>
</div>
</div>
</div>
</div>
];
}
}
As you can see, I receive the show property from parent component. However, I would like to be able to close the modal window, but there's the dilemma. If I rely on the prop to show or hide the modal, I would need to pass a function from parent component to be triggered by the close button of the modal, and manage state of the modal on my parent component.
I can do that but I think it is too much effort and code in my parent component just to manage a simple modal component. On the other hand, I can try to manage show status of my modal inside of it (as it looks in my code sample) and just initializing with prop from parent when component is constructed, and in that way I can have the function to close it inside of it, but if that's the case, if I want to show the modal again from my parent component, prop is not being read again.
Another one would be just to rely on props, without managing state inside Modal component (a functional component) and having a function on close that alters the DOM by toggling the show CSS class, but i know that it is highly discouraged to alter DOM manually.
At the end, a lot of effort just for toggling a couple of CSS classes.
What would be the best way to achieve this? Am I making it too complex?
javascript react.js
edited 55 mins ago
Jamal♦
30.3k11117227
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I work on React apps on my spare time. I try to leverage the concept of HOCs and component reusing.
I have some components where I have a form, and I created a component for showing a modal, for instance to ask for user confirmation or show a message after an operation has been done. I reuse this modal on several forms. The modal component looks like this.
import React, { Component } from "react";
export default class ModalWindow extends Component {
state = { show: this.props.show };
hideModal = () => {
this.setState({ show: false });
};
render() {
const { id, title, children } = this.props;
return [
<div
key="modalDialog"
className={`modal ${!this.state.show ? "fade" : "show-modal"}`}
id={id}
tabIndex="-1"
role="dialog"
aria-hidden="true"
>
<div className="modal-dialog" role="document">
<div className="modal-content">
<div className="modal-header">
<h5 className="modal-title" id="exampleModalLiveLabel">
{title}
</h5>
<button
type="button"
className="close"
data-dismiss="modal"
aria-label="Close"
onClick={this.hideModal}
>
<span aria-hidden="true">×</span>
</button>
</div>
<div className="modal-body">
<p>{children}</p>
</div>
</div>
</div>
</div>
];
}
}
As you can see, I receive the show property from parent component. However, I would like to be able to close the modal window, but there's the dilemma. If I rely on the prop to show or hide the modal, I would need to pass a function from parent component to be triggered by the close button of the modal, and manage state of the modal on my parent component.
I can do that but I think it is too much effort and code in my parent component just to manage a simple modal component. On the other hand, I can try to manage show status of my modal inside of it (as it looks in my code sample) and just initializing with prop from parent when component is constructed, and in that way I can have the function to close it inside of it, but if that's the case, if I want to show the modal again from my parent component, prop is not being read again.
Another one would be just to rely on props, without managing state inside Modal component (a functional component) and having a function on close that alters the DOM by toggling the show CSS class, but i know that it is highly discouraged to alter DOM manually.
At the end, a lot of effort just for toggling a couple of CSS classes.
What would be the best way to achieve this? Am I making it too complex?
javascript react.js
edited 55 mins ago
Jamal♦
30.3k11117227
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I work on React apps on my spare time. I try to leverage the concept of HOCs and component reusing.
I have some components where I have a form, and I created a component for showing a modal, for instance to ask for user confirmation or show a message after an operation has been done. I reuse this modal on several forms. The modal component looks like this.
import React, { Component } from "react";
export default class ModalWindow extends Component {
state = { show: this.props.show };
hideModal = () => {
this.setState({ show: false });
};
render() {
const { id, title, children } = this.props;
return [
<div
key="modalDialog"
className={`modal ${!this.state.show ? "fade" : "show-modal"}`}
id={id}
tabIndex="-1"
role="dialog"
aria-hidden="true"
>
<div className="modal-dialog" role="document">
<div className="modal-content">
<div className="modal-header">
<h5 className="modal-title" id="exampleModalLiveLabel">
{title}
</h5>
<button
type="button"
className="close"
data-dismiss="modal"
aria-label="Close"
onClick={this.hideModal}
>
<span aria-hidden="true">×</span>
</button>
</div>
<div className="modal-body">
<p>{children}</p>
</div>
</div>
</div>
</div>
];
}
}
As you can see, I receive the show property from parent component. However, I would like to be able to close the modal window, but there's the dilemma. If I rely on the prop to show or hide the modal, I would need to pass a function from parent component to be triggered by the close button of the modal, and manage state of the modal on my parent component.
I can do that but I think it is too much effort and code in my parent component just to manage a simple modal component. On the other hand, I can try to manage show status of my modal inside of it (as it looks in my code sample) and just initializing with prop from parent when component is constructed, and in that way I can have the function to close it inside of it, but if that's the case, if I want to show the modal again from my parent component, prop is not being read again.
Another one would be just to rely on props, without managing state inside Modal component (a functional component) and having a function on close that alters the DOM by toggling the show CSS class, but i know that it is highly discouraged to alter DOM manually.
At the end, a lot of effort just for toggling a couple of CSS classes.
What would be the best way to achieve this? Am I making it too complex?
javascript react.js
javascript react.js
edited 55 mins ago
Jamal♦
30.3k11117227
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 55 mins ago
Jamal♦
30.3k11117227
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
edited 55 mins ago
Jamal♦
30.3k11117227
edited 55 mins ago
Jamal♦
30.3k11117227
edited 55 mins ago
Jamal♦
30.3k11117227
30.3k11117227
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
asked 15 hours ago
Oscar CalderonOscar Calderon
1011
1011
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Oscar Calderon is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Oscar Calderon is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212465%2fmanage-show-state-of-modal-component-from-inside-of-component%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Oscar Calderon is a new contributor. Be nice, and check out our Code of Conduct.
Oscar Calderon is a new contributor. Be nice, and check out our Code of Conduct.
Oscar Calderon is a new contributor. Be nice, and check out our Code of Conduct.
Oscar Calderon is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212465%2fmanage-show-state-of-modal-component-from-inside-of-component%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
