Mutex implementation using Windows APC












0












$begingroup$


I just wrote this now and didn't test it much. This isn't a replacement for std::mutex , but for something like fun. I may develop it to make it shared across processes by storing the counters in a shared memory. I don't know whether it's more efficient than the standard mutex or not. Also, the APC callbacks could be used to implement condition variable or promise and future.



void WINAPI wake_exclusive_locked_thread(ULONG_PTR inst) 
{
if (inst)
CloseHandle((void*)inst);
}

class Mutex {
volatile long long exclusive_locked;
volatile unsigned long waiter_id;
volatile long long shared_lock;
public :
Mutex(const Mutex&) = delete;
Mutex(Mutex&&) = delete;
Mutex& operator=(const Mutex&) = delete;
Mutex& operator=(Mutex&&) = delete;

Mutex() : exclusive_locked(-1), waiter_id(0), shared_lock(0)
{
}

void lock()
{
if (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock,0))
{
unsigned long this_tid = cpp::this_thread::get_id();
unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
InterlockedDecrement64(&exclusive_locked);

while (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock, 0)) // if the lock is free the inc will return 0
{
InterlockedDecrement64(&exclusive_locked);
SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
}

InterlockedExchange(&waiter_id, old_waiter_id); // reback the old thread , may be null
}

// the thread now owns the lock
}

void unlock()
{
unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
InterlockedDecrement64(&exclusive_locked);
void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
}

void lock_shared()
{

if (InterlockedAdd64(&exclusive_locked,0) > -1)
{
unsigned long this_tid = cpp::this_thread::get_id();
unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
while (InterlockedAdd64(&exclusive_locked, 0) > -1)
{
SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, old_waiter_id); // notify the rest of the thrreads , if there is a write locker read lockers won't pass
QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
}
}
InterlockedIncrement64(&shared_lock);
}

void unlock_shared()
{
unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
InterlockedDecrement64(&shared_lock);
void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
}

};









share|improve this question









New contributor




dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    I just wrote this now and didn't test it much. This isn't a replacement for std::mutex , but for something like fun. I may develop it to make it shared across processes by storing the counters in a shared memory. I don't know whether it's more efficient than the standard mutex or not. Also, the APC callbacks could be used to implement condition variable or promise and future.



    void WINAPI wake_exclusive_locked_thread(ULONG_PTR inst) 
    {
    if (inst)
    CloseHandle((void*)inst);
    }

    class Mutex {
    volatile long long exclusive_locked;
    volatile unsigned long waiter_id;
    volatile long long shared_lock;
    public :
    Mutex(const Mutex&) = delete;
    Mutex(Mutex&&) = delete;
    Mutex& operator=(const Mutex&) = delete;
    Mutex& operator=(Mutex&&) = delete;

    Mutex() : exclusive_locked(-1), waiter_id(0), shared_lock(0)
    {
    }

    void lock()
    {
    if (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock,0))
    {
    unsigned long this_tid = cpp::this_thread::get_id();
    unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
    InterlockedDecrement64(&exclusive_locked);

    while (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock, 0)) // if the lock is free the inc will return 0
    {
    InterlockedDecrement64(&exclusive_locked);
    SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
    }

    InterlockedExchange(&waiter_id, old_waiter_id); // reback the old thread , may be null
    }

    // the thread now owns the lock
    }

    void unlock()
    {
    unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
    InterlockedDecrement64(&exclusive_locked);
    void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
    QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
    }

    void lock_shared()
    {

    if (InterlockedAdd64(&exclusive_locked,0) > -1)
    {
    unsigned long this_tid = cpp::this_thread::get_id();
    unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
    while (InterlockedAdd64(&exclusive_locked, 0) > -1)
    {
    SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
    void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, old_waiter_id); // notify the rest of the thrreads , if there is a write locker read lockers won't pass
    QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
    }
    }
    InterlockedIncrement64(&shared_lock);
    }

    void unlock_shared()
    {
    unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
    InterlockedDecrement64(&shared_lock);
    void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
    QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
    }

    };









    share|improve this question









    New contributor




    dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      I just wrote this now and didn't test it much. This isn't a replacement for std::mutex , but for something like fun. I may develop it to make it shared across processes by storing the counters in a shared memory. I don't know whether it's more efficient than the standard mutex or not. Also, the APC callbacks could be used to implement condition variable or promise and future.



      void WINAPI wake_exclusive_locked_thread(ULONG_PTR inst) 
      {
      if (inst)
      CloseHandle((void*)inst);
      }

      class Mutex {
      volatile long long exclusive_locked;
      volatile unsigned long waiter_id;
      volatile long long shared_lock;
      public :
      Mutex(const Mutex&) = delete;
      Mutex(Mutex&&) = delete;
      Mutex& operator=(const Mutex&) = delete;
      Mutex& operator=(Mutex&&) = delete;

      Mutex() : exclusive_locked(-1), waiter_id(0), shared_lock(0)
      {
      }

      void lock()
      {
      if (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock,0))
      {
      unsigned long this_tid = cpp::this_thread::get_id();
      unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
      InterlockedDecrement64(&exclusive_locked);

      while (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock, 0)) // if the lock is free the inc will return 0
      {
      InterlockedDecrement64(&exclusive_locked);
      SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
      }

      InterlockedExchange(&waiter_id, old_waiter_id); // reback the old thread , may be null
      }

      // the thread now owns the lock
      }

      void unlock()
      {
      unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
      InterlockedDecrement64(&exclusive_locked);
      void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
      QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
      }

      void lock_shared()
      {

      if (InterlockedAdd64(&exclusive_locked,0) > -1)
      {
      unsigned long this_tid = cpp::this_thread::get_id();
      unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
      while (InterlockedAdd64(&exclusive_locked, 0) > -1)
      {
      SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
      void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, old_waiter_id); // notify the rest of the thrreads , if there is a write locker read lockers won't pass
      QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
      }
      }
      InterlockedIncrement64(&shared_lock);
      }

      void unlock_shared()
      {
      unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
      InterlockedDecrement64(&shared_lock);
      void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
      QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
      }

      };









      share|improve this question









      New contributor




      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I just wrote this now and didn't test it much. This isn't a replacement for std::mutex , but for something like fun. I may develop it to make it shared across processes by storing the counters in a shared memory. I don't know whether it's more efficient than the standard mutex or not. Also, the APC callbacks could be used to implement condition variable or promise and future.



      void WINAPI wake_exclusive_locked_thread(ULONG_PTR inst) 
      {
      if (inst)
      CloseHandle((void*)inst);
      }

      class Mutex {
      volatile long long exclusive_locked;
      volatile unsigned long waiter_id;
      volatile long long shared_lock;
      public :
      Mutex(const Mutex&) = delete;
      Mutex(Mutex&&) = delete;
      Mutex& operator=(const Mutex&) = delete;
      Mutex& operator=(Mutex&&) = delete;

      Mutex() : exclusive_locked(-1), waiter_id(0), shared_lock(0)
      {
      }

      void lock()
      {
      if (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock,0))
      {
      unsigned long this_tid = cpp::this_thread::get_id();
      unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
      InterlockedDecrement64(&exclusive_locked);

      while (InterlockedIncrement64(&exclusive_locked) || InterlockedAdd64(&shared_lock, 0)) // if the lock is free the inc will return 0
      {
      InterlockedDecrement64(&exclusive_locked);
      SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
      }

      InterlockedExchange(&waiter_id, old_waiter_id); // reback the old thread , may be null
      }

      // the thread now owns the lock
      }

      void unlock()
      {
      unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
      InterlockedDecrement64(&exclusive_locked);
      void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
      QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
      }

      void lock_shared()
      {

      if (InterlockedAdd64(&exclusive_locked,0) > -1)
      {
      unsigned long this_tid = cpp::this_thread::get_id();
      unsigned long old_waiter_id = InterlockedExchange(&waiter_id, this_tid); // put this thread at the front
      while (InterlockedAdd64(&exclusive_locked, 0) > -1)
      {
      SleepEx(INFINITE, TRUE); // wait for the lock owner to unlock
      void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, old_waiter_id); // notify the rest of the thrreads , if there is a write locker read lockers won't pass
      QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
      }
      }
      InterlockedIncrement64(&shared_lock);
      }

      void unlock_shared()
      {
      unsigned long current_waiter_id = InterlockedAdd((volatile LONG*)&waiter_id, 0);
      InterlockedDecrement64(&shared_lock);
      void *handle = OpenThread(THREAD_ALL_ACCESS, FALSE, current_waiter_id);
      QueueUserAPC(wake_exclusive_locked_thread, handle, (ULONG_PTR)handle);
      }

      };






      c++ winapi






      share|improve this question









      New contributor




      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 4 hours ago









      Jamal

      30.3k11119227




      30.3k11119227






      New contributor




      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 9 hours ago









      dev65dev65

      1




      1




      New contributor




      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      dev65 is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          dev65 is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214065%2fmutex-implementation-using-windows-apc%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          dev65 is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          dev65 is a new contributor. Be nice, and check out our Code of Conduct.













          dev65 is a new contributor. Be nice, and check out our Code of Conduct.












          dev65 is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214065%2fmutex-implementation-using-windows-apc%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀