Removing trailing whitespace from input lines
$begingroup$
I'm going through the K&R C book (coming from Python) and am on exercise 1-18, which states:
Write a program to remove trailing blanks and tabs from each line of input, and to delete entirely blank lines.
I wasn't able to find another solution online that looks quite like mine so I am questioning whether it is truly correct, even though it appears to work on anything I throw at it. I let an ending n be whitespace, removed it and added a general newline to each printed output, but I'm not sure if that is cheating.
If there are any bad practices (or bugs in the code) for standard C please let me know.
#include <stdio.h>
#define MAXLINE 1000
int getli(char line, int maxline);
main() {
int len;
int i;
char line[MAXLINE];
while ((len = getli(line, MAXLINE)) > 0) {
i = len-1;
/* replace any trailing whitespace character with null character */
while (line[i] == 'n' || line[i] == 't' || line[i] == ' ') {
line[i] = '';
i--;
}
if (line[0] == '') {
printf("Blank linen");
}
else printf("%sn", line);
}
return 0;
}
/* function to capture input line as char array */
int getli(char s, int lim) {
int i, c;
for (i=0; i<lim-1 && (c=getchar()) != EOF && c != 'n'; i++) {
s[i] = c;
}
if (c == 'n') {
s[i] = c;
i++;
}
s[i] = '';
return i;
}
algorithm c
edited 4 hours ago
Jamal♦
30.3k11119227
asked 4 hours ago
CamCam
161
$endgroup$
add a comment |
$begingroup$
I'm going through the K&R C book (coming from Python) and am on exercise 1-18, which states:
Write a program to remove trailing blanks and tabs from each line of input, and to delete entirely blank lines.
I wasn't able to find another solution online that looks quite like mine so I am questioning whether it is truly correct, even though it appears to work on anything I throw at it. I let an ending n be whitespace, removed it and added a general newline to each printed output, but I'm not sure if that is cheating.
If there are any bad practices (or bugs in the code) for standard C please let me know.
#include <stdio.h>
#define MAXLINE 1000
int getli(char line, int maxline);
main() {
int len;
int i;
char line[MAXLINE];
while ((len = getli(line, MAXLINE)) > 0) {
i = len-1;
/* replace any trailing whitespace character with null character */
while (line[i] == 'n' || line[i] == 't' || line[i] == ' ') {
line[i] = '';
i--;
}
if (line[0] == '') {
printf("Blank linen");
}
else printf("%sn", line);
}
return 0;
}
/* function to capture input line as char array */
int getli(char s, int lim) {
int i, c;
for (i=0; i<lim-1 && (c=getchar()) != EOF && c != 'n'; i++) {
s[i] = c;
}
if (c == 'n') {
s[i] = c;
i++;
}
s[i] = '';
return i;
}
algorithm c
edited 4 hours ago
Jamal♦
30.3k11119227
asked 4 hours ago
CamCam
161
$endgroup$
add a comment |
$begingroup$
I'm going through the K&R C book (coming from Python) and am on exercise 1-18, which states:
Write a program to remove trailing blanks and tabs from each line of input, and to delete entirely blank lines.
I wasn't able to find another solution online that looks quite like mine so I am questioning whether it is truly correct, even though it appears to work on anything I throw at it. I let an ending n be whitespace, removed it and added a general newline to each printed output, but I'm not sure if that is cheating.
If there are any bad practices (or bugs in the code) for standard C please let me know.
#include <stdio.h>
#define MAXLINE 1000
int getli(char line, int maxline);
main() {
int len;
int i;
char line[MAXLINE];
while ((len = getli(line, MAXLINE)) > 0) {
i = len-1;
/* replace any trailing whitespace character with null character */
while (line[i] == 'n' || line[i] == 't' || line[i] == ' ') {
line[i] = '';
i--;
}
if (line[0] == '') {
printf("Blank linen");
}
else printf("%sn", line);
}
return 0;
}
/* function to capture input line as char array */
int getli(char s, int lim) {
int i, c;
for (i=0; i<lim-1 && (c=getchar()) != EOF && c != 'n'; i++) {
s[i] = c;
}
if (c == 'n') {
s[i] = c;
i++;
}
s[i] = '';
return i;
}
algorithm c
edited 4 hours ago
Jamal♦
30.3k11119227
asked 4 hours ago
CamCam
161
$endgroup$
I'm going through the K&R C book (coming from Python) and am on exercise 1-18, which states:
Write a program to remove trailing blanks and tabs from each line of input, and to delete entirely blank lines.
I wasn't able to find another solution online that looks quite like mine so I am questioning whether it is truly correct, even though it appears to work on anything I throw at it. I let an ending n be whitespace, removed it and added a general newline to each printed output, but I'm not sure if that is cheating.
If there are any bad practices (or bugs in the code) for standard C please let me know.
#include <stdio.h>
#define MAXLINE 1000
int getli(char line, int maxline);
main() {
int len;
int i;
char line[MAXLINE];
while ((len = getli(line, MAXLINE)) > 0) {
i = len-1;
/* replace any trailing whitespace character with null character */
while (line[i] == 'n' || line[i] == 't' || line[i] == ' ') {
line[i] = '';
i--;
}
if (line[0] == '') {
printf("Blank linen");
}
else printf("%sn", line);
}
return 0;
}
/* function to capture input line as char array */
int getli(char s, int lim) {
int i, c;
for (i=0; i<lim-1 && (c=getchar()) != EOF && c != 'n'; i++) {
s[i] = c;
}
if (c == 'n') {
s[i] = c;
i++;
}
s[i] = '';
return i;
}
algorithm c
algorithm c
edited 4 hours ago
Jamal♦
30.3k11119227
asked 4 hours ago
CamCam
161
edited 4 hours ago
Jamal♦
30.3k11119227
asked 4 hours ago
CamCam
161
edited 4 hours ago
Jamal♦
30.3k11119227
edited 4 hours ago
Jamal♦
30.3k11119227
edited 4 hours ago
Jamal♦
30.3k11119227
30.3k11119227
asked 4 hours ago
CamCam
161
asked 4 hours ago
CamCam
161
asked 4 hours ago
CamCam
161
161
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214086%2fremoving-trailing-whitespace-from-input-lines%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f214086%2fremoving-trailing-whitespace-from-input-lines%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
