Read JSON files, basic calculations and write over another JSON file
-1
$begingroup$
Class SectorController calculates weight coefficients for sector performances in equity exchange markets using minute data from an API (for instance, if a group of equities are up in the past 5 minutes, then coefficient is positive, if not, is negative, ranging from -1 to +1). Most of calculations are based on other scripts, which is not necessary for this review.
Would you be so kind and review this class and help me to make it faster, if possible?
Script
class SectorController
{
/**
*
* @var a string of iextrading base URL
*/
const BASE_URL = "https://api.iextrading.com/1.0/";
/**
*
* @var a string of target path and query
*/
const TARGET_QUERY = "stock/market/batch?symbols=";
/**
*
* @var a string for backend path for every sector
*/
const EACH_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir-";
/**
*
* @var a string for backend path for index sector
*/
const INDEX_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir/";
/**
*
* @var a string for live data path
*/
const LIVE_DATA_DIR = "/../../../public_html/dir/dir/";
function __construct()
{
echo "YAAAY! " . __METHOD__ . " success 💚n";
return true;
}
public static function getSectors(){
$baseUrl=self::BASE_URL.self::TARGET_QUERY;
$currentTime = date("Y-m-d-H-i-s");
$permission = 0755;
$indexData = array( "Overall" => array("sector_weight" => 1, "sector_coefficient" => 5,
$sectorInfos=SectorController::iexSectorParams();
foreach ($sectorInfos as $a => $sectorInfo) {
$sectorUrl = $baseUrl . implode(",", array_keys($sectorInfo["selected_tickers"])) . "&types=quote&range=1m";
$rawSectorJson = file_get_contents($sectorUrl);
$rawSectorArray = json_decode($rawSectorJson, true);
// Write the raw file
$rawSectorDir = __DIR__ . self::EACH_SECTOR_DIR_PREFIX . $sectorInfo["directory"];
if (!is_dir($rawSectorDir)) {
mkdir($rawSectorDir, $permission, true);
}
$rawSectorFile = $rawSectorDir . "/" . $currentTime . ".json";
$fp = fopen($rawSectorFile, "a+");
fwrite($fp, $rawSectorJson);
fclose($fp);
// Calculate the real-time index
$indexValue = 0;
foreach ($rawSectorArray as $ticker => $tickerStats) {
if (isset($sectorInfo["selected_tickers"][$ticker], $tickerStats["quote"], $tickerStats["quote"]["extendedChangePercent"], $tickerStats["quote"]["changePercent"], $tickerStats["quote"]["ytdChange"])) {
$changeAmount = ($tickerStats["quote"]["extendedChangePercent"] + $tickerStats["quote"]["changePercent"] + $tickerStats["quote"]["ytdChange"])/200;
$indexValue += $sectorInfo["sector_weight"] * $sectorInfo["selected_tickers"][$ticker] * $changeAmount;
}
}
$indexData[$sectorInfo["sector"]] = array("sector_weight" => $sectorInfo["sector_weight"], "sector_coefficient" => 5,
$indexData["Overall"]["sector_value"] += $indexData[$sectorInfo["sector"]]["sector_value"];
}
// Calculate the index factor for better visibility between -1 and +1
$frontIndexData = array();
foreach ($indexData as $sectorName => $sectorIndexData) {
$indexSign = $sectorIndexData["sector_value"];
if ($indexSign < 0) {
$indexSign = - $indexSign;
}
$indexFactor = 1;
for ($i=0; $i <= 10; $i++) {
$indexFactor = pow(10, $i);
if (($indexFactor * $indexSign) > 1) {
$indexFactor = pow(10, $i - 1);
break;
}
}
$frontIndexData[$sectorName] = $sectorIndexData["sector_weight"] * $sectorIndexData["sector_coefficient"] * $sectorIndexData["sector_value"] * $indexFactor;
}
// Write the index file
$indexSectorDir = __DIR__ . self::INDEX_SECTOR_DIR_PREFIX;
if (!is_dir($indexSectorDir)) {mkdir($indexSectorDir, $permission, true);}
$indexSectorFile = $indexSectorDir . $currentTime . ".json";
$indexSectorJson = json_encode($frontIndexData, JSON_FORCE_OBJECT);
$fp = fopen($indexSectorFile, "a+");
fwrite($fp, $indexSectorJson);
fclose($fp);
$sectorDir = __DIR__ . self::LIVE_DATA_DIR;
if (!is_dir($sectorDir)) {mkdir($sectorDir, $permission, true);} // if data directory did not exist
// if text file did not exist
if (!file_exists($sectorDir . "text.txt")){
$handle=fopen($sectorDir . "text.txt", "wb");
fwrite($handle, "d");
fclose($handle);
}
$sectorCoefFile = $sectorDir . "text.txt";
copy($indexSectorFile, $sectorCoefFile);
echo "YAAAY! " . __METHOD__ . " updated sector coefficients successfully 💚!n";
return $frontIndexData;
}
public static function iexSectorParams(){
$sectorInfos = array(
array(
"sector" => "IT",
"directory" => "information-technology",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"AAPL" => 0.05,
"AMZN" => 0.05,
"GOOGL" => 0.05,
"IBM" => 0.05
"MSFT" => 0.05
)
),
array(
"sector" => "Telecommunication",
"directory" => "telecommunication-services",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"VZ" => 0.05,
"CSCO" => 0.05,
"CMCSA" => 0.05,
"T" => 0.05,
"CTL" => 0.05
)
),
array(
"sector" => "Finance",
"directory" => "financial-services",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"JPM" => 0.05,
"GS" => 0.05,
"V" => 0.05,
"BAC" => 0.05,
"AXP" => 0.05
)
),
array(
"sector" => "Energy",
"directory" => "energy",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"CVX" => 0.05,
"XOM" => 0.05,
"APA" => 0.05,
"COP" => 0.05,
)
),
array(
"sector" => "Industrials",
"directory" => "industrials",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CAT" => 0.05,
"FLR" => 0.05,
"GE" => 0.05,
"JEC" => 0.05,
)
),
array(
"sector" => "Materials and Chemicals",
"directory" => "materials-and-chemicals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DWDP" => 0.05,
"APD" => 0.05,
"EMN" => 0.05,
"ECL" => 0.05,
"FMC" => 0.05
)
),
array(
"sector" => "Utilities",
"directory" => "utilities",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PPL" => 0.05,
"PCG" => 0.05,
"SO" => 0.05,
"WEC" => 0.05,
)
),
array(
"sector" => "Consumer Discretionary",
"directory" => "consumer-discretionary",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DIS" => 0.05,
"HD" => 0.05,
"BBY" => 0.05,
"CBS" => 0.05,
"CMG" => 0.05
)
),
array(
"sector" => "Consumer Staples",
"directory" => "consumer-staples",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PEP" => 0.05,
"PM" => 0.05,
"PG" => 0.05,
"MNST" => 0.05,
"TSN" => 0.05
)
),
array(
"sector" => "Defense",
"directory" => "defense-and-aerospace",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"BA" => 0.05,
"LMT" => 0.05,
"UTX" => 0.05,
"NOC" => 0.05,
"HON" => 0.05
)
),
array(
"sector" => "Health",
"directory" => "health-care-and-pharmaceuticals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"UNH" => 0.05,
"JNJ" => 0.05,
"PFE" => 0.05,
"UHS" => 0.05,
"AET" => 0.05
"RMD" => 0.05
)
),
array(
"sector" => "Real Estate",
"directory" => "real-estate",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CCI" => 0.05,
"AMT" => 0.05,
"AVB" => 0.05,
"HCP" => 0.05,
"RCL" => 0.05
"HST" => 0.05
)
)
);
return $sectorInfos;
}
function __destruct()
{
echo "YAAAY! " . __METHOD__ . " success! 💚 n";
return true;
}
}
Output (text.txt)
{"Overall":0.05,"IT":0.05,"Telecommunication":0.05,"Finance":0.05,"Energy":0.05,"Industrials":0.05,"Materials
and Chemicals":0.05,"Utilities":0.05,"Consumer
Discretionary":0.05,"Consumer
Staples":0.05,"Defense":0.05,"Health":0.05,"Real Estate":0.05}
performance beginner php json api
edited 28 mins ago
Jamal♦
30.4k11121227
asked yesterday
EmmaEmma
177112
$endgroup$
add a comment |
-1
$begingroup$
Class SectorController calculates weight coefficients for sector performances in equity exchange markets using minute data from an API (for instance, if a group of equities are up in the past 5 minutes, then coefficient is positive, if not, is negative, ranging from -1 to +1). Most of calculations are based on other scripts, which is not necessary for this review.
Would you be so kind and review this class and help me to make it faster, if possible?
Script
class SectorController
{
/**
*
* @var a string of iextrading base URL
*/
const BASE_URL = "https://api.iextrading.com/1.0/";
/**
*
* @var a string of target path and query
*/
const TARGET_QUERY = "stock/market/batch?symbols=";
/**
*
* @var a string for backend path for every sector
*/
const EACH_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir-";
/**
*
* @var a string for backend path for index sector
*/
const INDEX_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir/";
/**
*
* @var a string for live data path
*/
const LIVE_DATA_DIR = "/../../../public_html/dir/dir/";
function __construct()
{
echo "YAAAY! " . __METHOD__ . " success 💚n";
return true;
}
public static function getSectors(){
$baseUrl=self::BASE_URL.self::TARGET_QUERY;
$currentTime = date("Y-m-d-H-i-s");
$permission = 0755;
$indexData = array( "Overall" => array("sector_weight" => 1, "sector_coefficient" => 5,
$sectorInfos=SectorController::iexSectorParams();
foreach ($sectorInfos as $a => $sectorInfo) {
$sectorUrl = $baseUrl . implode(",", array_keys($sectorInfo["selected_tickers"])) . "&types=quote&range=1m";
$rawSectorJson = file_get_contents($sectorUrl);
$rawSectorArray = json_decode($rawSectorJson, true);
// Write the raw file
$rawSectorDir = __DIR__ . self::EACH_SECTOR_DIR_PREFIX . $sectorInfo["directory"];
if (!is_dir($rawSectorDir)) {
mkdir($rawSectorDir, $permission, true);
}
$rawSectorFile = $rawSectorDir . "/" . $currentTime . ".json";
$fp = fopen($rawSectorFile, "a+");
fwrite($fp, $rawSectorJson);
fclose($fp);
// Calculate the real-time index
$indexValue = 0;
foreach ($rawSectorArray as $ticker => $tickerStats) {
if (isset($sectorInfo["selected_tickers"][$ticker], $tickerStats["quote"], $tickerStats["quote"]["extendedChangePercent"], $tickerStats["quote"]["changePercent"], $tickerStats["quote"]["ytdChange"])) {
$changeAmount = ($tickerStats["quote"]["extendedChangePercent"] + $tickerStats["quote"]["changePercent"] + $tickerStats["quote"]["ytdChange"])/200;
$indexValue += $sectorInfo["sector_weight"] * $sectorInfo["selected_tickers"][$ticker] * $changeAmount;
}
}
$indexData[$sectorInfo["sector"]] = array("sector_weight" => $sectorInfo["sector_weight"], "sector_coefficient" => 5,
$indexData["Overall"]["sector_value"] += $indexData[$sectorInfo["sector"]]["sector_value"];
}
// Calculate the index factor for better visibility between -1 and +1
$frontIndexData = array();
foreach ($indexData as $sectorName => $sectorIndexData) {
$indexSign = $sectorIndexData["sector_value"];
if ($indexSign < 0) {
$indexSign = - $indexSign;
}
$indexFactor = 1;
for ($i=0; $i <= 10; $i++) {
$indexFactor = pow(10, $i);
if (($indexFactor * $indexSign) > 1) {
$indexFactor = pow(10, $i - 1);
break;
}
}
$frontIndexData[$sectorName] = $sectorIndexData["sector_weight"] * $sectorIndexData["sector_coefficient"] * $sectorIndexData["sector_value"] * $indexFactor;
}
// Write the index file
$indexSectorDir = __DIR__ . self::INDEX_SECTOR_DIR_PREFIX;
if (!is_dir($indexSectorDir)) {mkdir($indexSectorDir, $permission, true);}
$indexSectorFile = $indexSectorDir . $currentTime . ".json";
$indexSectorJson = json_encode($frontIndexData, JSON_FORCE_OBJECT);
$fp = fopen($indexSectorFile, "a+");
fwrite($fp, $indexSectorJson);
fclose($fp);
$sectorDir = __DIR__ . self::LIVE_DATA_DIR;
if (!is_dir($sectorDir)) {mkdir($sectorDir, $permission, true);} // if data directory did not exist
// if text file did not exist
if (!file_exists($sectorDir . "text.txt")){
$handle=fopen($sectorDir . "text.txt", "wb");
fwrite($handle, "d");
fclose($handle);
}
$sectorCoefFile = $sectorDir . "text.txt";
copy($indexSectorFile, $sectorCoefFile);
echo "YAAAY! " . __METHOD__ . " updated sector coefficients successfully 💚!n";
return $frontIndexData;
}
public static function iexSectorParams(){
$sectorInfos = array(
array(
"sector" => "IT",
"directory" => "information-technology",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"AAPL" => 0.05,
"AMZN" => 0.05,
"GOOGL" => 0.05,
"IBM" => 0.05
"MSFT" => 0.05
)
),
array(
"sector" => "Telecommunication",
"directory" => "telecommunication-services",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"VZ" => 0.05,
"CSCO" => 0.05,
"CMCSA" => 0.05,
"T" => 0.05,
"CTL" => 0.05
)
),
array(
"sector" => "Finance",
"directory" => "financial-services",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"JPM" => 0.05,
"GS" => 0.05,
"V" => 0.05,
"BAC" => 0.05,
"AXP" => 0.05
)
),
array(
"sector" => "Energy",
"directory" => "energy",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"CVX" => 0.05,
"XOM" => 0.05,
"APA" => 0.05,
"COP" => 0.05,
)
),
array(
"sector" => "Industrials",
"directory" => "industrials",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CAT" => 0.05,
"FLR" => 0.05,
"GE" => 0.05,
"JEC" => 0.05,
)
),
array(
"sector" => "Materials and Chemicals",
"directory" => "materials-and-chemicals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DWDP" => 0.05,
"APD" => 0.05,
"EMN" => 0.05,
"ECL" => 0.05,
"FMC" => 0.05
)
),
array(
"sector" => "Utilities",
"directory" => "utilities",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PPL" => 0.05,
"PCG" => 0.05,
"SO" => 0.05,
"WEC" => 0.05,
)
),
array(
"sector" => "Consumer Discretionary",
"directory" => "consumer-discretionary",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DIS" => 0.05,
"HD" => 0.05,
"BBY" => 0.05,
"CBS" => 0.05,
"CMG" => 0.05
)
),
array(
"sector" => "Consumer Staples",
"directory" => "consumer-staples",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PEP" => 0.05,
"PM" => 0.05,
"PG" => 0.05,
"MNST" => 0.05,
"TSN" => 0.05
)
),
array(
"sector" => "Defense",
"directory" => "defense-and-aerospace",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"BA" => 0.05,
"LMT" => 0.05,
"UTX" => 0.05,
"NOC" => 0.05,
"HON" => 0.05
)
),
array(
"sector" => "Health",
"directory" => "health-care-and-pharmaceuticals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"UNH" => 0.05,
"JNJ" => 0.05,
"PFE" => 0.05,
"UHS" => 0.05,
"AET" => 0.05
"RMD" => 0.05
)
),
array(
"sector" => "Real Estate",
"directory" => "real-estate",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CCI" => 0.05,
"AMT" => 0.05,
"AVB" => 0.05,
"HCP" => 0.05,
"RCL" => 0.05
"HST" => 0.05
)
)
);
return $sectorInfos;
}
function __destruct()
{
echo "YAAAY! " . __METHOD__ . " success! 💚 n";
return true;
}
}
Output (text.txt)
{"Overall":0.05,"IT":0.05,"Telecommunication":0.05,"Finance":0.05,"Energy":0.05,"Industrials":0.05,"Materials
and Chemicals":0.05,"Utilities":0.05,"Consumer
Discretionary":0.05,"Consumer
Staples":0.05,"Defense":0.05,"Health":0.05,"Real Estate":0.05}
performance beginner php json api
edited 28 mins ago
Jamal♦
30.4k11121227
asked yesterday
EmmaEmma
177112
$endgroup$
2
$begingroup$
"I have simplified and added some dummy numbers" Please, don't simplify your code before putting it up for review. Take a look at the help center and our guide on asking questions if anything is unclear, but we need to see your real code in it's real habitat to be able to write a quality, useful review.
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Hi Mast, Thanks so much! Will try so! Some of my scripts are too large, not possible!
$endgroup$
– Emma
13 hours ago
$begingroup$
Scripts being too large doesn't change our rules, really. We have a character limit for questions of 65536. That's more than double of what fits on most Stack Exchange sites. Are you sure it's too big to fit?
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Mast, Sure thing! I certainly understand. However, my simplification does not have anything to do with this review. Its the renames of internaldirs. Or for instance, each0.05is connected to a script, which returns something similar to0.012345678. While I did not write some of those scripts, others did and are not review required.sector_tickersare much bigger and such.
$endgroup$
– Emma
13 hours ago
$begingroup$
@Jamal Hi Jamal, Thanks so much for your edit!
$endgroup$
– Emma
26 mins ago
add a comment |
-1
-1
-1
1
$begingroup$
Class SectorController calculates weight coefficients for sector performances in equity exchange markets using minute data from an API (for instance, if a group of equities are up in the past 5 minutes, then coefficient is positive, if not, is negative, ranging from -1 to +1). Most of calculations are based on other scripts, which is not necessary for this review.
Would you be so kind and review this class and help me to make it faster, if possible?
Script
class SectorController
{
/**
*
* @var a string of iextrading base URL
*/
const BASE_URL = "https://api.iextrading.com/1.0/";
/**
*
* @var a string of target path and query
*/
const TARGET_QUERY = "stock/market/batch?symbols=";
/**
*
* @var a string for backend path for every sector
*/
const EACH_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir-";
/**
*
* @var a string for backend path for index sector
*/
const INDEX_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir/";
/**
*
* @var a string for live data path
*/
const LIVE_DATA_DIR = "/../../../public_html/dir/dir/";
function __construct()
{
echo "YAAAY! " . __METHOD__ . " success 💚n";
return true;
}
public static function getSectors(){
$baseUrl=self::BASE_URL.self::TARGET_QUERY;
$currentTime = date("Y-m-d-H-i-s");
$permission = 0755;
$indexData = array( "Overall" => array("sector_weight" => 1, "sector_coefficient" => 5,
$sectorInfos=SectorController::iexSectorParams();
foreach ($sectorInfos as $a => $sectorInfo) {
$sectorUrl = $baseUrl . implode(",", array_keys($sectorInfo["selected_tickers"])) . "&types=quote&range=1m";
$rawSectorJson = file_get_contents($sectorUrl);
$rawSectorArray = json_decode($rawSectorJson, true);
// Write the raw file
$rawSectorDir = __DIR__ . self::EACH_SECTOR_DIR_PREFIX . $sectorInfo["directory"];
if (!is_dir($rawSectorDir)) {
mkdir($rawSectorDir, $permission, true);
}
$rawSectorFile = $rawSectorDir . "/" . $currentTime . ".json";
$fp = fopen($rawSectorFile, "a+");
fwrite($fp, $rawSectorJson);
fclose($fp);
// Calculate the real-time index
$indexValue = 0;
foreach ($rawSectorArray as $ticker => $tickerStats) {
if (isset($sectorInfo["selected_tickers"][$ticker], $tickerStats["quote"], $tickerStats["quote"]["extendedChangePercent"], $tickerStats["quote"]["changePercent"], $tickerStats["quote"]["ytdChange"])) {
$changeAmount = ($tickerStats["quote"]["extendedChangePercent"] + $tickerStats["quote"]["changePercent"] + $tickerStats["quote"]["ytdChange"])/200;
$indexValue += $sectorInfo["sector_weight"] * $sectorInfo["selected_tickers"][$ticker] * $changeAmount;
}
}
$indexData[$sectorInfo["sector"]] = array("sector_weight" => $sectorInfo["sector_weight"], "sector_coefficient" => 5,
$indexData["Overall"]["sector_value"] += $indexData[$sectorInfo["sector"]]["sector_value"];
}
// Calculate the index factor for better visibility between -1 and +1
$frontIndexData = array();
foreach ($indexData as $sectorName => $sectorIndexData) {
$indexSign = $sectorIndexData["sector_value"];
if ($indexSign < 0) {
$indexSign = - $indexSign;
}
$indexFactor = 1;
for ($i=0; $i <= 10; $i++) {
$indexFactor = pow(10, $i);
if (($indexFactor * $indexSign) > 1) {
$indexFactor = pow(10, $i - 1);
break;
}
}
$frontIndexData[$sectorName] = $sectorIndexData["sector_weight"] * $sectorIndexData["sector_coefficient"] * $sectorIndexData["sector_value"] * $indexFactor;
}
// Write the index file
$indexSectorDir = __DIR__ . self::INDEX_SECTOR_DIR_PREFIX;
if (!is_dir($indexSectorDir)) {mkdir($indexSectorDir, $permission, true);}
$indexSectorFile = $indexSectorDir . $currentTime . ".json";
$indexSectorJson = json_encode($frontIndexData, JSON_FORCE_OBJECT);
$fp = fopen($indexSectorFile, "a+");
fwrite($fp, $indexSectorJson);
fclose($fp);
$sectorDir = __DIR__ . self::LIVE_DATA_DIR;
if (!is_dir($sectorDir)) {mkdir($sectorDir, $permission, true);} // if data directory did not exist
// if text file did not exist
if (!file_exists($sectorDir . "text.txt")){
$handle=fopen($sectorDir . "text.txt", "wb");
fwrite($handle, "d");
fclose($handle);
}
$sectorCoefFile = $sectorDir . "text.txt";
copy($indexSectorFile, $sectorCoefFile);
echo "YAAAY! " . __METHOD__ . " updated sector coefficients successfully 💚!n";
return $frontIndexData;
}
public static function iexSectorParams(){
$sectorInfos = array(
array(
"sector" => "IT",
"directory" => "information-technology",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"AAPL" => 0.05,
"AMZN" => 0.05,
"GOOGL" => 0.05,
"IBM" => 0.05
"MSFT" => 0.05
)
),
array(
"sector" => "Telecommunication",
"directory" => "telecommunication-services",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"VZ" => 0.05,
"CSCO" => 0.05,
"CMCSA" => 0.05,
"T" => 0.05,
"CTL" => 0.05
)
),
array(
"sector" => "Finance",
"directory" => "financial-services",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"JPM" => 0.05,
"GS" => 0.05,
"V" => 0.05,
"BAC" => 0.05,
"AXP" => 0.05
)
),
array(
"sector" => "Energy",
"directory" => "energy",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"CVX" => 0.05,
"XOM" => 0.05,
"APA" => 0.05,
"COP" => 0.05,
)
),
array(
"sector" => "Industrials",
"directory" => "industrials",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CAT" => 0.05,
"FLR" => 0.05,
"GE" => 0.05,
"JEC" => 0.05,
)
),
array(
"sector" => "Materials and Chemicals",
"directory" => "materials-and-chemicals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DWDP" => 0.05,
"APD" => 0.05,
"EMN" => 0.05,
"ECL" => 0.05,
"FMC" => 0.05
)
),
array(
"sector" => "Utilities",
"directory" => "utilities",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PPL" => 0.05,
"PCG" => 0.05,
"SO" => 0.05,
"WEC" => 0.05,
)
),
array(
"sector" => "Consumer Discretionary",
"directory" => "consumer-discretionary",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DIS" => 0.05,
"HD" => 0.05,
"BBY" => 0.05,
"CBS" => 0.05,
"CMG" => 0.05
)
),
array(
"sector" => "Consumer Staples",
"directory" => "consumer-staples",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PEP" => 0.05,
"PM" => 0.05,
"PG" => 0.05,
"MNST" => 0.05,
"TSN" => 0.05
)
),
array(
"sector" => "Defense",
"directory" => "defense-and-aerospace",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"BA" => 0.05,
"LMT" => 0.05,
"UTX" => 0.05,
"NOC" => 0.05,
"HON" => 0.05
)
),
array(
"sector" => "Health",
"directory" => "health-care-and-pharmaceuticals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"UNH" => 0.05,
"JNJ" => 0.05,
"PFE" => 0.05,
"UHS" => 0.05,
"AET" => 0.05
"RMD" => 0.05
)
),
array(
"sector" => "Real Estate",
"directory" => "real-estate",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CCI" => 0.05,
"AMT" => 0.05,
"AVB" => 0.05,
"HCP" => 0.05,
"RCL" => 0.05
"HST" => 0.05
)
)
);
return $sectorInfos;
}
function __destruct()
{
echo "YAAAY! " . __METHOD__ . " success! 💚 n";
return true;
}
}
Output (text.txt)
{"Overall":0.05,"IT":0.05,"Telecommunication":0.05,"Finance":0.05,"Energy":0.05,"Industrials":0.05,"Materials
and Chemicals":0.05,"Utilities":0.05,"Consumer
Discretionary":0.05,"Consumer
Staples":0.05,"Defense":0.05,"Health":0.05,"Real Estate":0.05}
performance beginner php json api
edited 28 mins ago
Jamal♦
30.4k11121227
asked yesterday
EmmaEmma
177112
$endgroup$
Class SectorController calculates weight coefficients for sector performances in equity exchange markets using minute data from an API (for instance, if a group of equities are up in the past 5 minutes, then coefficient is positive, if not, is negative, ranging from -1 to +1). Most of calculations are based on other scripts, which is not necessary for this review.
Would you be so kind and review this class and help me to make it faster, if possible?
Script
class SectorController
{
/**
*
* @var a string of iextrading base URL
*/
const BASE_URL = "https://api.iextrading.com/1.0/";
/**
*
* @var a string of target path and query
*/
const TARGET_QUERY = "stock/market/batch?symbols=";
/**
*
* @var a string for backend path for every sector
*/
const EACH_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir-";
/**
*
* @var a string for backend path for index sector
*/
const INDEX_SECTOR_DIR_PREFIX = "/../../dir/dir/dir/dir/";
/**
*
* @var a string for live data path
*/
const LIVE_DATA_DIR = "/../../../public_html/dir/dir/";
function __construct()
{
echo "YAAAY! " . __METHOD__ . " success 💚n";
return true;
}
public static function getSectors(){
$baseUrl=self::BASE_URL.self::TARGET_QUERY;
$currentTime = date("Y-m-d-H-i-s");
$permission = 0755;
$indexData = array( "Overall" => array("sector_weight" => 1, "sector_coefficient" => 5,
$sectorInfos=SectorController::iexSectorParams();
foreach ($sectorInfos as $a => $sectorInfo) {
$sectorUrl = $baseUrl . implode(",", array_keys($sectorInfo["selected_tickers"])) . "&types=quote&range=1m";
$rawSectorJson = file_get_contents($sectorUrl);
$rawSectorArray = json_decode($rawSectorJson, true);
// Write the raw file
$rawSectorDir = __DIR__ . self::EACH_SECTOR_DIR_PREFIX . $sectorInfo["directory"];
if (!is_dir($rawSectorDir)) {
mkdir($rawSectorDir, $permission, true);
}
$rawSectorFile = $rawSectorDir . "/" . $currentTime . ".json";
$fp = fopen($rawSectorFile, "a+");
fwrite($fp, $rawSectorJson);
fclose($fp);
// Calculate the real-time index
$indexValue = 0;
foreach ($rawSectorArray as $ticker => $tickerStats) {
if (isset($sectorInfo["selected_tickers"][$ticker], $tickerStats["quote"], $tickerStats["quote"]["extendedChangePercent"], $tickerStats["quote"]["changePercent"], $tickerStats["quote"]["ytdChange"])) {
$changeAmount = ($tickerStats["quote"]["extendedChangePercent"] + $tickerStats["quote"]["changePercent"] + $tickerStats["quote"]["ytdChange"])/200;
$indexValue += $sectorInfo["sector_weight"] * $sectorInfo["selected_tickers"][$ticker] * $changeAmount;
}
}
$indexData[$sectorInfo["sector"]] = array("sector_weight" => $sectorInfo["sector_weight"], "sector_coefficient" => 5,
$indexData["Overall"]["sector_value"] += $indexData[$sectorInfo["sector"]]["sector_value"];
}
// Calculate the index factor for better visibility between -1 and +1
$frontIndexData = array();
foreach ($indexData as $sectorName => $sectorIndexData) {
$indexSign = $sectorIndexData["sector_value"];
if ($indexSign < 0) {
$indexSign = - $indexSign;
}
$indexFactor = 1;
for ($i=0; $i <= 10; $i++) {
$indexFactor = pow(10, $i);
if (($indexFactor * $indexSign) > 1) {
$indexFactor = pow(10, $i - 1);
break;
}
}
$frontIndexData[$sectorName] = $sectorIndexData["sector_weight"] * $sectorIndexData["sector_coefficient"] * $sectorIndexData["sector_value"] * $indexFactor;
}
// Write the index file
$indexSectorDir = __DIR__ . self::INDEX_SECTOR_DIR_PREFIX;
if (!is_dir($indexSectorDir)) {mkdir($indexSectorDir, $permission, true);}
$indexSectorFile = $indexSectorDir . $currentTime . ".json";
$indexSectorJson = json_encode($frontIndexData, JSON_FORCE_OBJECT);
$fp = fopen($indexSectorFile, "a+");
fwrite($fp, $indexSectorJson);
fclose($fp);
$sectorDir = __DIR__ . self::LIVE_DATA_DIR;
if (!is_dir($sectorDir)) {mkdir($sectorDir, $permission, true);} // if data directory did not exist
// if text file did not exist
if (!file_exists($sectorDir . "text.txt")){
$handle=fopen($sectorDir . "text.txt", "wb");
fwrite($handle, "d");
fclose($handle);
}
$sectorCoefFile = $sectorDir . "text.txt";
copy($indexSectorFile, $sectorCoefFile);
echo "YAAAY! " . __METHOD__ . " updated sector coefficients successfully 💚!n";
return $frontIndexData;
}
public static function iexSectorParams(){
$sectorInfos = array(
array(
"sector" => "IT",
"directory" => "information-technology",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"AAPL" => 0.05,
"AMZN" => 0.05,
"GOOGL" => 0.05,
"IBM" => 0.05
"MSFT" => 0.05
)
),
array(
"sector" => "Telecommunication",
"directory" => "telecommunication-services",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"VZ" => 0.05,
"CSCO" => 0.05,
"CMCSA" => 0.05,
"T" => 0.05,
"CTL" => 0.05
)
),
array(
"sector" => "Finance",
"directory" => "financial-services",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"JPM" => 0.05,
"GS" => 0.05,
"V" => 0.05,
"BAC" => 0.05,
"AXP" => 0.05
)
),
array(
"sector" => "Energy",
"directory" => "energy",
"sector_weight" => 0.05
"sector_coefficient" => 5,
"selected_tickers" => array(
"CVX" => 0.05,
"XOM" => 0.05,
"APA" => 0.05,
"COP" => 0.05,
)
),
array(
"sector" => "Industrials",
"directory" => "industrials",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CAT" => 0.05,
"FLR" => 0.05,
"GE" => 0.05,
"JEC" => 0.05,
)
),
array(
"sector" => "Materials and Chemicals",
"directory" => "materials-and-chemicals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DWDP" => 0.05,
"APD" => 0.05,
"EMN" => 0.05,
"ECL" => 0.05,
"FMC" => 0.05
)
),
array(
"sector" => "Utilities",
"directory" => "utilities",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PPL" => 0.05,
"PCG" => 0.05,
"SO" => 0.05,
"WEC" => 0.05,
)
),
array(
"sector" => "Consumer Discretionary",
"directory" => "consumer-discretionary",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"DIS" => 0.05,
"HD" => 0.05,
"BBY" => 0.05,
"CBS" => 0.05,
"CMG" => 0.05
)
),
array(
"sector" => "Consumer Staples",
"directory" => "consumer-staples",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"PEP" => 0.05,
"PM" => 0.05,
"PG" => 0.05,
"MNST" => 0.05,
"TSN" => 0.05
)
),
array(
"sector" => "Defense",
"directory" => "defense-and-aerospace",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"BA" => 0.05,
"LMT" => 0.05,
"UTX" => 0.05,
"NOC" => 0.05,
"HON" => 0.05
)
),
array(
"sector" => "Health",
"directory" => "health-care-and-pharmaceuticals",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"UNH" => 0.05,
"JNJ" => 0.05,
"PFE" => 0.05,
"UHS" => 0.05,
"AET" => 0.05
"RMD" => 0.05
)
),
array(
"sector" => "Real Estate",
"directory" => "real-estate",
"sector_weight" => 0.05,
"sector_coefficient" => 5,
"selected_tickers" => array(
"CCI" => 0.05,
"AMT" => 0.05,
"AVB" => 0.05,
"HCP" => 0.05,
"RCL" => 0.05
"HST" => 0.05
)
)
);
return $sectorInfos;
}
function __destruct()
{
echo "YAAAY! " . __METHOD__ . " success! 💚 n";
return true;
}
}
Output (text.txt)
{"Overall":0.05,"IT":0.05,"Telecommunication":0.05,"Finance":0.05,"Energy":0.05,"Industrials":0.05,"Materials
and Chemicals":0.05,"Utilities":0.05,"Consumer
Discretionary":0.05,"Consumer
Staples":0.05,"Defense":0.05,"Health":0.05,"Real Estate":0.05}
performance beginner php json api
performance beginner php json api
edited 28 mins ago
Jamal♦
30.4k11121227
asked yesterday
EmmaEmma
177112
edited 28 mins ago
Jamal♦
30.4k11121227
asked yesterday
EmmaEmma
177112
edited 28 mins ago
Jamal♦
30.4k11121227
edited 28 mins ago
Jamal♦
30.4k11121227
edited 28 mins ago
Jamal♦
30.4k11121227
30.4k11121227
asked yesterday
EmmaEmma
177112
asked yesterday
EmmaEmma
177112
asked yesterday
EmmaEmma
177112
177112
2
$begingroup$
"I have simplified and added some dummy numbers" Please, don't simplify your code before putting it up for review. Take a look at the help center and our guide on asking questions if anything is unclear, but we need to see your real code in it's real habitat to be able to write a quality, useful review.
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Hi Mast, Thanks so much! Will try so! Some of my scripts are too large, not possible!
$endgroup$
– Emma
13 hours ago
$begingroup$
Scripts being too large doesn't change our rules, really. We have a character limit for questions of 65536. That's more than double of what fits on most Stack Exchange sites. Are you sure it's too big to fit?
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Mast, Sure thing! I certainly understand. However, my simplification does not have anything to do with this review. Its the renames of internaldirs. Or for instance, each0.05is connected to a script, which returns something similar to0.012345678. While I did not write some of those scripts, others did and are not review required.sector_tickersare much bigger and such.
$endgroup$
– Emma
13 hours ago
$begingroup$
@Jamal Hi Jamal, Thanks so much for your edit!
$endgroup$
– Emma
26 mins ago
add a comment |
2
$begingroup$
"I have simplified and added some dummy numbers" Please, don't simplify your code before putting it up for review. Take a look at the help center and our guide on asking questions if anything is unclear, but we need to see your real code in it's real habitat to be able to write a quality, useful review.
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Hi Mast, Thanks so much! Will try so! Some of my scripts are too large, not possible!
$endgroup$
– Emma
13 hours ago
$begingroup$
Scripts being too large doesn't change our rules, really. We have a character limit for questions of 65536. That's more than double of what fits on most Stack Exchange sites. Are you sure it's too big to fit?
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Mast, Sure thing! I certainly understand. However, my simplification does not have anything to do with this review. Its the renames of internaldirs. Or for instance, each0.05is connected to a script, which returns something similar to0.012345678. While I did not write some of those scripts, others did and are not review required.sector_tickersare much bigger and such.
$endgroup$
– Emma
13 hours ago
$begingroup$
@Jamal Hi Jamal, Thanks so much for your edit!
$endgroup$
– Emma
26 mins ago
2
2
$begingroup$
"I have simplified and added some dummy numbers" Please, don't simplify your code before putting it up for review. Take a look at the help center and our guide on asking questions if anything is unclear, but we need to see your real code in it's real habitat to be able to write a quality, useful review.
$endgroup$
– Mast
13 hours ago
$begingroup$
"I have simplified and added some dummy numbers" Please, don't simplify your code before putting it up for review. Take a look at the help center and our guide on asking questions if anything is unclear, but we need to see your real code in it's real habitat to be able to write a quality, useful review.
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Hi Mast, Thanks so much! Will try so! Some of my scripts are too large, not possible!
$endgroup$
– Emma
13 hours ago
$begingroup$
@Mast Hi Mast, Thanks so much! Will try so! Some of my scripts are too large, not possible!
$endgroup$
– Emma
13 hours ago
$begingroup$
Scripts being too large doesn't change our rules, really. We have a character limit for questions of 65536. That's more than double of what fits on most Stack Exchange sites. Are you sure it's too big to fit?
$endgroup$
– Mast
13 hours ago
$begingroup$
Scripts being too large doesn't change our rules, really. We have a character limit for questions of 65536. That's more than double of what fits on most Stack Exchange sites. Are you sure it's too big to fit?
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Mast, Sure thing! I certainly understand. However, my simplification does not have anything to do with this review. Its the renames of internal
dirs. Or for instance, each 0.05 is connected to a script, which returns something similar to0.012345678. While I did not write some of those scripts, others did and are not review required. sector_tickers are much bigger and such.$endgroup$
– Emma
13 hours ago
$begingroup$
@Mast Mast, Sure thing! I certainly understand. However, my simplification does not have anything to do with this review. Its the renames of internal
dirs. Or for instance, each 0.05 is connected to a script, which returns something similar to0.012345678. While I did not write some of those scripts, others did and are not review required. sector_tickers are much bigger and such.$endgroup$
– Emma
13 hours ago
$begingroup$
@Jamal Hi Jamal, Thanks so much for your edit!
$endgroup$
– Emma
26 mins ago
$begingroup$
@Jamal Hi Jamal, Thanks so much for your edit!
$endgroup$
– Emma
26 mins ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215541%2fread-json-files-basic-calculations-and-write-over-another-json-file%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215541%2fread-json-files-basic-calculations-and-write-over-another-json-file%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
2
$begingroup$
"I have simplified and added some dummy numbers" Please, don't simplify your code before putting it up for review. Take a look at the help center and our guide on asking questions if anything is unclear, but we need to see your real code in it's real habitat to be able to write a quality, useful review.
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Hi Mast, Thanks so much! Will try so! Some of my scripts are too large, not possible!
$endgroup$
– Emma
13 hours ago
$begingroup$
Scripts being too large doesn't change our rules, really. We have a character limit for questions of 65536. That's more than double of what fits on most Stack Exchange sites. Are you sure it's too big to fit?
$endgroup$
– Mast
13 hours ago
$begingroup$
@Mast Mast, Sure thing! I certainly understand. However, my simplification does not have anything to do with this review. Its the renames of internal
dirs. Or for instance, each0.05is connected to a script, which returns something similar to0.012345678. While I did not write some of those scripts, others did and are not review required.sector_tickersare much bigger and such.$endgroup$
– Emma
13 hours ago
$begingroup$
@Jamal Hi Jamal, Thanks so much for your edit!
$endgroup$
– Emma
26 mins ago