A D wrapper around C library librdf












1












$begingroup$


I have created a D wrapper (static and dynamic library) around the C library librdf.



The version for review:
https://github.com/vporton/redland-bindings/tree/5d942dab18eeb66508fdffeb328bd190a3cd9c41/dlang



There are some issues:




  • I use types like URIHandle* where URIHandle is declared as a struct without body. Such handles cannot be declared private because I pass them between different modules of my library. Is it bad that I expose that the types are pointers, not abstract handles, should I instead write like the following?


This:



private struct URIHandleInt;
alias URIHandle = URIHandleInt*;


I added const qualifiers to the this argument of member functions where appropriate. Is it important also to add const to explicit (non-this) arguments where appropriate?



Should I add scope modifiers where appropriate? Or can scope be neglected?



Is my rdf.auxiliary.handled_record OK? (especially about const Dummy* ptr?) I think the compiler won't break it, because it cannot look inside C functions. But to be sure I ask, whether this (accessing even mutable values through const ptr) may break sanity?



I may also ask whether the overall design of rdf.auxiliary.handled_record is good. But here I'd more boast by my design that really to ask.










share|improve this question









New contributor




porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    1












    $begingroup$


    I have created a D wrapper (static and dynamic library) around the C library librdf.



    The version for review:
    https://github.com/vporton/redland-bindings/tree/5d942dab18eeb66508fdffeb328bd190a3cd9c41/dlang



    There are some issues:




    • I use types like URIHandle* where URIHandle is declared as a struct without body. Such handles cannot be declared private because I pass them between different modules of my library. Is it bad that I expose that the types are pointers, not abstract handles, should I instead write like the following?


    This:



    private struct URIHandleInt;
    alias URIHandle = URIHandleInt*;


    I added const qualifiers to the this argument of member functions where appropriate. Is it important also to add const to explicit (non-this) arguments where appropriate?



    Should I add scope modifiers where appropriate? Or can scope be neglected?



    Is my rdf.auxiliary.handled_record OK? (especially about const Dummy* ptr?) I think the compiler won't break it, because it cannot look inside C functions. But to be sure I ask, whether this (accessing even mutable values through const ptr) may break sanity?



    I may also ask whether the overall design of rdf.auxiliary.handled_record is good. But here I'd more boast by my design that really to ask.










    share|improve this question









    New contributor




    porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      I have created a D wrapper (static and dynamic library) around the C library librdf.



      The version for review:
      https://github.com/vporton/redland-bindings/tree/5d942dab18eeb66508fdffeb328bd190a3cd9c41/dlang



      There are some issues:




      • I use types like URIHandle* where URIHandle is declared as a struct without body. Such handles cannot be declared private because I pass them between different modules of my library. Is it bad that I expose that the types are pointers, not abstract handles, should I instead write like the following?


      This:



      private struct URIHandleInt;
      alias URIHandle = URIHandleInt*;


      I added const qualifiers to the this argument of member functions where appropriate. Is it important also to add const to explicit (non-this) arguments where appropriate?



      Should I add scope modifiers where appropriate? Or can scope be neglected?



      Is my rdf.auxiliary.handled_record OK? (especially about const Dummy* ptr?) I think the compiler won't break it, because it cannot look inside C functions. But to be sure I ask, whether this (accessing even mutable values through const ptr) may break sanity?



      I may also ask whether the overall design of rdf.auxiliary.handled_record is good. But here I'd more boast by my design that really to ask.










      share|improve this question









      New contributor




      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I have created a D wrapper (static and dynamic library) around the C library librdf.



      The version for review:
      https://github.com/vporton/redland-bindings/tree/5d942dab18eeb66508fdffeb328bd190a3cd9c41/dlang



      There are some issues:




      • I use types like URIHandle* where URIHandle is declared as a struct without body. Such handles cannot be declared private because I pass them between different modules of my library. Is it bad that I expose that the types are pointers, not abstract handles, should I instead write like the following?


      This:



      private struct URIHandleInt;
      alias URIHandle = URIHandleInt*;


      I added const qualifiers to the this argument of member functions where appropriate. Is it important also to add const to explicit (non-this) arguments where appropriate?



      Should I add scope modifiers where appropriate? Or can scope be neglected?



      Is my rdf.auxiliary.handled_record OK? (especially about const Dummy* ptr?) I think the compiler won't break it, because it cannot look inside C functions. But to be sure I ask, whether this (accessing even mutable values through const ptr) may break sanity?



      I may also ask whether the overall design of rdf.auxiliary.handled_record is good. But here I'd more boast by my design that really to ask.







      api library d






      share|improve this question









      New contributor




      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 5 hours ago







      porton













      New contributor




      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 7 hours ago









      portonporton

      1065




      1065




      New contributor




      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      porton is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          porton is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212017%2fa-d-wrapper-around-c-library-librdf%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          porton is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          porton is a new contributor. Be nice, and check out our Code of Conduct.













          porton is a new contributor. Be nice, and check out our Code of Conduct.












          porton is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212017%2fa-d-wrapper-around-c-library-librdf%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀