Running a scalar function on multiple columns
I have a large table in which I store region/state/province codes (two letters) from different countries.I use these region codes further downstream for multiple process. One of the steps I do is a cleanup of regions to ensure it is valid region/state/province code.I have a lookup table consisting of country vs region code to validate each column.
The current code is below.6 columns are validated separately.Is there a way to do this better?
UPDATE table_region
SET a_region = NULL
WHERE a_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,a_region) = 0;
UPDATE table_region
SET b_region = NULL
WHERE b_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,b_region) = 0;
UPDATE table_region
SET c_region = NULL
WHERE c_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, c_region) = 0;
UPDATE table_region
SET d_region = NULL
WHERE d_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,d_region) = 0;
UPDATE table_region
SET e_region = NULL
WHERE e_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, e_region) = 0;
UPDATE table_region
SET f_region = NULL
WHERE f_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, f_region) = 0;
The function is like below
ALTER Function [dbo].[IsValidRegion](@country VARCHAR(20), @value
VARCHAR(20))
Returns INT
AS
BEGIN
DECLARE @res INT
BEGIN
IF EXISTS (SELECT 1 FROM mapping.region WHERE country = @country AND region_code = @value)
SELECT @res = 1
ELSE
SELECT @res = 0
END
RETURN @res
END
sql sql-server
asked yesterday
VK_217
1063
add a comment |
I have a large table in which I store region/state/province codes (two letters) from different countries.I use these region codes further downstream for multiple process. One of the steps I do is a cleanup of regions to ensure it is valid region/state/province code.I have a lookup table consisting of country vs region code to validate each column.
The current code is below.6 columns are validated separately.Is there a way to do this better?
UPDATE table_region
SET a_region = NULL
WHERE a_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,a_region) = 0;
UPDATE table_region
SET b_region = NULL
WHERE b_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,b_region) = 0;
UPDATE table_region
SET c_region = NULL
WHERE c_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, c_region) = 0;
UPDATE table_region
SET d_region = NULL
WHERE d_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,d_region) = 0;
UPDATE table_region
SET e_region = NULL
WHERE e_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, e_region) = 0;
UPDATE table_region
SET f_region = NULL
WHERE f_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, f_region) = 0;
The function is like below
ALTER Function [dbo].[IsValidRegion](@country VARCHAR(20), @value
VARCHAR(20))
Returns INT
AS
BEGIN
DECLARE @res INT
BEGIN
IF EXISTS (SELECT 1 FROM mapping.region WHERE country = @country AND region_code = @value)
SELECT @res = 1
ELSE
SELECT @res = 0
END
RETURN @res
END
sql sql-server
asked yesterday
VK_217
1063
Why don't you just foreign key this table to the table specifying valid country regions?
– Caius Jard
yesterday
add a comment |
I have a large table in which I store region/state/province codes (two letters) from different countries.I use these region codes further downstream for multiple process. One of the steps I do is a cleanup of regions to ensure it is valid region/state/province code.I have a lookup table consisting of country vs region code to validate each column.
The current code is below.6 columns are validated separately.Is there a way to do this better?
UPDATE table_region
SET a_region = NULL
WHERE a_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,a_region) = 0;
UPDATE table_region
SET b_region = NULL
WHERE b_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,b_region) = 0;
UPDATE table_region
SET c_region = NULL
WHERE c_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, c_region) = 0;
UPDATE table_region
SET d_region = NULL
WHERE d_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,d_region) = 0;
UPDATE table_region
SET e_region = NULL
WHERE e_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, e_region) = 0;
UPDATE table_region
SET f_region = NULL
WHERE f_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, f_region) = 0;
The function is like below
ALTER Function [dbo].[IsValidRegion](@country VARCHAR(20), @value
VARCHAR(20))
Returns INT
AS
BEGIN
DECLARE @res INT
BEGIN
IF EXISTS (SELECT 1 FROM mapping.region WHERE country = @country AND region_code = @value)
SELECT @res = 1
ELSE
SELECT @res = 0
END
RETURN @res
END
sql sql-server
asked yesterday
VK_217
1063
I have a large table in which I store region/state/province codes (two letters) from different countries.I use these region codes further downstream for multiple process. One of the steps I do is a cleanup of regions to ensure it is valid region/state/province code.I have a lookup table consisting of country vs region code to validate each column.
The current code is below.6 columns are validated separately.Is there a way to do this better?
UPDATE table_region
SET a_region = NULL
WHERE a_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,a_region) = 0;
UPDATE table_region
SET b_region = NULL
WHERE b_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,b_region) = 0;
UPDATE table_region
SET c_region = NULL
WHERE c_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, c_region) = 0;
UPDATE table_region
SET d_region = NULL
WHERE d_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country,d_region) = 0;
UPDATE table_region
SET e_region = NULL
WHERE e_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, e_region) = 0;
UPDATE table_region
SET f_region = NULL
WHERE f_region IS NOT NULL
AND country IS NOT NULL
AND dbo.IsValidRegion(country, f_region) = 0;
The function is like below
ALTER Function [dbo].[IsValidRegion](@country VARCHAR(20), @value
VARCHAR(20))
Returns INT
AS
BEGIN
DECLARE @res INT
BEGIN
IF EXISTS (SELECT 1 FROM mapping.region WHERE country = @country AND region_code = @value)
SELECT @res = 1
ELSE
SELECT @res = 0
END
RETURN @res
END
sql sql-server
sql sql-server
asked yesterday
VK_217
1063
asked yesterday
VK_217
1063
asked yesterday
VK_217
1063
asked yesterday
VK_217
1063
asked yesterday
VK_217
1063
1063
Why don't you just foreign key this table to the table specifying valid country regions?
– Caius Jard
yesterday
add a comment |
Why don't you just foreign key this table to the table specifying valid country regions?
– Caius Jard
yesterday
Why don't you just foreign key this table to the table specifying valid country regions?
– Caius Jard
yesterday
Why don't you just foreign key this table to the table specifying valid country regions?
– Caius Jard
yesterday
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210885%2frunning-a-scalar-function-on-multiple-columns%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f210885%2frunning-a-scalar-function-on-multiple-columns%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Why don't you just foreign key this table to the table specifying valid country regions?
– Caius Jard
yesterday