Bash script to backup a LAMP server












1












$begingroup$


I wrote a bash script for backing up my LAMP server. To be honest that's my first experience in bash so I want to ask you for help in its improvement.



#!/bin/bash

date=`(date +%Y%m%d%H%M)`

declare -A users=(
["user1"]="password1"
["user2"]="password2"
)

for user in ${!users[@]}
do
directory=$user

directories=`find /var/www/$directory -maxdepth 1 -mindepth 1 -type d`

for directory in $directories
do
cd $directory

if [ ! -d backups ]
then
mkdir backups
fi

tar --exclude ./backups -czf backups/$date.tar.gz .

password=${users[$user]}

databases=`mysql -u $user -p$password -Bse "SHOW DATABASES;"`

for database in $databases
do
if [ $database = ${directory##*/} ]
then
mysqldump -u $user -p$password $database | gzip > backups/$date.sql.gz
fi
done

chmod 770 backups -R
chown $user:$user backups -R
done
done









share|improve this question









New contributor




Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    1












    $begingroup$


    I wrote a bash script for backing up my LAMP server. To be honest that's my first experience in bash so I want to ask you for help in its improvement.



    #!/bin/bash

    date=`(date +%Y%m%d%H%M)`

    declare -A users=(
    ["user1"]="password1"
    ["user2"]="password2"
    )

    for user in ${!users[@]}
    do
    directory=$user

    directories=`find /var/www/$directory -maxdepth 1 -mindepth 1 -type d`

    for directory in $directories
    do
    cd $directory

    if [ ! -d backups ]
    then
    mkdir backups
    fi

    tar --exclude ./backups -czf backups/$date.tar.gz .

    password=${users[$user]}

    databases=`mysql -u $user -p$password -Bse "SHOW DATABASES;"`

    for database in $databases
    do
    if [ $database = ${directory##*/} ]
    then
    mysqldump -u $user -p$password $database | gzip > backups/$date.sql.gz
    fi
    done

    chmod 770 backups -R
    chown $user:$user backups -R
    done
    done









    share|improve this question









    New contributor




    Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      I wrote a bash script for backing up my LAMP server. To be honest that's my first experience in bash so I want to ask you for help in its improvement.



      #!/bin/bash

      date=`(date +%Y%m%d%H%M)`

      declare -A users=(
      ["user1"]="password1"
      ["user2"]="password2"
      )

      for user in ${!users[@]}
      do
      directory=$user

      directories=`find /var/www/$directory -maxdepth 1 -mindepth 1 -type d`

      for directory in $directories
      do
      cd $directory

      if [ ! -d backups ]
      then
      mkdir backups
      fi

      tar --exclude ./backups -czf backups/$date.tar.gz .

      password=${users[$user]}

      databases=`mysql -u $user -p$password -Bse "SHOW DATABASES;"`

      for database in $databases
      do
      if [ $database = ${directory##*/} ]
      then
      mysqldump -u $user -p$password $database | gzip > backups/$date.sql.gz
      fi
      done

      chmod 770 backups -R
      chown $user:$user backups -R
      done
      done









      share|improve this question









      New contributor




      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I wrote a bash script for backing up my LAMP server. To be honest that's my first experience in bash so I want to ask you for help in its improvement.



      #!/bin/bash

      date=`(date +%Y%m%d%H%M)`

      declare -A users=(
      ["user1"]="password1"
      ["user2"]="password2"
      )

      for user in ${!users[@]}
      do
      directory=$user

      directories=`find /var/www/$directory -maxdepth 1 -mindepth 1 -type d`

      for directory in $directories
      do
      cd $directory

      if [ ! -d backups ]
      then
      mkdir backups
      fi

      tar --exclude ./backups -czf backups/$date.tar.gz .

      password=${users[$user]}

      databases=`mysql -u $user -p$password -Bse "SHOW DATABASES;"`

      for database in $databases
      do
      if [ $database = ${directory##*/} ]
      then
      mysqldump -u $user -p$password $database | gzip > backups/$date.sql.gz
      fi
      done

      chmod 770 backups -R
      chown $user:$user backups -R
      done
      done






      beginner mysql bash






      share|improve this question









      New contributor




      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 4 mins ago









      200_success

      129k15153415




      129k15153415






      New contributor




      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 1 hour ago









      Вячеслав РавдинВячеслав Равдин

      61




      61




      New contributor




      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Вячеслав Равдин is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Вячеслав Равдин is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213555%2fbash-script-to-backup-a-lamp-server%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Вячеслав Равдин is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Вячеслав Равдин is a new contributor. Be nice, and check out our Code of Conduct.













          Вячеслав Равдин is a new contributor. Be nice, and check out our Code of Conduct.












          Вячеслав Равдин is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f213555%2fbash-script-to-backup-a-lamp-server%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀