C++ Console Menu User Validation












1












$begingroup$


So I am trying to implement a menu in a program I am writing. My goal is to have zero errors when collecting user input. So I thought the best way to validate was to capture the input as a string and then test against it and prompt for input again until it is valid.



As far as I can tell, my code works as I want it to. BUT, is this the best way to go about this? Almost every example online uses char or int for the input, are there benefits to this?. I feel like I made it more complex than it needed to be. As a beginner, any suggestions would be appreciated.



#include <iostream>
#include <string>
using namespace std;


string GetInput()
{
string s = "";

cout << ">> ";
getline(cin, s);

return s;
}
void mainMenu() {

cout << "Select an option" << endl;
cout << "1. Add Entry" << endl;
cout << "2. Edit Entry" << endl;
cout << "Q. Quit" << endl;

string input = GetInput();

while (!(input.find_first_not_of("12qQ") == string::npos) || input.empty())
{
input = GetInput();
}

if (input == "1") {
cout << "Add Entry" << endl;
//AddEntry();
}

else if (input == "2") {
cout << "Edit Entry" << endl;
}

else {
cout << "Quit" << endl;
}

}

int main() {

cout << "===================================================" << endl;
cout << "| Secure Database |" << endl;
cout << "===================================================" << endl << endl;

mainMenu();

return 0;
}









share|improve this question







New contributor




okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    1












    $begingroup$


    So I am trying to implement a menu in a program I am writing. My goal is to have zero errors when collecting user input. So I thought the best way to validate was to capture the input as a string and then test against it and prompt for input again until it is valid.



    As far as I can tell, my code works as I want it to. BUT, is this the best way to go about this? Almost every example online uses char or int for the input, are there benefits to this?. I feel like I made it more complex than it needed to be. As a beginner, any suggestions would be appreciated.



    #include <iostream>
    #include <string>
    using namespace std;


    string GetInput()
    {
    string s = "";

    cout << ">> ";
    getline(cin, s);

    return s;
    }
    void mainMenu() {

    cout << "Select an option" << endl;
    cout << "1. Add Entry" << endl;
    cout << "2. Edit Entry" << endl;
    cout << "Q. Quit" << endl;

    string input = GetInput();

    while (!(input.find_first_not_of("12qQ") == string::npos) || input.empty())
    {
    input = GetInput();
    }

    if (input == "1") {
    cout << "Add Entry" << endl;
    //AddEntry();
    }

    else if (input == "2") {
    cout << "Edit Entry" << endl;
    }

    else {
    cout << "Quit" << endl;
    }

    }

    int main() {

    cout << "===================================================" << endl;
    cout << "| Secure Database |" << endl;
    cout << "===================================================" << endl << endl;

    mainMenu();

    return 0;
    }









    share|improve this question







    New contributor




    okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      1












      1








      1





      $begingroup$


      So I am trying to implement a menu in a program I am writing. My goal is to have zero errors when collecting user input. So I thought the best way to validate was to capture the input as a string and then test against it and prompt for input again until it is valid.



      As far as I can tell, my code works as I want it to. BUT, is this the best way to go about this? Almost every example online uses char or int for the input, are there benefits to this?. I feel like I made it more complex than it needed to be. As a beginner, any suggestions would be appreciated.



      #include <iostream>
      #include <string>
      using namespace std;


      string GetInput()
      {
      string s = "";

      cout << ">> ";
      getline(cin, s);

      return s;
      }
      void mainMenu() {

      cout << "Select an option" << endl;
      cout << "1. Add Entry" << endl;
      cout << "2. Edit Entry" << endl;
      cout << "Q. Quit" << endl;

      string input = GetInput();

      while (!(input.find_first_not_of("12qQ") == string::npos) || input.empty())
      {
      input = GetInput();
      }

      if (input == "1") {
      cout << "Add Entry" << endl;
      //AddEntry();
      }

      else if (input == "2") {
      cout << "Edit Entry" << endl;
      }

      else {
      cout << "Quit" << endl;
      }

      }

      int main() {

      cout << "===================================================" << endl;
      cout << "| Secure Database |" << endl;
      cout << "===================================================" << endl << endl;

      mainMenu();

      return 0;
      }









      share|improve this question







      New contributor




      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      So I am trying to implement a menu in a program I am writing. My goal is to have zero errors when collecting user input. So I thought the best way to validate was to capture the input as a string and then test against it and prompt for input again until it is valid.



      As far as I can tell, my code works as I want it to. BUT, is this the best way to go about this? Almost every example online uses char or int for the input, are there benefits to this?. I feel like I made it more complex than it needed to be. As a beginner, any suggestions would be appreciated.



      #include <iostream>
      #include <string>
      using namespace std;


      string GetInput()
      {
      string s = "";

      cout << ">> ";
      getline(cin, s);

      return s;
      }
      void mainMenu() {

      cout << "Select an option" << endl;
      cout << "1. Add Entry" << endl;
      cout << "2. Edit Entry" << endl;
      cout << "Q. Quit" << endl;

      string input = GetInput();

      while (!(input.find_first_not_of("12qQ") == string::npos) || input.empty())
      {
      input = GetInput();
      }

      if (input == "1") {
      cout << "Add Entry" << endl;
      //AddEntry();
      }

      else if (input == "2") {
      cout << "Edit Entry" << endl;
      }

      else {
      cout << "Quit" << endl;
      }

      }

      int main() {

      cout << "===================================================" << endl;
      cout << "| Secure Database |" << endl;
      cout << "===================================================" << endl << endl;

      mainMenu();

      return 0;
      }






      c++ beginner strings






      share|improve this question







      New contributor




      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question







      New contributor




      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question






      New contributor




      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 4 hours ago









      okkv1747vmokkv1747vm

      61




      61




      New contributor




      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      okkv1747vm is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          okkv1747vm is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215704%2fc-console-menu-user-validation%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          okkv1747vm is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          okkv1747vm is a new contributor. Be nice, and check out our Code of Conduct.













          okkv1747vm is a new contributor. Be nice, and check out our Code of Conduct.












          okkv1747vm is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215704%2fc-console-menu-user-validation%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          第一次世界大戦

          Touch on Surface Book