Ytdyklly

I am writing logic in C# that contains two methods. One returns ILookup and the other returns List. Both these methods are defined in the data access layer. Some part of code need the ILookup while some need List. I feel there is redundant code and could be refactored. Looking for suggestions.

Data access layer

 ILookup<string, FIRMWIDE_MANAGER_ALLOCATION> IPackageRepo.GetManagerAllocationsGrouped(EntityType entity, int id, DateTime date, int? count)

        {

            var allocations = GetManagerAllocations(entity, id, date).OrderByDescending(o=> o.UsdEmv).ToList();



            var allocationsLookup  = allocations.ToLookup(a => a.MANAGER_STRATEGY_NAME, a => a);



            // add grouping by entity

            var allocationsGrouped = GroupManagerAllocationsByEntity(entity, allocations);





            var strategyTotals = allocationsGrouped.GroupBy(mgrStrat => new { mgrStrat.MANAGER_STRATEGY_ID }).Select(s => new { MANAGER_STRATEGY_ID = s.Key.MANAGER_STRATEGY_ID, StrategyTotal = s.Sum(x => x.UsdEmv) }).ToDictionary(k => k.MANAGER_STRATEGY_ID, v => v.StrategyTotal);



            var sum = allocationsGrouped.Sum(a => a.EMV);





            foreach (IGrouping<string, FIRMWIDE_MANAGER_ALLOCATION> item in allocationsLookup)

            {



                var allocationsGroup = item.Select(a => a);



                foreach (var alloc in allocationsGroup)

                {

                    if (sum > 0 && strategyTotals[alloc.MANAGER_STRATEGY_ID] != 0)

                    {

                        alloc.Percent = alloc.EMV / sum;

                        alloc.GroupPercent = (alloc.EMV / strategyTotals[alloc.MANAGER_STRATEGY_ID]) * 100 ;



                    }

                }

            }





            return allocationsLookup;

        }



        public List<Core.Model.FIRMWIDE_MANAGER_ALLOCATION> GetManagerAllocationsGrouped1(EntityType entity, int id, DateTime date, int? count = null)

        {

            var allocations = GetManagerAllocations(entity, id, date);

            // add grouping by entity

            var allocationsGrouped = GroupManagerAllocationsByEntity(entity, allocations);



            var strategyTotals = allocationsGrouped.GroupBy(mgrStrat => new { mgrStrat.MANAGER_STRATEGY_ID }).Select(s => new { MANAGER_STRATEGY_ID = s.Key.MANAGER_STRATEGY_ID, StrategyTotal = s.Sum(x => x.UsdEmv) }).ToDictionary(k => k.MANAGER_STRATEGY_ID, v => v.StrategyTotal);



            var sum = allocationsGrouped.Sum(a => a.EMV);

            foreach (var alloc in allocationsGrouped)

            {

                if (sum > 0 && strategyTotals[alloc.MANAGER_STRATEGY_ID] != 0)

                {

                    alloc.Percent = alloc.EMV / sum;

                    alloc.GroupPercent = alloc.EMV / strategyTotals[alloc.MANAGER_STRATEGY_ID];



                }

            }



            return allocationsGrouped;

        }

Methods in the controller that references the above

 protected IEnumerable<FIRMWIDE_MANAGER_ALLOCATION> GetAllocationsCalculateOther(EntityType entity, int id, DateTime date)

        {

            var results = GetAllocationsGrouped1(entity, id, date);



            results = results.GroupBy(grp => new { grp.FIRM_ID, grp.FIRM_NAME, grp.PRODUCT_ID, grp.PRODUCT_NAME })

                .Select(s => new FIRMWIDE_MANAGER_ALLOCATION

                    {

                        FIRM_ID = s.Key.FIRM_ID,

                        FIRM_NAME = s.Key.FIRM_NAME,

                        PRODUCT_ID = s.Key.PRODUCT_ID,

                        PRODUCT_NAME = s.Key.PRODUCT_NAME,

                        EMV = s.Sum(x => x.EMV),

                        USD_EMV = s.Sum(x => x.USD_EMV),

                        Percent = s.Sum(x => x.Percent),

                    }

                );



            var resultsWithOthers = new List<FIRMWIDE_MANAGER_ALLOCATION>();

            var cutOff = 14;

            if (results != null && results.Count() > cutOff)

            {

                //var cutOff = results.Count() - (results.Count() / 3);

                results = results.OrderByDescending(x => x.EMV);

                resultsWithOthers = results.Take(cutOff).ToList();

                var otherSum = results.Skip(cutOff).Sum(x => x.EMV);

                var sum = results.Sum(x => x.EMV);

                var otherPercent = sum > 0 ? otherSum / sum : 0;

                resultsWithOthers.Add(new FIRMWIDE_MANAGER_ALLOCATION { PRODUCT_NAME = "Other", USD_EMV = otherSum, Percent = otherPercent });

            }

            else

                resultsWithOthers = results.ToList();



            return resultsWithOthers;

        }





          public HttpResponseMessage DownloadFundAllocationDetails(int id, DateTime date)

        {

            var ms = GetStrategy(id);



            DateTime d = new DateTime(date.Year, date.Month, 1).AddMonths(1).AddDays(-1);

            if (ms.FIRM_ID != null)

            {

                var firm = GetService<FIRM>().Get(ms.FIRM_ID.Value);

                IEnumerable<FIRMWIDE_MANAGER_ALLOCATION> allocationsGroup = null;

                var allocationsGrouped = GetAllocationsGrouped(EntityType.Firm, firm.ID, d);





                string fileName = string.Format("{0} as of {1}.xlsx", "test",

                    date.ToString("MMM, yyyy"));

                byte fileContents;

                var newFile = new FileInfo(fileName);

                using (var package = new OfficeOpenXml.ExcelPackage(newFile))

                {

                    FundAllocationsPrinter.Print(package, allocationsGrouped);

                    fileContents = package.GetAsByteArray();

                }





                var result = new HttpResponseMessage(HttpStatusCode.OK)

                {

                    Content = new ByteArrayContent(fileContents)

                };



                result.Content.Headers.ContentDisposition =

                    new ContentDispositionHeaderValue("attachment")

                    {

                        FileName = fileName

                    };



                result.Content.Headers.ContentType =

                    new MediaTypeHeaderValue("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet");



                return result;

            }



            return null;



            #endregion

        }





           private AllocationsViewModel GetAllocationsViewModel(int id, DateTime date)

        {



            var ms = GetStrategy(id);



            DateTime d = new DateTime(date.Year, date.Month, 1).AddMonths(1).AddDays(-1);

            if (ms.FIRM_ID != null)

            {

                var firm = GetService<FIRM>().Get(ms.FIRM_ID.Value);

                var currentEntity = new EntityAllocationsViewModel(new EntityViewModel { EntityId = firm.ID, EntityName = firm.NAME, EntityType = EntityType.Firm });

                //var allocationsGrouped = Mapper.Map<List<FIRMWIDE_MANAGER_ALLOCATION>, List<FirmWideAllocationsViewModel>>(GetAllocationsGrouped(EntityType.Firm, firm.ID, d).ToList());



                //Mapper.Map<ILookup<string,FIRMWIDE_MANAGER_ALLOCATION>,ILookup<string,FirmWideAllocationsViewModel>>((ILookup<string, FIRMWIDE_MANAGER_ALLOCATION>)



                var allocationsGrouped = GetAllocationsGrouped(EntityType.Firm, firm.ID, d);



                var result = new List<FirmWideAllocationsViewModel>();



                foreach (var ag in allocationsGrouped)

                {

                    var allocationsGroup = ag.Select(a => a).OrderByDescending(o=> o.UsdEmv ) ;



                    CreateHierarchy(ag.Key, allocationsGroup, result);

                }



                var missingProducts = Mapper.Map<List<MISSING_PRODUCT>, List<MissingProductsViewModel>>(GetMissingProducts()).GroupBy(a => a.ProductType);



                var vm = new AllocationsViewModel

                {

                    CurrentEntity = currentEntity,

                    ManagerAllocations = result,

                    MissingProducts = missingProducts

                };



                return vm;

            }



            return null;

        }

Interface

 public interface IPackageRepo {



            ILookup<string, FIRMWIDE_MANAGER_ALLOCATION> GetManagerAllocationsGrouped(EntityType entity, int id, DateTime date, int? count = null);

            IEnumerable<FIRMWIDE_MANAGER_ALLOCATION> GetManagerAllocationsGrouped1(EntityType entity, int id, DateTime date, int? count = null);

        }