Switching to next select field by class of parent (js)












0












$begingroup$


This emulates behavior of tab and shifttab with right and left.



I.e., switch focus to the next/previous select field with parent class .tab (which are not siblings in the DOM.)



It works, but any way to make it more elegant? Especially the if/then and the limit to range. I'm fairly new to javascript.



$(document).on('keydown', '.tab select', function (e) {
let tabs = $(".tab select"); //get all tabs
let tab = tabs.index($($(document.activeElement))); //focused tab
if (e.which == 37) { //left arrow
tab -= 1;
} else {
if (e.which == 39) { //right arrow
tab += 1;
}
};
tab = Math.min(tabs.length, Math.max(tab, 0)); //stay in range
tabs.eq(tab).focus()
});









share|improve this question









New contributor




Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$

















    0












    $begingroup$


    This emulates behavior of tab and shifttab with right and left.



    I.e., switch focus to the next/previous select field with parent class .tab (which are not siblings in the DOM.)



    It works, but any way to make it more elegant? Especially the if/then and the limit to range. I'm fairly new to javascript.



    $(document).on('keydown', '.tab select', function (e) {
    let tabs = $(".tab select"); //get all tabs
    let tab = tabs.index($($(document.activeElement))); //focused tab
    if (e.which == 37) { //left arrow
    tab -= 1;
    } else {
    if (e.which == 39) { //right arrow
    tab += 1;
    }
    };
    tab = Math.min(tabs.length, Math.max(tab, 0)); //stay in range
    tabs.eq(tab).focus()
    });









    share|improve this question









    New contributor




    Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$















      0












      0








      0





      $begingroup$


      This emulates behavior of tab and shifttab with right and left.



      I.e., switch focus to the next/previous select field with parent class .tab (which are not siblings in the DOM.)



      It works, but any way to make it more elegant? Especially the if/then and the limit to range. I'm fairly new to javascript.



      $(document).on('keydown', '.tab select', function (e) {
      let tabs = $(".tab select"); //get all tabs
      let tab = tabs.index($($(document.activeElement))); //focused tab
      if (e.which == 37) { //left arrow
      tab -= 1;
      } else {
      if (e.which == 39) { //right arrow
      tab += 1;
      }
      };
      tab = Math.min(tabs.length, Math.max(tab, 0)); //stay in range
      tabs.eq(tab).focus()
      });









      share|improve this question









      New contributor




      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      This emulates behavior of tab and shifttab with right and left.



      I.e., switch focus to the next/previous select field with parent class .tab (which are not siblings in the DOM.)



      It works, but any way to make it more elegant? Especially the if/then and the limit to range. I'm fairly new to javascript.



      $(document).on('keydown', '.tab select', function (e) {
      let tabs = $(".tab select"); //get all tabs
      let tab = tabs.index($($(document.activeElement))); //focused tab
      if (e.which == 37) { //left arrow
      tab -= 1;
      } else {
      if (e.which == 39) { //right arrow
      tab += 1;
      }
      };
      tab = Math.min(tabs.length, Math.max(tab, 0)); //stay in range
      tabs.eq(tab).focus()
      });






      javascript jquery






      share|improve this question









      New contributor




      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 2 hours ago







      Ze'ev













      New contributor




      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 2 hours ago









      Ze'evZe'ev

      1011




      1011




      New contributor




      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Ze'ev is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });






          Ze'ev is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215840%2fswitching-to-next-select-field-by-class-of-parent-js%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Ze'ev is a new contributor. Be nice, and check out our Code of Conduct.










          draft saved

          draft discarded


















          Ze'ev is a new contributor. Be nice, and check out our Code of Conduct.













          Ze'ev is a new contributor. Be nice, and check out our Code of Conduct.












          Ze'ev is a new contributor. Be nice, and check out our Code of Conduct.
















          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215840%2fswitching-to-next-select-field-by-class-of-parent-js%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          How to make a Squid Proxy server?

          Is this a new Fibonacci Identity?

          19世紀