Two-sum solution in JavaScript
$begingroup$
I was given this question during an interview. It is similar to two sum problems and I would like to ask for feedback for my solution.
Merging 2 Packages
Given a package with a weight limit limit and an array arr of item
weights, implement a function getIndicesOfItemWeights that finds two
items whose sum of weights equals the weight limit limit. Your
function should return a pair [i, j] of the indices of the item
weights, ordered such that i > j. If such a pair doesn’t exist, return
an empty array.
Example:
input: arr = [4, 6, 10, 15, 16], lim = 21
output: [3, 1] # since these are the indices of the
# weights 6 and 15 whose sum equals to 21 Constraints:
[time limit] 5000ms
[input] array.integer arr
0 ≤ arr.length ≤ 100 [input] integer limit
[output] array.integer
function getIndicesOfItemWeights(arr, limit) {
let weights = {};
let result =
for ( let i = 0; i < arr.length; i++){
let compliment = limit - arr[i];
if (typeof weights[compliment]!= "undefinded"){
if (i > (weights[compliment])){
result.push(weights[compliment], i);
//return [i, weights[compliment]];
} else {
return [weights[compliment] , i];
}
} else {
weights[arr[i]] = i; // put new weight into weight obj
}
}
return ;
}
let arr = [4, 6, 10, 15, 16];
let limit = 21;
console.log(getIndicesOfItemWeights(arr, limit))
// output: [3, 1] # since these are the indices of the
// weights 6 and 15 whose sum equals to 21javascript interview-questions ecmascript-6 k-sum
$endgroup$
add a comment |
$begingroup$
I was given this question during an interview. It is similar to two sum problems and I would like to ask for feedback for my solution.
Merging 2 Packages
Given a package with a weight limit limit and an array arr of item
weights, implement a function getIndicesOfItemWeights that finds two
items whose sum of weights equals the weight limit limit. Your
function should return a pair [i, j] of the indices of the item
weights, ordered such that i > j. If such a pair doesn’t exist, return
an empty array.
Example:
input: arr = [4, 6, 10, 15, 16], lim = 21
output: [3, 1] # since these are the indices of the
# weights 6 and 15 whose sum equals to 21 Constraints:
[time limit] 5000ms
[input] array.integer arr
0 ≤ arr.length ≤ 100 [input] integer limit
[output] array.integer
function getIndicesOfItemWeights(arr, limit) {
let weights = {};
let result =
for ( let i = 0; i < arr.length; i++){
let compliment = limit - arr[i];
if (typeof weights[compliment]!= "undefinded"){
if (i > (weights[compliment])){
result.push(weights[compliment], i);
//return [i, weights[compliment]];
} else {
return [weights[compliment] , i];
}
} else {
weights[arr[i]] = i; // put new weight into weight obj
}
}
return ;
}
let arr = [4, 6, 10, 15, 16];
let limit = 21;
console.log(getIndicesOfItemWeights(arr, limit))
// output: [3, 1] # since these are the indices of the
// weights 6 and 15 whose sum equals to 21javascript interview-questions ecmascript-6 k-sum
$endgroup$
$begingroup$
Your code logs[undefined, 0]- should it actually log[3, 1]?
$endgroup$
– Sᴀᴍ Onᴇᴌᴀ
1 hour ago
add a comment |
$begingroup$
I was given this question during an interview. It is similar to two sum problems and I would like to ask for feedback for my solution.
Merging 2 Packages
Given a package with a weight limit limit and an array arr of item
weights, implement a function getIndicesOfItemWeights that finds two
items whose sum of weights equals the weight limit limit. Your
function should return a pair [i, j] of the indices of the item
weights, ordered such that i > j. If such a pair doesn’t exist, return
an empty array.
Example:
input: arr = [4, 6, 10, 15, 16], lim = 21
output: [3, 1] # since these are the indices of the
# weights 6 and 15 whose sum equals to 21 Constraints:
[time limit] 5000ms
[input] array.integer arr
0 ≤ arr.length ≤ 100 [input] integer limit
[output] array.integer
function getIndicesOfItemWeights(arr, limit) {
let weights = {};
let result =
for ( let i = 0; i < arr.length; i++){
let compliment = limit - arr[i];
if (typeof weights[compliment]!= "undefinded"){
if (i > (weights[compliment])){
result.push(weights[compliment], i);
//return [i, weights[compliment]];
} else {
return [weights[compliment] , i];
}
} else {
weights[arr[i]] = i; // put new weight into weight obj
}
}
return ;
}
let arr = [4, 6, 10, 15, 16];
let limit = 21;
console.log(getIndicesOfItemWeights(arr, limit))
// output: [3, 1] # since these are the indices of the
// weights 6 and 15 whose sum equals to 21javascript interview-questions ecmascript-6 k-sum
$endgroup$
I was given this question during an interview. It is similar to two sum problems and I would like to ask for feedback for my solution.
Merging 2 Packages
Given a package with a weight limit limit and an array arr of item
weights, implement a function getIndicesOfItemWeights that finds two
items whose sum of weights equals the weight limit limit. Your
function should return a pair [i, j] of the indices of the item
weights, ordered such that i > j. If such a pair doesn’t exist, return
an empty array.
Example:
input: arr = [4, 6, 10, 15, 16], lim = 21
output: [3, 1] # since these are the indices of the
# weights 6 and 15 whose sum equals to 21 Constraints:
[time limit] 5000ms
[input] array.integer arr
0 ≤ arr.length ≤ 100 [input] integer limit
[output] array.integer
function getIndicesOfItemWeights(arr, limit) {
let weights = {};
let result =
for ( let i = 0; i < arr.length; i++){
let compliment = limit - arr[i];
if (typeof weights[compliment]!= "undefinded"){
if (i > (weights[compliment])){
result.push(weights[compliment], i);
//return [i, weights[compliment]];
} else {
return [weights[compliment] , i];
}
} else {
weights[arr[i]] = i; // put new weight into weight obj
}
}
return ;
}
let arr = [4, 6, 10, 15, 16];
let limit = 21;
console.log(getIndicesOfItemWeights(arr, limit))
// output: [3, 1] # since these are the indices of the
// weights 6 and 15 whose sum equals to 21function getIndicesOfItemWeights(arr, limit) {
let weights = {};
let result =
for ( let i = 0; i < arr.length; i++){
let compliment = limit - arr[i];
if (typeof weights[compliment]!= "undefinded"){
if (i > (weights[compliment])){
result.push(weights[compliment], i);
//return [i, weights[compliment]];
} else {
return [weights[compliment] , i];
}
} else {
weights[arr[i]] = i; // put new weight into weight obj
}
}
return ;
}
let arr = [4, 6, 10, 15, 16];
let limit = 21;
console.log(getIndicesOfItemWeights(arr, limit))
// output: [3, 1] # since these are the indices of the
// weights 6 and 15 whose sum equals to 21function getIndicesOfItemWeights(arr, limit) {
let weights = {};
let result =
for ( let i = 0; i < arr.length; i++){
let compliment = limit - arr[i];
if (typeof weights[compliment]!= "undefinded"){
if (i > (weights[compliment])){
result.push(weights[compliment], i);
//return [i, weights[compliment]];
} else {
return [weights[compliment] , i];
}
} else {
weights[arr[i]] = i; // put new weight into weight obj
}
}
return ;
}
let arr = [4, 6, 10, 15, 16];
let limit = 21;
console.log(getIndicesOfItemWeights(arr, limit))
// output: [3, 1] # since these are the indices of the
// weights 6 and 15 whose sum equals to 21javascript interview-questions ecmascript-6 k-sum
javascript interview-questions ecmascript-6 k-sum
edited 1 hour ago
200_success
129k15153415
129k15153415
asked 3 hours ago
NinjaGNinjaG
762427
762427
$begingroup$
Your code logs[undefined, 0]- should it actually log[3, 1]?
$endgroup$
– Sᴀᴍ Onᴇᴌᴀ
1 hour ago
add a comment |
$begingroup$
Your code logs[undefined, 0]- should it actually log[3, 1]?
$endgroup$
– Sᴀᴍ Onᴇᴌᴀ
1 hour ago
$begingroup$
Your code logs
[undefined, 0] - should it actually log [3, 1]?$endgroup$
– Sᴀᴍ Onᴇᴌᴀ
1 hour ago
$begingroup$
Your code logs
[undefined, 0] - should it actually log [3, 1]?$endgroup$
– Sᴀᴍ Onᴇᴌᴀ
1 hour ago
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212494%2ftwo-sum-solution-in-javascript%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f212494%2ftwo-sum-solution-in-javascript%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
$begingroup$
Your code logs
[undefined, 0]- should it actually log[3, 1]?$endgroup$
– Sᴀᴍ Onᴇᴌᴀ
1 hour ago